Просмотр исходного кода

Use networkidle0 for inspect_site

Saoud Rizwan 1 год назад
Родитель
Сommit
99a82e5563
2 измененных файлов с 7 добавлено и 8 удалено
  1. 1 1
      package.json
  2. 6 7
      src/utils/UrlContentFetcher.ts

+ 1 - 1
package.json

@@ -2,7 +2,7 @@
   "name": "claude-dev",
   "displayName": "Claude Dev",
   "description": "Autonomous coding agent right in your IDE, capable of creating/editing files, executing commands, and more with your permission every step of the way.",
-  "version": "1.9.0",
+  "version": "1.9.1",
   "icon": "icons/icon.png",
   "galleryBanner": {
     "color": "#1E1E1E",

+ 6 - 7
src/utils/UrlContentFetcher.ts

@@ -1,7 +1,7 @@
 import * as vscode from "vscode"
 import * as fs from "fs/promises"
 import * as path from "path"
-import { Browser, Page, launch } from "puppeteer-core"
+import { Browser, Page, TimeoutError, launch } from "puppeteer-core"
 import * as cheerio from "cheerio"
 import TurndownService from "turndown"
 // @ts-ignore
@@ -113,13 +113,12 @@ export class UrlContentFetcher {
 		})
 
 		try {
-			// networkidle2 is a good point to take a screenshot without having to wait for the timeout to hit if the site never reaches networkidle0
-			await this.page.goto(url, { timeout: 10_000, waitUntil: ["domcontentloaded", "networkidle2"] })
+			// networkidle2 isn't good enough since page may take some time to load. we can assume locally running dev sites will reach networkidle0 in a reasonable amount of time
+			await this.page.goto(url, { timeout: 7_000, waitUntil: ["domcontentloaded", "networkidle0"] })
 		} catch (err) {
-			// if (!(err instanceof TimeoutError)) {
-			// 	logs.push(`[Navigation Error] ${err.toString()}`)
-			// }
-			logs.push(`[Navigation Error] ${err.toString()}`)
+			if (!(err instanceof TimeoutError)) {
+				logs.push(`[Navigation Error] ${err.toString()}`)
+			}
 		}
 
 		// Wait for console inactivity, with a timeout