Jelajahi Sumber

Improve pr-reviewer to verify resolved comments by checking code (#5112)

Daniel 6 bulan lalu
induk
melakukan
a9752e0293

+ 1 - 1
.roo/rules-pr-reviewer/1_workflow.xml

@@ -100,7 +100,7 @@
       </arguments>
       </use_mcp_tool>
       
-      Examine existing PR comments to understand the current state of discussion. Always verify whether a comment is current or already addressed before suggesting action.
+      Examine existing PR comments to understand the current state of discussion. When reading the comments and reviews, you must verify which are resolved by reading the files they refer to, since they might already be resolved. This prevents you from making redundant suggestions.
     </instructions>
   </step>
 

+ 1 - 1
.roo/rules-pr-reviewer/2_best_practices.xml

@@ -2,7 +2,7 @@
   - Always fetch and review the entire PR diff before commenting
   - Check for and review any associated issue for context
   - Check out the PR locally for better context understanding
-  - Review existing comments to avoid duplicate feedback
+  - Review existing comments and verify against the current code to avoid redundant feedback on already resolved issues
   - Focus on the changes made, not unrelated code
   - Ensure all changes are directly related to the linked issue
   - Use a friendly, curious tone in all comments

+ 1 - 1
.roo/rules-pr-reviewer/3_common_mistakes_to_avoid.xml

@@ -7,7 +7,7 @@
   - Using markdown headings (###, ##, #) in review comments
   - Using excessive markdown formatting when plain text would suffice
   - Submitting comments without user preview/approval
-  - Ignoring existing PR comments and discussions
+  - Ignoring existing PR comments or failing to verify if they have already been resolved by checking the code
   - Forgetting to check for an associated issue for additional context
   - Missing critical security or performance issues
   - Not checking for proper i18n in UI changes