multiedit_test.go 6.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225
  1. package tools
  2. import (
  3. "context"
  4. "os"
  5. "path/filepath"
  6. "testing"
  7. "github.com/charmbracelet/crush/internal/csync"
  8. "github.com/charmbracelet/crush/internal/history"
  9. "github.com/charmbracelet/crush/internal/lsp"
  10. "github.com/charmbracelet/crush/internal/permission"
  11. "github.com/charmbracelet/crush/internal/pubsub"
  12. "github.com/stretchr/testify/require"
  13. )
  14. type mockPermissionService struct {
  15. *pubsub.Broker[permission.PermissionRequest]
  16. }
  17. func (m *mockPermissionService) Request(req permission.CreatePermissionRequest) bool {
  18. return true
  19. }
  20. func (m *mockPermissionService) Grant(req permission.PermissionRequest) {}
  21. func (m *mockPermissionService) Deny(req permission.PermissionRequest) {}
  22. func (m *mockPermissionService) GrantPersistent(req permission.PermissionRequest) {}
  23. func (m *mockPermissionService) AutoApproveSession(sessionID string) {}
  24. func (m *mockPermissionService) SetSkipRequests(skip bool) {}
  25. func (m *mockPermissionService) SkipRequests() bool {
  26. return false
  27. }
  28. func (m *mockPermissionService) SubscribeNotifications(ctx context.Context) <-chan pubsub.Event[permission.PermissionNotification] {
  29. return make(<-chan pubsub.Event[permission.PermissionNotification])
  30. }
  31. type mockHistoryService struct {
  32. *pubsub.Broker[history.File]
  33. }
  34. func (m *mockHistoryService) Create(ctx context.Context, sessionID, path, content string) (history.File, error) {
  35. return history.File{Path: path, Content: content}, nil
  36. }
  37. func (m *mockHistoryService) CreateVersion(ctx context.Context, sessionID, path, content string) (history.File, error) {
  38. return history.File{}, nil
  39. }
  40. func (m *mockHistoryService) GetByPathAndSession(ctx context.Context, path, sessionID string) (history.File, error) {
  41. return history.File{Path: path, Content: ""}, nil
  42. }
  43. func (m *mockHistoryService) Get(ctx context.Context, id string) (history.File, error) {
  44. return history.File{}, nil
  45. }
  46. func (m *mockHistoryService) ListBySession(ctx context.Context, sessionID string) ([]history.File, error) {
  47. return nil, nil
  48. }
  49. func (m *mockHistoryService) ListLatestSessionFiles(ctx context.Context, sessionID string) ([]history.File, error) {
  50. return nil, nil
  51. }
  52. func (m *mockHistoryService) Delete(ctx context.Context, id string) error {
  53. return nil
  54. }
  55. func (m *mockHistoryService) DeleteSessionFiles(ctx context.Context, sessionID string) error {
  56. return nil
  57. }
  58. func TestApplyEditToContentPartialSuccess(t *testing.T) {
  59. t.Parallel()
  60. content := "line 1\nline 2\nline 3\n"
  61. // Test successful edit.
  62. newContent, err := applyEditToContent(content, MultiEditOperation{
  63. OldString: "line 1",
  64. NewString: "LINE 1",
  65. })
  66. require.NoError(t, err)
  67. require.Contains(t, newContent, "LINE 1")
  68. require.Contains(t, newContent, "line 2")
  69. // Test failed edit (string not found).
  70. _, err = applyEditToContent(content, MultiEditOperation{
  71. OldString: "line 99",
  72. NewString: "LINE 99",
  73. })
  74. require.Error(t, err)
  75. require.Contains(t, err.Error(), "not found")
  76. }
  77. func TestMultiEditSequentialApplication(t *testing.T) {
  78. t.Parallel()
  79. tmpDir := t.TempDir()
  80. testFile := filepath.Join(tmpDir, "test.txt")
  81. // Create test file.
  82. content := "line 1\nline 2\nline 3\nline 4\n"
  83. err := os.WriteFile(testFile, []byte(content), 0o644)
  84. require.NoError(t, err)
  85. // Mock components.
  86. lspClients := csync.NewMap[string, *lsp.Client]()
  87. permissions := &mockPermissionService{Broker: pubsub.NewBroker[permission.PermissionRequest]()}
  88. files := &mockHistoryService{Broker: pubsub.NewBroker[history.File]()}
  89. // Create multiedit tool.
  90. _ = NewMultiEditTool(lspClients, permissions, files, tmpDir)
  91. // Simulate reading the file first.
  92. recordFileRead(testFile)
  93. // Manually test the sequential application logic.
  94. currentContent := content
  95. // Apply edits sequentially, tracking failures.
  96. edits := []MultiEditOperation{
  97. {OldString: "line 1", NewString: "LINE 1"}, // Should succeed
  98. {OldString: "line 99", NewString: "LINE 99"}, // Should fail - doesn't exist
  99. {OldString: "line 3", NewString: "LINE 3"}, // Should succeed
  100. {OldString: "line 2", NewString: "LINE 2"}, // Should succeed - still exists
  101. }
  102. var failedEdits []FailedEdit
  103. successCount := 0
  104. for i, edit := range edits {
  105. newContent, err := applyEditToContent(currentContent, edit)
  106. if err != nil {
  107. failedEdits = append(failedEdits, FailedEdit{
  108. Index: i + 1,
  109. Error: err.Error(),
  110. Edit: edit,
  111. })
  112. continue
  113. }
  114. currentContent = newContent
  115. successCount++
  116. }
  117. // Verify results.
  118. require.Equal(t, 3, successCount, "Expected 3 successful edits")
  119. require.Len(t, failedEdits, 1, "Expected 1 failed edit")
  120. // Check failed edit details.
  121. require.Equal(t, 2, failedEdits[0].Index)
  122. require.Contains(t, failedEdits[0].Error, "not found")
  123. // Verify content changes.
  124. require.Contains(t, currentContent, "LINE 1")
  125. require.Contains(t, currentContent, "LINE 2")
  126. require.Contains(t, currentContent, "LINE 3")
  127. require.Contains(t, currentContent, "line 4") // Original unchanged
  128. require.NotContains(t, currentContent, "LINE 99")
  129. }
  130. func TestMultiEditAllEditsSucceed(t *testing.T) {
  131. t.Parallel()
  132. content := "line 1\nline 2\nline 3\n"
  133. edits := []MultiEditOperation{
  134. {OldString: "line 1", NewString: "LINE 1"},
  135. {OldString: "line 2", NewString: "LINE 2"},
  136. {OldString: "line 3", NewString: "LINE 3"},
  137. }
  138. currentContent := content
  139. successCount := 0
  140. for _, edit := range edits {
  141. newContent, err := applyEditToContent(currentContent, edit)
  142. if err != nil {
  143. t.Fatalf("Unexpected error: %v", err)
  144. }
  145. currentContent = newContent
  146. successCount++
  147. }
  148. require.Equal(t, 3, successCount)
  149. require.Contains(t, currentContent, "LINE 1")
  150. require.Contains(t, currentContent, "LINE 2")
  151. require.Contains(t, currentContent, "LINE 3")
  152. }
  153. func TestMultiEditAllEditsFail(t *testing.T) {
  154. t.Parallel()
  155. content := "line 1\nline 2\n"
  156. edits := []MultiEditOperation{
  157. {OldString: "line 99", NewString: "LINE 99"},
  158. {OldString: "line 100", NewString: "LINE 100"},
  159. }
  160. currentContent := content
  161. var failedEdits []FailedEdit
  162. for i, edit := range edits {
  163. newContent, err := applyEditToContent(currentContent, edit)
  164. if err != nil {
  165. failedEdits = append(failedEdits, FailedEdit{
  166. Index: i + 1,
  167. Error: err.Error(),
  168. Edit: edit,
  169. })
  170. continue
  171. }
  172. currentContent = newContent
  173. }
  174. require.Len(t, failedEdits, 2)
  175. require.Equal(t, content, currentContent, "Content should be unchanged")
  176. }