|
|
@@ -0,0 +1,134 @@
|
|
|
+# PR #5234 Review - Real Issues Only
|
|
|
+
|
|
|
+## Summary
|
|
|
+
|
|
|
+The original review identified many false positives. **Important: The `@roo-code/*` package names throughout the codebase are CORRECT and intentional.** These are the actual package names used in the monorepo and should NOT be changed to `@kilocode/*`.
|
|
|
+
|
|
|
+This document contains only the **real issues** that need to be fixed.
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+## Real Issues Requiring Fixes
|
|
|
+
|
|
|
+### 1. `.changeset/config.json` - Incorrect CLI Package Name in Ignore Rule
|
|
|
+
|
|
|
+**File:** `.changeset/config.json` (line 10)
|
|
|
+
|
|
|
+**Problem:** The ignore rule references `@roo-code/cli`, but the CLI package is actually named `@kilocode/cli`.
|
|
|
+
|
|
|
+```json
|
|
|
+"ignore": ["@roo-code/cli"]
|
|
|
+```
|
|
|
+
|
|
|
+**Fix:** Change to one of:
|
|
|
+
|
|
|
+- `"ignore": ["@kilocode/cli"]` (if CLI should be ignored)
|
|
|
+- `"ignore": []` (if nothing should be ignored)
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+### 2. OpenAI Codex Provider - User-Agent Branding
|
|
|
+
|
|
|
+**File:** `src/api/providers/openai-codex.ts` (lines 354-356)
|
|
|
+
|
|
|
+**Problem:** Uses "roo-code" in originator and User-Agent strings:
|
|
|
+
|
|
|
+```typescript
|
|
|
+originator: "roo-code"
|
|
|
+"User-Agent": "roo-code/${Package.version}..."
|
|
|
+```
|
|
|
+
|
|
|
+**Fix:** Change both occurrences to "kilo-code":
|
|
|
+
|
|
|
+```typescript
|
|
|
+originator: "kilo-code"
|
|
|
+"User-Agent": "kilo-code/${Package.version}..."
|
|
|
+```
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+### 3. OpenAI Native Provider - User-Agent Branding
|
|
|
+
|
|
|
+**File:** `src/api/providers/openai-native.ts` (lines 88-94)
|
|
|
+
|
|
|
+**Problem:** Uses "roo-code" in originator and User-Agent strings.
|
|
|
+
|
|
|
+**Fix:** Change to "kilo-code" in both the originator field and User-Agent header.
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+### 4. Unbound Provider - Origin App Constant
|
|
|
+
|
|
|
+**File:** `src/api/providers/unbound.ts` (line 19)
|
|
|
+
|
|
|
+**Problem:**
|
|
|
+
|
|
|
+```typescript
|
|
|
+const ORIGIN_APP = "roo-code"
|
|
|
+```
|
|
|
+
|
|
|
+**Fix:** Change to:
|
|
|
+
|
|
|
+```typescript
|
|
|
+const ORIGIN_APP = "kilo-code"
|
|
|
+```
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+### 5. Cerebras Test Mock - Branding in Test Headers
|
|
|
+
|
|
|
+**File:** `src/api/providers/__tests__/cerebras.spec.ts` (lines 16-17)
|
|
|
+
|
|
|
+**Problem:** Test mock uses Roo Code branding:
|
|
|
+
|
|
|
+```typescript
|
|
|
+"X-Title": "Roo Code"
|
|
|
+"User-Agent": "RooCode/1.0.0"
|
|
|
+```
|
|
|
+
|
|
|
+**Fix:** Update to Kilo Code branding:
|
|
|
+
|
|
|
+```typescript
|
|
|
+"X-Title": "Kilo Code"
|
|
|
+"User-Agent": "KiloCode/1.0.0"
|
|
|
+```
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+## Minor/Optional Issues
|
|
|
+
|
|
|
+### 6. `.gitignore` - CLI Tarball Pattern (Minor)
|
|
|
+
|
|
|
+**File:** `.gitignore` (line 75)
|
|
|
+
|
|
|
+**Problem:** Pattern `roo-cli-*.tar.gz*` won't match Kilo Code CLI tarballs.
|
|
|
+
|
|
|
+**Impact:** Harmless but unnecessary pattern that won't match anything.
|
|
|
+
|
|
|
+**Fix (optional):** Update to `kilo-cli-*.tar.gz*` or remove if not needed.
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+### 7. E2E README - Documentation Branding (Cosmetic)
|
|
|
+
|
|
|
+**File:** `apps/vscode-e2e/README.md` (lines 1-2)
|
|
|
+
|
|
|
+**Problem:** Documentation says "E2E Tests for Roo Code".
|
|
|
+
|
|
|
+**Impact:** Documentation only, no functional impact.
|
|
|
+
|
|
|
+**Fix (optional):** Update to "E2E Tests for Kilo Code".
|
|
|
+
|
|
|
+---
|
|
|
+
|
|
|
+## What Does NOT Need to Change
|
|
|
+
|
|
|
+The following are **CORRECT** and should **NOT** be changed:
|
|
|
+
|
|
|
+- ✅ All `@roo-code/*` package names in `package.json` files
|
|
|
+- ✅ All `@roo-code/*` imports in TypeScript/JavaScript files
|
|
|
+- ✅ All `@roo-code/*` references in configuration files
|
|
|
+- ✅ The `packages/roo-types/` directory name
|
|
|
+- ✅ Any other `@roo-code/*` package references
|
|
|
+
|
|
|
+These are the actual package names used in the monorepo structure and are intentionally kept as `@roo-code/*` for internal consistency.
|