Browse Source

fix(desktop): conditionally show review pane toggle

Adam 2 months ago
parent
commit
3aca9e5fa5
2 changed files with 32 additions and 31 deletions
  1. 31 29
      packages/app/src/components/header.tsx
  2. 1 2
      packages/app/src/pages/session.tsx

+ 31 - 29
packages/app/src/components/header.tsx

@@ -109,35 +109,37 @@ export function Header(props: {
                   </Show>
                   </Show>
                 </div>
                 </div>
                 <div class="flex items-center gap-4">
                 <div class="flex items-center gap-4">
-                  <Tooltip
-                    class="hidden md:block shrink-0"
-                    value={
-                      <div class="flex items-center gap-2">
-                        <span>Toggle review</span>
-                        <span class="text-icon-base text-12-medium">{command.keybind("review.toggle")}</span>
-                      </div>
-                    }
-                  >
-                    <Button variant="ghost" class="group/review-toggle size-6 p-0" onClick={layout.review.toggle}>
-                      <div class="relative flex items-center justify-center size-4 [&>*]:absolute [&>*]:inset-0">
-                        <Icon
-                          size="small"
-                          name={layout.review.opened() ? "layout-right-full" : "layout-right"}
-                          class="group-hover/review-toggle:hidden"
-                        />
-                        <Icon
-                          size="small"
-                          name="layout-right-partial"
-                          class="hidden group-hover/review-toggle:inline-block"
-                        />
-                        <Icon
-                          size="small"
-                          name={layout.review.opened() ? "layout-right" : "layout-right-full"}
-                          class="hidden group-active/review-toggle:inline-block"
-                        />
-                      </div>
-                    </Button>
-                  </Tooltip>
+                  <Show when={currentSession()?.summary?.files}>
+                    <Tooltip
+                      class="hidden md:block shrink-0"
+                      value={
+                        <div class="flex items-center gap-2">
+                          <span>Toggle review</span>
+                          <span class="text-icon-base text-12-medium">{command.keybind("review.toggle")}</span>
+                        </div>
+                      }
+                    >
+                      <Button variant="ghost" class="group/review-toggle size-6 p-0" onClick={layout.review.toggle}>
+                        <div class="relative flex items-center justify-center size-4 [&>*]:absolute [&>*]:inset-0">
+                          <Icon
+                            name={layout.review.opened() ? "layout-right" : "layout-left"}
+                            size="small"
+                            class="group-hover/review-toggle:hidden"
+                          />
+                          <Icon
+                            name={layout.review.opened() ? "layout-right-partial" : "layout-left-partial"}
+                            size="small"
+                            class="hidden group-hover/review-toggle:inline-block"
+                          />
+                          <Icon
+                            name={layout.review.opened() ? "layout-right-full" : "layout-left-full"}
+                            size="small"
+                            class="hidden group-active/review-toggle:inline-block"
+                          />
+                        </div>
+                      </Button>
+                    </Tooltip>
+                  </Show>
                   <Tooltip
                   <Tooltip
                     class="hidden md:block shrink-0"
                     class="hidden md:block shrink-0"
                     value={
                     value={

+ 1 - 2
packages/app/src/pages/session.tsx

@@ -226,8 +226,7 @@ export default function Page() {
       title: "Toggle review",
       title: "Toggle review",
       description: "Show or hide the review panel",
       description: "Show or hide the review panel",
       category: "View",
       category: "View",
-      keybind: "mod+b",
-      slash: "review",
+      keybind: "mod+shift+r",
       onSelect: () => layout.review.toggle(),
       onSelect: () => layout.review.toggle(),
     },
     },
     {
     {