|
|
@@ -332,8 +332,9 @@ export const SessionReview = (props: SessionReviewProps) => {
|
|
|
const beforeText = () => (typeof diff.before === "string" ? diff.before : "")
|
|
|
const afterText = () => (typeof diff.after === "string" ? diff.after : "")
|
|
|
|
|
|
- const isAdded = () => beforeText().length === 0 && afterText().length > 0
|
|
|
- const isDeleted = () => afterText().length === 0 && beforeText().length > 0
|
|
|
+ const isAdded = () => diff.status === "added" || (beforeText().length === 0 && afterText().length > 0)
|
|
|
+ const isDeleted = () =>
|
|
|
+ diff.status === "deleted" || (afterText().length === 0 && beforeText().length > 0)
|
|
|
const isImage = () => isImageFile(diff.file)
|
|
|
const isAudio = () => isAudioFile(diff.file)
|
|
|
|
|
|
@@ -422,6 +423,7 @@ export const SessionReview = (props: SessionReviewProps) => {
|
|
|
if (!isImage()) return
|
|
|
if (imageSrc()) return
|
|
|
if (imageStatus() !== "idle") return
|
|
|
+ if (isDeleted()) return
|
|
|
|
|
|
const reader = props.readFile
|
|
|
if (!reader) return
|
|
|
@@ -546,6 +548,11 @@ export const SessionReview = (props: SessionReviewProps) => {
|
|
|
{i18n.t("ui.sessionReview.change.removed")}
|
|
|
</span>
|
|
|
</Match>
|
|
|
+ <Match when={isImage()}>
|
|
|
+ <span data-slot="session-review-change" data-type="modified">
|
|
|
+ {i18n.t("ui.sessionReview.change.modified")}
|
|
|
+ </span>
|
|
|
+ </Match>
|
|
|
<Match when={true}>
|
|
|
<DiffChanges changes={diff} />
|
|
|
</Match>
|
|
|
@@ -564,28 +571,51 @@ export const SessionReview = (props: SessionReviewProps) => {
|
|
|
scheduleAnchors()
|
|
|
}}
|
|
|
>
|
|
|
- <Dynamic
|
|
|
- component={diffComponent}
|
|
|
- preloadedDiff={diff.preloaded}
|
|
|
- diffStyle={diffStyle()}
|
|
|
- onRendered={() => {
|
|
|
- props.onDiffRendered?.()
|
|
|
- scheduleAnchors()
|
|
|
- }}
|
|
|
- enableLineSelection={props.onLineComment != null}
|
|
|
- onLineSelected={handleLineSelected}
|
|
|
- onLineSelectionEnd={handleLineSelectionEnd}
|
|
|
- selectedLines={selectedLines()}
|
|
|
- commentedLines={commentedLines()}
|
|
|
- before={{
|
|
|
- name: diff.file!,
|
|
|
- contents: typeof diff.before === "string" ? diff.before : "",
|
|
|
- }}
|
|
|
- after={{
|
|
|
- name: diff.file!,
|
|
|
- contents: typeof diff.after === "string" ? diff.after : "",
|
|
|
- }}
|
|
|
- />
|
|
|
+ <Switch>
|
|
|
+ <Match when={isImage() && imageSrc()}>
|
|
|
+ <div data-slot="session-review-image-container">
|
|
|
+ <img data-slot="session-review-image" src={imageSrc()} alt={diff.file} />
|
|
|
+ </div>
|
|
|
+ </Match>
|
|
|
+ <Match when={isImage() && isDeleted()}>
|
|
|
+ <div data-slot="session-review-image-container" data-removed>
|
|
|
+ <span data-slot="session-review-image-placeholder">
|
|
|
+ {i18n.t("ui.sessionReview.change.removed")}
|
|
|
+ </span>
|
|
|
+ </div>
|
|
|
+ </Match>
|
|
|
+ <Match when={isImage() && !imageSrc()}>
|
|
|
+ <div data-slot="session-review-image-container">
|
|
|
+ <span data-slot="session-review-image-placeholder">
|
|
|
+ {imageStatus() === "loading" ? "Loading..." : "Image"}
|
|
|
+ </span>
|
|
|
+ </div>
|
|
|
+ </Match>
|
|
|
+ <Match when={!isImage()}>
|
|
|
+ <Dynamic
|
|
|
+ component={diffComponent}
|
|
|
+ preloadedDiff={diff.preloaded}
|
|
|
+ diffStyle={diffStyle()}
|
|
|
+ onRendered={() => {
|
|
|
+ props.onDiffRendered?.()
|
|
|
+ scheduleAnchors()
|
|
|
+ }}
|
|
|
+ enableLineSelection={props.onLineComment != null}
|
|
|
+ onLineSelected={handleLineSelected}
|
|
|
+ onLineSelectionEnd={handleLineSelectionEnd}
|
|
|
+ selectedLines={selectedLines()}
|
|
|
+ commentedLines={commentedLines()}
|
|
|
+ before={{
|
|
|
+ name: diff.file!,
|
|
|
+ contents: typeof diff.before === "string" ? diff.before : "",
|
|
|
+ }}
|
|
|
+ after={{
|
|
|
+ name: diff.file!,
|
|
|
+ contents: typeof diff.after === "string" ? diff.after : "",
|
|
|
+ }}
|
|
|
+ />
|
|
|
+ </Match>
|
|
|
+ </Switch>
|
|
|
|
|
|
<For each={comments()}>
|
|
|
{(comment) => (
|
Daniel Polito