Browse Source

fix(ui): move filename and line count below comment text in popovers

David Hill 1 month ago
parent
commit
c66da17364

+ 3 - 3
packages/app/src/pages/session.tsx

@@ -2032,12 +2032,12 @@ export default function Page() {
                               <Show when={openedComment() === comment.id}>
                               <Show when={openedComment() === comment.id}>
                                 <div class="absolute top-0 right-[calc(100%+12px)] z-40 min-w-[200px] max-w-[320px] rounded-md bg-surface-raised-stronger-non-alpha border border-border-base shadow-md p-3">
                                 <div class="absolute top-0 right-[calc(100%+12px)] z-40 min-w-[200px] max-w-[320px] rounded-md bg-surface-raised-stronger-non-alpha border border-border-base shadow-md p-3">
                                   <div class="flex flex-col gap-1.5">
                                   <div class="flex flex-col gap-1.5">
-                                    <div class="text-12-medium text-text-strong whitespace-nowrap">
-                                      {getFilename(comment.file)}:{commentLabel(comment.selection)}
-                                    </div>
                                     <div class="text-12-regular text-text-base whitespace-pre-wrap">
                                     <div class="text-12-regular text-text-base whitespace-pre-wrap">
                                       {comment.comment}
                                       {comment.comment}
                                     </div>
                                     </div>
+                                    <div class="text-12-medium text-text-strong whitespace-nowrap">
+                                      {getFilename(comment.file)}:{commentLabel(comment.selection)}
+                                    </div>
                                   </div>
                                   </div>
                                 </div>
                                 </div>
                               </Show>
                               </Show>

+ 1 - 1
packages/ui/src/components/session-review.tsx

@@ -586,10 +586,10 @@ export const SessionReview = (props: SessionReviewProps) => {
                             <Show when={isCommentOpen(comment)}>
                             <Show when={isCommentOpen(comment)}>
                               <div data-slot="session-review-comment-popover-content">
                               <div data-slot="session-review-comment-popover-content">
                                 <div data-slot="session-review-comment-popover">
                                 <div data-slot="session-review-comment-popover">
+                                  <div data-slot="session-review-comment-popover-text">{comment.comment}</div>
                                   <div data-slot="session-review-comment-popover-label">
                                   <div data-slot="session-review-comment-popover-label">
                                     {getFilename(comment.file)}:{selectionLabel(comment.selection)}
                                     {getFilename(comment.file)}:{selectionLabel(comment.selection)}
                                   </div>
                                   </div>
-                                  <div data-slot="session-review-comment-popover-text">{comment.comment}</div>
                                 </div>
                                 </div>
                               </div>
                               </div>
                             </Show>
                             </Show>