| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496 |
- import { describe, test, expect } from "bun:test"
- import path from "path"
- import fs from "fs/promises"
- import { EditTool } from "../../src/tool/edit"
- import { Instance } from "../../src/project/instance"
- import { tmpdir } from "../fixture/fixture"
- import { FileTime } from "../../src/file/time"
- const ctx = {
- sessionID: "test-edit-session",
- messageID: "",
- callID: "",
- agent: "build",
- abort: AbortSignal.any([]),
- messages: [],
- metadata: () => {},
- ask: async () => {},
- }
- describe("tool.edit", () => {
- describe("creating new files", () => {
- test("creates new file when oldString is empty", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "newfile.txt")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- const edit = await EditTool.init()
- const result = await edit.execute(
- {
- filePath: filepath,
- oldString: "",
- newString: "new content",
- },
- ctx,
- )
- expect(result.metadata.diff).toContain("new content")
- const content = await fs.readFile(filepath, "utf-8")
- expect(content).toBe("new content")
- },
- })
- })
- test("creates new file with nested directories", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "nested", "dir", "file.txt")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- const edit = await EditTool.init()
- await edit.execute(
- {
- filePath: filepath,
- oldString: "",
- newString: "nested file",
- },
- ctx,
- )
- const content = await fs.readFile(filepath, "utf-8")
- expect(content).toBe("nested file")
- },
- })
- })
- test("emits add event for new files", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "new.txt")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- const { Bus } = await import("../../src/bus")
- const { File } = await import("../../src/file")
- const { FileWatcher } = await import("../../src/file/watcher")
- const events: string[] = []
- const unsubEdited = Bus.subscribe(File.Event.Edited, () => events.push("edited"))
- const unsubUpdated = Bus.subscribe(FileWatcher.Event.Updated, () => events.push("updated"))
- const edit = await EditTool.init()
- await edit.execute(
- {
- filePath: filepath,
- oldString: "",
- newString: "content",
- },
- ctx,
- )
- expect(events).toContain("edited")
- expect(events).toContain("updated")
- unsubEdited()
- unsubUpdated()
- },
- })
- })
- })
- describe("editing existing files", () => {
- test("replaces text in existing file", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "existing.txt")
- await fs.writeFile(filepath, "old content here", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- const result = await edit.execute(
- {
- filePath: filepath,
- oldString: "old content",
- newString: "new content",
- },
- ctx,
- )
- expect(result.output).toContain("Edit applied successfully")
- const content = await fs.readFile(filepath, "utf-8")
- expect(content).toBe("new content here")
- },
- })
- })
- test("throws error when file does not exist", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "nonexistent.txt")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: filepath,
- oldString: "old",
- newString: "new",
- },
- ctx,
- ),
- ).rejects.toThrow("not found")
- },
- })
- })
- test("throws error when oldString equals newString", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "content", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: filepath,
- oldString: "same",
- newString: "same",
- },
- ctx,
- ),
- ).rejects.toThrow("identical")
- },
- })
- })
- test("throws error when oldString not found in file", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "actual content", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: filepath,
- oldString: "not in file",
- newString: "replacement",
- },
- ctx,
- ),
- ).rejects.toThrow()
- },
- })
- })
- test("throws error when file was not read first (FileTime)", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "content", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: filepath,
- oldString: "content",
- newString: "modified",
- },
- ctx,
- ),
- ).rejects.toThrow("You must read file")
- },
- })
- })
- test("throws error when file has been modified since read", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "original content", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- // Read first
- FileTime.read(ctx.sessionID, filepath)
- // Wait a bit to ensure different timestamps
- await new Promise((resolve) => setTimeout(resolve, 100))
- // Simulate external modification
- await fs.writeFile(filepath, "modified externally", "utf-8")
- // Try to edit with the new content
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: filepath,
- oldString: "modified externally",
- newString: "edited",
- },
- ctx,
- ),
- ).rejects.toThrow("modified since it was last read")
- },
- })
- })
- test("replaces all occurrences with replaceAll option", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "foo bar foo baz foo", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- await edit.execute(
- {
- filePath: filepath,
- oldString: "foo",
- newString: "qux",
- replaceAll: true,
- },
- ctx,
- )
- const content = await fs.readFile(filepath, "utf-8")
- expect(content).toBe("qux bar qux baz qux")
- },
- })
- })
- test("emits change event for existing files", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "original", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const { Bus } = await import("../../src/bus")
- const { File } = await import("../../src/file")
- const { FileWatcher } = await import("../../src/file/watcher")
- const events: string[] = []
- const unsubEdited = Bus.subscribe(File.Event.Edited, () => events.push("edited"))
- const unsubUpdated = Bus.subscribe(FileWatcher.Event.Updated, () => events.push("updated"))
- const edit = await EditTool.init()
- await edit.execute(
- {
- filePath: filepath,
- oldString: "original",
- newString: "modified",
- },
- ctx,
- )
- expect(events).toContain("edited")
- expect(events).toContain("updated")
- unsubEdited()
- unsubUpdated()
- },
- })
- })
- })
- describe("edge cases", () => {
- test("handles multiline replacements", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "line1\nline2\nline3", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- await edit.execute(
- {
- filePath: filepath,
- oldString: "line2",
- newString: "new line 2\nextra line",
- },
- ctx,
- )
- const content = await fs.readFile(filepath, "utf-8")
- expect(content).toBe("line1\nnew line 2\nextra line\nline3")
- },
- })
- })
- test("handles CRLF line endings", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "line1\r\nold\r\nline3", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- await edit.execute(
- {
- filePath: filepath,
- oldString: "old",
- newString: "new",
- },
- ctx,
- )
- const content = await fs.readFile(filepath, "utf-8")
- expect(content).toBe("line1\r\nnew\r\nline3")
- },
- })
- })
- test("throws error when oldString equals newString", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "content", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: filepath,
- oldString: "",
- newString: "",
- },
- ctx,
- ),
- ).rejects.toThrow("identical")
- },
- })
- })
- test("throws error when path is directory", async () => {
- await using tmp = await tmpdir()
- const dirpath = path.join(tmp.path, "adir")
- await fs.mkdir(dirpath)
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, dirpath)
- const edit = await EditTool.init()
- await expect(
- edit.execute(
- {
- filePath: dirpath,
- oldString: "old",
- newString: "new",
- },
- ctx,
- ),
- ).rejects.toThrow("directory")
- },
- })
- })
- test("tracks file diff statistics", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "line1\nline2\nline3", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- const result = await edit.execute(
- {
- filePath: filepath,
- oldString: "line2",
- newString: "new line a\nnew line b",
- },
- ctx,
- )
- expect(result.metadata.filediff).toBeDefined()
- expect(result.metadata.filediff.file).toBe(filepath)
- expect(result.metadata.filediff.additions).toBeGreaterThan(0)
- },
- })
- })
- })
- describe("concurrent editing", () => {
- test("serializes concurrent edits to same file", async () => {
- await using tmp = await tmpdir()
- const filepath = path.join(tmp.path, "file.txt")
- await fs.writeFile(filepath, "0", "utf-8")
- await Instance.provide({
- directory: tmp.path,
- fn: async () => {
- FileTime.read(ctx.sessionID, filepath)
- const edit = await EditTool.init()
- // Two concurrent edits
- const promise1 = edit.execute(
- {
- filePath: filepath,
- oldString: "0",
- newString: "1",
- },
- ctx,
- )
- // Need to read again since FileTime tracks per-session
- FileTime.read(ctx.sessionID, filepath)
- const promise2 = edit.execute(
- {
- filePath: filepath,
- oldString: "0",
- newString: "2",
- },
- ctx,
- )
- // Both should complete without error (though one might fail due to content mismatch)
- const results = await Promise.allSettled([promise1, promise2])
- expect(results.some((r) => r.status === "fulfilled")).toBe(true)
- },
- })
- })
- })
- })
|