Home Explore Help
Sign In
AI
/
opencode-ide-plugin
mirror of https://github.com/paviko/opencode-ide-plugin.git
2
0
Fork 0
Files Issues 0 Wiki
Branch: ide-plugin
Branches Tags
opencode-ide-pl...
/
specs
/
17-unit-test-foundation.md

17-unit-test-foundation.md 3.2 KB
Permalink History Raw

Unit test foundation

Establish reliable unit coverage for core app logic.

Summary

packages/app is still e2e-first, but recent refactoring added a first wave of active source-unit tests (session helpers/scroll spy, prompt-input modules, file-tree, comments/layout/terminal/file context, and scoped-cache). This spec focuses on turning that momentum into a stable, explicit unit-test baseline in CI/local and unblocking the remaining skipped legacy suites.

Goals

  • Add a clear unit-test command for app source tests.
  • Unskip and stabilize existing skipped unit tests.
  • Add fast tests for high-value pure logic.
  • Keep unit suite independent of full e2e environment.

Non-goals

  • No replacement of e2e tests.
  • No broad product-code refactors unless required to make logic testable.
  • No flaky browser-automation tests added here.

Parallel ownership (important)

This workstream owns:

  • packages/app/package.json (test scripts only)
  • packages/app/happydom.ts (if harness tweaks are needed)
  • packages/app/src/**/*.test.ts
  • packages/app/src/**/*.test.tsx

This workstream should avoid editing product code files owned by other specs, unless a tiny testability export is strictly required.

Current state

  • Active unit coverage now exists across several src/**/*.test.* files (including context, pages/session, components/prompt-input, and utils).
  • Remaining skipped legacy suites:
    • src/context/layout-scroll.test.ts (test.skip)
    • src/addons/serialize.test.ts (describe.skip)
  • package.json scripts still focus on Playwright e2e and do not expose a dedicated test:unit entrypoint.

Proposed approach

  1. Add dedicated unit-test script(s), for example:
  • test:unit using Bun test + happydom preload where needed.
  1. Unskip and stabilize remaining skipped legacy tests:
  • make layout-scroll.test.ts deterministic
  • enable a reliable subset of serialize.test.ts (or split smoke vs heavy integration cases)
  1. Add/expand fast unit tests for high-value pure logic not yet covered:
  • keybind parsing/formatting/matching (context/command.tsx exports)
  • worktree state machine (utils/worktree.ts)

Phased steps

  1. Wire test:unit in package.json.
  2. Make existing skipped tests runnable and stable.
  3. Add at least 2 new unit test files for core pure logic.
  4. Ensure unit suite can run standalone without Playwright server setup.

Acceptance criteria

  • bun run test:unit exists and passes locally.
  • No full-file describe.skip/test.skip remains in packages/app/src/**/*.test.* (unless documented as intentionally quarantined with reason).
  • Unit suite includes meaningful assertions for keybind + worktree logic.
  • Runtime for unit suite remains fast (target: under 15 seconds locally, excluding first install).

Validation plan

  • Run: bun run test:unit.
  • Run: bun run typecheck.
  • Verify unit tests can execute without starting full app/backend servers.

Handoff notes

  • Keep tests implementation-focused, not duplicated business logic.
  • Avoid mocks where practical; prefer real small-scope code paths.
  • If integration-heavy serialize cases remain flaky, separate them into a clearly named non-default test target.