Browse Source

Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939

https://bugzilla.redhat.com/show_bug.cgi?id=613056
Resolves: bug 613056
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Fix description: Catch possible NULL pointer in write_replog_db().
Endi S. Dewata 15 years ago
parent
commit
0aea89bc6d
1 changed files with 6 additions and 1 deletions
  1. 6 1
      ldap/servers/plugins/retrocl/retrocl_po.c

+ 6 - 1
ldap/servers/plugins/retrocl/retrocl_po.c

@@ -179,13 +179,18 @@ write_replog_db(
     int			i;
     int			extensibleObject = 0;
 
+    if (!dn) {
+        slapi_log_error( SLAPI_LOG_PLUGIN, RETROCL_PLUGIN_NAME, "write_replog_db: NULL dn\n");
+	return;
+    }
+
     PR_Lock(retrocl_internal_lock);
     changenum = retrocl_assign_changenumber();
    
     PR_ASSERT( changenum > 0UL );
     slapi_log_error( SLAPI_LOG_PLUGIN, RETROCL_PLUGIN_NAME,
 	    "write_replog_db: write change record %lu for dn: \"%s\"\n", 
-	    changenum, ( dn == NULL ) ? "NULL" : dn );
+	    changenum, dn );
 
     /* Construct the dn of this change record */
     edn = slapi_ch_smprintf( "%s=%lu,%s", attr_changenumber, changenum, RETROCL_CHANGELOG_DN);