Browse Source

Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199

https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in import_grok_db_stats().
Endi S. Dewata 15 years ago
parent
commit
102b24925a
1 changed files with 6 additions and 1 deletions
  1. 6 1
      ldap/servers/slapd/back-ldbm/import.c

+ 6 - 1
ldap/servers/slapd/back-ldbm/import.c

@@ -521,6 +521,10 @@ static double import_grok_db_stats(ldbm_instance *inst)
 
     return_value = dblayer_memp_stat_instance(inst, &mpstat, &mpfstat);
 
+    if (!mpstat) {
+        goto out;
+    }
+
     if (0 == return_value) {
     unsigned long current_cache_hits = mpstat->st_cache_hit;
     unsigned long current_cache_misses = mpstat->st_cache_miss;
@@ -537,7 +541,9 @@ static double import_grok_db_stats(ldbm_instance *inst)
     }
     inst->inst_cache_misses = current_cache_misses;
     inst->inst_cache_hits = current_cache_hits;
+    }
 
+out:
     if (mpstat)
         slapi_ch_free((void **)&mpstat);
     if (mpfstat) {
@@ -549,7 +555,6 @@ static double import_grok_db_stats(ldbm_instance *inst)
 #endif
         slapi_ch_free((void **)&mpfstat);
     }
-    }
     return cache_hit_ratio;
 }