Browse Source

Bug 729378 - delete user subtree container in AD + modify password in DS == DS crash

https://bugzilla.redhat.com/show_bug.cgi?id=729378
Resolves: bug 729378
Bug Description: delete user subtree container in AD + modify password in DS == DS crash
Reviewed by: nkinder, nhosoi (Thanks!)
Branch: master
Fix Description: Check for NULL DN in send_password_modify - return error
if the DN is NULL.
Platforms tested: RHEL6 x86_64, Windows 2008 64-bit
Flag Day: no
Doc impact: no
Rich Megginson 14 years ago
parent
commit
1e357c1cb5
1 changed files with 6 additions and 2 deletions
  1. 6 2
      ldap/servers/plugins/replication/windows_protocol_util.c

+ 6 - 2
ldap/servers/plugins/replication/windows_protocol_util.c

@@ -770,9 +770,13 @@ static int
 send_password_modify(Slapi_DN *sdn, char *password, Private_Repl_Protocol *prp)
 {
 		ConnResult pw_return = 0;
-		int is_nt4 = windows_private_get_isnt4(prp->agmt);
 
-		if (is_nt4)
+		if (!sdn || !slapi_sdn_get_dn(sdn) || !password)
+		{
+			return CONN_OPERATION_FAILED;
+		}
+
+		if (windows_private_get_isnt4(prp->agmt))
 		{
 			/* NT4 just wants a plaintext password */
 			Slapi_Mods smods = {0};