[207427] parameterizing the hardcoded paths (Comment #15)

phase 1. parameterizing config, schema and ldif directory

ldap/admin/include/dsalib.h

@@ -318,6 +318,10 @@ extern DS_EXPORT_SYMBOL int ds_get_monitor(int frontend, char *port);
 extern DS_EXPORT_SYMBOL int ds_get_bemonitor(char *bemdn, char *port);
 extern DS_EXPORT_SYMBOL int ds_client_access(char *port, char *dn);
 extern DS_EXPORT_SYMBOL char **ds_get_config(int type);
+extern DS_EXPORT_SYMBOL char *ds_get_config_dir();
+extern DS_EXPORT_SYMBOL void ds_set_config_dir(char *config_dir);
+extern DS_EXPORT_SYMBOL char *ds_get_run_dir();
+extern DS_EXPORT_SYMBOL void ds_set_run_dir(char *run_dir);
 extern DS_EXPORT_SYMBOL char *ds_get_pwenc(char *passwd_hash, char *password);
 extern DS_EXPORT_SYMBOL int ds_check_config(int type);
 extern DS_EXPORT_SYMBOL int ds_check_pw(char *pwhash, char *pwclear);

ldap/admin/lib/dsalib_conf.c

@@ -51,7 +51,7 @@
 
 #include "nspr.h"
 
-#define CONF_FILE_NAME "config/dse.ldif"
+#define CONF_FILE_NAME "dse.ldif"
 #define CONF_SUFFIX "cn=config"
 
 DS_EXPORT_SYMBOL char *
@@ -69,7 +69,7 @@ DS_EXPORT_SYMBOL char **
 ds_get_config(int type)
 {
     char        conffile[PATH_MAX];
-    char        *root;
+    char        *configdir;
     FILE        *sf = NULL;
     char        **conf_list = NULL;
 
@@ -78,12 +78,12 @@ ds_get_config(int type)
         return(NULL);
     }
 
-    if ( (root = ds_get_install_root()) == NULL ) {
-        ds_send_error("Cannot find server root directory.", 0);
+    if ( (configdir = ds_get_config_dir()) == NULL ) {
+        ds_send_error("Cannot find configuration directory.", 0);
         return(NULL);
     }
 
-    PR_snprintf(conffile, PATH_MAX, "%s/%s", root, CONF_FILE_NAME);
+    PR_snprintf(conffile, PATH_MAX, "%s/%s", configdir, CONF_FILE_NAME);
 
     if ( !(sf = fopen(conffile, "r")) )  {
         ds_send_error("could not read config file.", 1);

ldap/admin/lib/dsalib_location.c

@@ -58,11 +58,11 @@ ds_get_server_root()
     if ( (root = getenv("NETSITE_ROOT")) == NULL )
         return(NULL);
 
-	/* WIN32: Needed to take care of embedded space, */
-	/* otherwise system() call fails */
-	root = ds_makeshort( root );
+    /* WIN32: Needed to take care of embedded space, */
+    /* otherwise system() call fails */
+    root = ds_makeshort( root );
 
-	return root;
+    return root;
 }
 
 /*
@@ -86,6 +86,52 @@ ds_get_install_root()
     return(install_root);
 }
 
+/*
+ * Returns the config file location of the server. Info is 
+ * returned in a static area. The caller must copy it 
+ * for reuse if needed.
+ */
+DS_EXPORT_SYMBOL char *
+ds_get_config_dir()
+{
+    return getenv("DS_CONFIG_DIR");
+}
+
+/*
+ * set config_dir to environment variable DS_CONFIG_DIR
+ * to retrieve the value using ds_get_config_dir later.
+ */
+DS_EXPORT_SYMBOL void
+ds_set_config_dir(char *config_dir)
+{
+    static char env[PATH_MAX];
+    PR_snprintf(env, sizeof(env), "DS_CONFIG_DIR=%s", config_dir);
+    putenv(env);
+}
+
+/*
+ * Returns the run dir of the server, where pid files are put.
+ * Info is returned in a static area. The caller must copy it 
+ * for reuse if needed.
+ */
+DS_EXPORT_SYMBOL char *
+ds_get_run_dir()
+{
+    return getenv("DS_RUN_DIR");
+}
+
+/*
+ * set run_dir to environment variable DS_RUN_DIR
+ * to retrieve the value using ds_get_run_dir later.
+ */
+DS_EXPORT_SYMBOL void
+ds_set_run_dir(char *run_dir)
+{
+    static char env[PATH_MAX];
+    PR_snprintf(env, sizeof(env), "DS_RUN_DIR=%s", run_dir);
+    putenv(env);
+}
+
 /*
  * Returns the install location of the server under the admserv
  * directory.
@@ -109,50 +155,50 @@ DS_EXPORT_SYMBOL char *
 ds_get_server_name()
 {
     if( getenv("SERVER_NAMES") )
-		return( getenv("SERVER_NAMES") );
-	else {
-		static char logfile[PATH_MAX];
-		char *buf;
-		char *out = logfile;
-		buf = getenv("SCRIPT_NAME");
-		if ( buf && (*buf == '/') )
-			buf++;
-		while ( *buf && (*buf != '/') ) {
-			*out++ = *buf++;
-		}
-		*out = 0;
-		return logfile;
-	}
+        return( getenv("SERVER_NAMES") );
+    else {
+        static char logfile[PATH_MAX];
+        char *buf;
+        char *out = logfile;
+        buf = getenv("SCRIPT_NAME");
+        if ( buf && (*buf == '/') )
+            buf++;
+        while ( *buf && (*buf != '/') ) {
+            *out++ = *buf++;
+        }
+        *out = 0;
+        return logfile;
+    }
 }
 
 DS_EXPORT_SYMBOL char *
 ds_get_logfile_name(int config_type)
 {
     char        *filename;
-    char	**ds_config = NULL;
+    char        **ds_config = NULL;
     static char logfile[PATH_MAX+1];
  
     if ( (ds_config = ds_get_config(DS_REAL_CONFIG)) == NULL ) {
-		/* For DS 4.0, no error output if file doesn't exist - that's
-		   a normal situation */
-		/* ds_send_error("ds_get_config(DS_REAL_CONFIG) == NULL", 0); */
+        /* For DS 4.0, no error output if file doesn't exist - that's
+           a normal situation */
+        /* ds_send_error("ds_get_config(DS_REAL_CONFIG) == NULL", 0); */
         return(NULL);
     }
     filename = ds_get_value(ds_config, ds_get_var_name(config_type), 0, 1);
 
     if ( filename == NULL ) {
-		/* For DS 4.0, no error output if file doesn't exist - that's
-		   a normal situation */
-		/* ds_send_error("ds_get_logfile_name: filename == NULL", 0); */
+        /* For DS 4.0, no error output if file doesn't exist - that's
+           a normal situation */
+        /* ds_send_error("ds_get_logfile_name: filename == NULL", 0); */
         return(NULL);
     }
     if ( ((int) strlen(filename)) >= PATH_MAX ) {
-		ds_send_error("ds_get_logfile_name: filename too long", 0);
-		free(filename);
+        ds_send_error("ds_get_logfile_name: filename too long", 0);
+        free(filename);
         return(NULL);
     }
     PL_strncpyz(logfile, filename, sizeof(logfile));
-	free(filename);
+    free(filename);
     return(logfile);
 }
 

ldap/admin/lib/dsalib_updown.c

@@ -80,44 +80,44 @@ static pid_t       server_pid;
 DS_EXPORT_SYMBOL int
 ds_get_updown_status()
 {
-    char	pid_file_name[BIG_LINE];
-    char        *root;
-    FILE        *pidfile;
-    int         ipid = -1;
-	int status = 0;
+    char pid_file_name[BIG_LINE];
+    char *rundir;
+    FILE *pidfile;
+    int  ipid = -1;
+    int  status = 0;
  
-    if ( (root = ds_get_install_root()) == NULL ) {
-		fprintf(stderr, "ds_get_updown_status: could not get install root\n");
+    if ( (rundir = ds_get_run_dir()) == NULL ) {
+      fprintf(stderr, "ds_get_updown_status: could not get install root\n");
         return(DS_SERVER_UNKNOWN);
-	}
-    PR_snprintf(pid_file_name, BIG_LINE, "%s/logs/pid", root);
+    }
+    PR_snprintf(pid_file_name, BIG_LINE, "%s/pid", rundir);
     pidfile = fopen(pid_file_name, "r");
     if ( pidfile == NULL ) {
-/*
-		fprintf(stderr,
-				"ds_get_updown_status: could not open pid file=%s errno=%d\n",
-				pid_file_name, errno);
+/* 
+      fprintf(stderr,
+            "ds_get_updown_status: could not open pid file=%s errno=%d\n",
+            pid_file_name, errno);
 */
         return(DS_SERVER_DOWN);
-	}
-	status = fscanf(pidfile, "%d\n", &ipid);
-	fclose(pidfile);
+   }
+   status = fscanf(pidfile, "%d\n", &ipid);
+   fclose(pidfile);
     if ( status == -1 ) {
-		fprintf(stderr,
-				"ds_get_updown_status: pidfile=%s server_pid=%d errno=%d\n",
-				pid_file_name, ipid, errno);
+      fprintf(stderr,
+            "ds_get_updown_status: pidfile=%s server_pid=%d errno=%d\n",
+            pid_file_name, ipid, errno);
         unlink(pid_file_name);     /* junk in file? */
         return(DS_SERVER_DOWN);
     }
     server_pid = (pid_t) ipid;
     if ( (status = kill(server_pid, 0)) != 0 && errno != EPERM ) {
-		/* we should get ESRCH if the server is down, anything else may be
-		   a real problem */
-		if (errno != ESRCH) {
-			fprintf(stderr,
-					"ds_get_updown_status: pidfile=%s server_pid=%d status=%d errno=%d\n",
-					pid_file_name, server_pid, status, errno);
-		}
+      /* we should get ESRCH if the server is down, anything else may be
+         a real problem */
+      if (errno != ESRCH) {
+         fprintf(stderr,
+               "ds_get_updown_status: pidfile=%s server_pid=%d status=%d errno=%d\n",
+               pid_file_name, server_pid, status, errno);
+      }
         unlink(pid_file_name);     /* pid does not exist! */
         return(DS_SERVER_DOWN);
     }
@@ -127,12 +127,12 @@ ds_get_updown_status()
 DS_EXPORT_SYMBOL int
 ds_get_updown_status()
 {
-    char	*ds_name = ds_get_server_name();
+    char   *ds_name = ds_get_server_name();
     HANDLE hServerDoneEvent = NULL;
 
     /* watchdog.c creates a global event of this same name */
     if((hServerDoneEvent = OpenEvent(EVENT_ALL_ACCESS, TRUE, ds_name)) != NULL) 
-	{
+   {
        CloseHandle(hServerDoneEvent);
        return(DS_SERVER_UP);
     }
@@ -154,17 +154,17 @@ DS_EXPORT_SYMBOL int
 ds_bring_up_server_install(int verbose, char *root, char *errorlog)
 {
 #if !defined( XP_WIN32 )
-    char	startup_line[BIG_LINE];
-    char	statfile[PATH_MAX];
-    char	*tmp_dir;
+    char   startup_line[BIG_LINE];
+    char   statfile[PATH_MAX];
+    char   *tmp_dir;
 #endif
     int     error = -1;
-    int		status = DS_SERVER_DOWN;
-    int		cur_size = 0;
-    FILE	*sf = NULL;
-    char	msgBuf[BIG_LINE] = {0};
-	int secondsToWaitForServer = 600;
-	char *serverStartupString = "slapd started.";
+    int      status = DS_SERVER_DOWN;
+    int      cur_size = 0;
+    FILE   *sf = NULL;
+    char   msgBuf[BIG_LINE] = {0};
+    int secondsToWaitForServer = 600;
+    char *serverStartupString = "slapd started.";
 
     status = ds_get_updown_status();
     if ( status == DS_SERVER_UP )
@@ -173,116 +173,116 @@ ds_bring_up_server_install(int verbose, char *root, char *errorlog)
         return(DS_SERVER_UNKNOWN);
  
     if (verbose) {
-    	ds_send_status("starting up server ...");
-		cur_size = ds_get_file_size(errorlog);
-	}
+        ds_send_status("starting up server ...");
+        cur_size = ds_get_file_size(errorlog);
+   }
 
 #if !defined( XP_WIN32 )
     tmp_dir = ds_get_tmp_dir();
     PR_snprintf(statfile, PATH_MAX, "%s%cstartup.%d", tmp_dir, FILE_SEP, (int)getpid());
 
     PR_snprintf(startup_line, BIG_LINE, "%s%c%s > %s 2>&1",
-			root, FILE_SEP, START_SCRIPT, statfile);
+         root, FILE_SEP, START_SCRIPT, statfile);
     alter_startup_line(startup_line);
     error = system(startup_line);
     if (error == -1)
-		error = DS_SERVER_DOWN; /* could not start server */
+      error = DS_SERVER_DOWN; /* could not start server */
     else
-		error = DS_SERVER_UP; /* started server */
+      error = DS_SERVER_UP; /* started server */
 #else
     error = StartServer();
 #endif
 
-	if (error != DS_SERVER_UP)
-	{
+   if (error != DS_SERVER_UP)
+   {
 #if !defined( XP_WIN32 )
-		FILE* fp = fopen(statfile, "r");
-		if (fp)
-		{
-			while(fgets(msgBuf, BIG_LINE, fp))
-				ds_send_status(msgBuf);
-			fclose(fp);
-		}
+      FILE* fp = fopen(statfile, "r");
+      if (fp)
+      {
+         while(fgets(msgBuf, BIG_LINE, fp))
+            ds_send_status(msgBuf);
+         fclose(fp);
+      }
 #endif
-		return DS_SERVER_COULD_NOT_START;
-	}
+      return DS_SERVER_COULD_NOT_START;
+   }
 
     if (verbose)
     {
-		/* 
-		 * Stop in N secs or whenever the startup message comes up.
-		 * Do whichever happens first.  msgBuf will contain the last
-		 * line read from the errorlog.
-		 */
-		ds_display_tail(errorlog, secondsToWaitForServer, cur_size,
-						serverStartupString, msgBuf);
+      /* 
+       * Stop in N secs or whenever the startup message comes up.
+       * Do whichever happens first.  msgBuf will contain the last
+       * line read from the errorlog.
+       */
+      ds_display_tail(errorlog, secondsToWaitForServer, cur_size,
+                  serverStartupString, msgBuf);
     }
     if ( error != DS_SERVER_UP ) {
-		int retval = DS_SERVER_UNKNOWN;
-		if (strstr(msgBuf, "semget"))
-			retval = DS_SERVER_MAX_SEMAPHORES;
-		else if (strstr(msgBuf, "Back-End Initialization Failed"))
-			retval = DS_SERVER_CORRUPTED_DB;
-		else if (strstr(msgBuf, "not initialized... exiting"))
-			retval = DS_SERVER_CORRUPTED_DB;
-		else if (strstr(msgBuf, "address is in use"))
-			retval = DS_SERVER_PORT_IN_USE;
+      int retval = DS_SERVER_UNKNOWN;
+      if (strstr(msgBuf, "semget"))
+         retval = DS_SERVER_MAX_SEMAPHORES;
+      else if (strstr(msgBuf, "Back-End Initialization Failed"))
+         retval = DS_SERVER_CORRUPTED_DB;
+      else if (strstr(msgBuf, "not initialized... exiting"))
+         retval = DS_SERVER_CORRUPTED_DB;
+      else if (strstr(msgBuf, "address is in use"))
+         retval = DS_SERVER_PORT_IN_USE;
 #if defined( XP_WIN32 )
-		/* on NT, if we run out of resources, there will not even be an error
-		   log
-		   */
-		else if (msgBuf[0] == 0) {
-			retval = DS_SERVER_NO_RESOURCES;
-		}
+      /* on NT, if we run out of resources, there will not even be an error
+         log
+         */
+      else if (msgBuf[0] == 0) {
+         retval = DS_SERVER_NO_RESOURCES;
+      }
 #endif
-		if (verbose)
-			ds_send_error("error in starting server.", 1);
-		return(retval);
+      if (verbose)
+         ds_send_error("error in starting server.", 1);
+      return(retval);
     }
     if (verbose) {
 #if !defined( XP_WIN32 )
-		if( !(sf = fopen(statfile, "r")) )  {
-			ds_send_error("could not read status file.", 1);
-			return(DS_SERVER_UNKNOWN);
-		}
-
-		while ( fgets(startup_line, BIG_LINE, sf) )
-			ds_send_error(startup_line, 0);
-		fclose(sf);
-		unlink(statfile);
+      if( !(sf = fopen(statfile, "r")) )  {
+         ds_send_error("could not read status file.", 1);
+         return(DS_SERVER_UNKNOWN);
+      }
+
+      while ( fgets(startup_line, BIG_LINE, sf) )
+         ds_send_error(startup_line, 0);
+      fclose(sf);
+      unlink(statfile);
 #endif
-		status = DS_SERVER_UNKNOWN;
-		if (strstr(msgBuf, "semget"))
-			status = DS_SERVER_MAX_SEMAPHORES;
-		else if (strstr(msgBuf, "Back-End Initialization Failed"))
-			status = DS_SERVER_CORRUPTED_DB;
-		else if (strstr(msgBuf, "not initialized... exiting"))
-			status = DS_SERVER_CORRUPTED_DB;
-		else if (strstr(msgBuf, "address is in use"))
-			status = DS_SERVER_PORT_IN_USE;
+      status = DS_SERVER_UNKNOWN;
+      if (strstr(msgBuf, "semget"))
+         status = DS_SERVER_MAX_SEMAPHORES;
+      else if (strstr(msgBuf, "Back-End Initialization Failed"))
+         status = DS_SERVER_CORRUPTED_DB;
+      else if (strstr(msgBuf, "not initialized... exiting"))
+         status = DS_SERVER_CORRUPTED_DB;
+      else if (strstr(msgBuf, "address is in use"))
+         status = DS_SERVER_PORT_IN_USE;
 #if defined( XP_WIN32 )
-		/* on NT, if we run out of resources, there will not even be an error
-		   log
-		   */
-		else if (msgBuf[0] == 0) {
-			status = DS_SERVER_NO_RESOURCES;
-		}
+      /* on NT, if we run out of resources, there will not even be an error
+         log
+         */
+      else if (msgBuf[0] == 0) {
+         status = DS_SERVER_NO_RESOURCES;
+      }
 #endif
     } else {
-		int tries;
-		for (tries = 0; tries < secondsToWaitForServer; tries++) {
-			if (ds_get_updown_status() == DS_SERVER_UP) break;
-			PR_Sleep(PR_SecondsToInterval(1));
-		}
-		if (verbose) {
-			char str[100];
-			PR_snprintf(str, sizeof(str), "Had to retry %d times", tries);
-			ds_send_status(str);
-		}
+      int tries;
+      for (tries = 0; tries < secondsToWaitForServer; tries++) {
+         if (ds_get_updown_status() == DS_SERVER_UP) break;
+         PR_Sleep(PR_SecondsToInterval(1));
+      }
+      if (verbose) {
+         char str[100];
+         PR_snprintf(str, sizeof(str), "Had to retry %d times", tries);
+         ds_send_status(str);
+      }
     }
 
     if ( (status == DS_SERVER_DOWN) || (status == DS_SERVER_UNKNOWN) )
-		status = ds_get_updown_status();
+      status = ds_get_updown_status();
 
     return(status);
 }
@@ -300,8 +300,8 @@ DS_EXPORT_SYMBOL int
 ds_bring_up_server(int verbose)
 {
     char        *root;
-    int		status;
-    char	*errorlog;
+    int      status;
+    char   *errorlog;
     status = ds_get_updown_status();
     if ( status == DS_SERVER_UP )
         return(DS_SERVER_ALREADY_UP);
@@ -310,66 +310,66 @@ ds_bring_up_server(int verbose)
  
     errorlog = ds_get_config_value(DS_ERRORLOG);
     if ( errorlog == NULL ) {
-		errorlog = ds_get_errors_name(); /* fallback */
+      errorlog = ds_get_errors_name(); /* fallback */
     }
-	return ds_bring_up_server_install(verbose, root, errorlog);
+   return ds_bring_up_server_install(verbose, root, errorlog);
 }
 
 DS_EXPORT_SYMBOL int
 ds_bring_down_server()
 {
     char        *root;
-    int		status;
-    int		cur_size;
+    int      status;
+    int      cur_size;
     char *errorlog;
  
-    status = ds_get_updown_status();	/* set server_pid too! */
+    status = ds_get_updown_status();   /* set server_pid too! */
     if ( status != DS_SERVER_UP ) {
-	ds_send_error("The server is not up.", 0);
+   ds_send_error("The server is not up.", 0);
         return(DS_SERVER_ALREADY_DOWN);
     }
     if ( (root = ds_get_install_root()) == NULL ) {
-	ds_send_error("Could not get the server root directory.", 0);
+   ds_send_error("Could not get the server root directory.", 0);
         return(DS_SERVER_UNKNOWN);
     }
  
     ds_send_status("shutting down server ...");
     if (!(errorlog = ds_get_errors_name())) {
-	ds_send_error("Could not get the error log filename.", 0);
-	return DS_SERVER_UNKNOWN;
+   ds_send_error("Could not get the error log filename.", 0);
+   return DS_SERVER_UNKNOWN;
     }
 
     cur_size = ds_get_file_size(errorlog);
 #if !defined( XP_WIN32 )
     if ( (kill(server_pid, SIGTERM)) != 0)  {
-	if (errno == EPERM) {
-	    ds_send_error("Not permitted to kill server.", 0);
-	    fprintf (stdout, "[%s]: kill (%li, SIGTERM) failed with errno = EPERM.<br>\n",
-		     ds_get_server_name(), (long)server_pid);
-	} else {
-	    ds_send_error("error in killing server.", 1);
-	}
+   if (errno == EPERM) {
+       ds_send_error("Not permitted to kill server.", 0);
+       fprintf (stdout, "[%s]: kill (%li, SIGTERM) failed with errno = EPERM.<br>\n",
+           ds_get_server_name(), (long)server_pid);
+   } else {
+       ds_send_error("error in killing server.", 1);
+   }
         return(DS_SERVER_UNKNOWN);
     }
 #else
     if( StopServer() == DS_SERVER_DOWN )  
-	{
-		ds_send_status("shutdown: server shut down");
-	}
-	else
-	{
+   {
+      ds_send_status("shutdown: server shut down");
+   }
+   else
+   {
         ds_send_error("error in killing server.", 1);
         return(DS_SERVER_UNKNOWN);
-	}
+   }
 #endif
     /* 
      * Wait up to SERVER_STOP_TIMEOUT seconds for the stopped message to
-	 * appear in the error log.
+    * appear in the error log.
      */
     ds_display_tail(errorlog, SERVER_STOP_TIMEOUT, cur_size, "slapd stopped.", NULL);
     /* in some cases, the server will tell us it's down when it's really not,
        so give the OS a chance to remove it from the process table */
-	PR_Sleep(PR_SecondsToInterval(1));
+   PR_Sleep(PR_SecondsToInterval(1));
     return(ds_get_updown_status());
 }
 
@@ -379,32 +379,32 @@ static BOOLEAN
 IsService()
 {
 #if 0
- 	CHAR ServerKey[512], *ValueString;
-	HKEY hServerKey;
-	DWORD dwType, ValueLength, Result;
-
-	PR_snprintf(ServerKey,sizeof(ServerKey), "%s\\%s", COMPANY_KEY, PRODUCT_KEY);
-
-	Result = RegOpenKey(HKEY_LOCAL_MACHINE, ServerKey, &hServerKey);
-	if (Result != ERROR_SUCCESS) {
-		return TRUE;
-	}
-	ValueLength = 512;
-	ValueString = (PCHAR)malloc(ValueLength);
-
-	Result = RegQueryValueEx(hServerKey, IS_SERVICE_KEY, NULL,
-		&dwType, ValueString, &ValueLength);
-	if (Result != ERROR_SUCCESS) {
-		return TRUE;
-	}
-	if (strcmp(ValueString, "yes")) {
-		return FALSE;
-	}
-	else {
-		return TRUE;
-	}
+    CHAR ServerKey[512], *ValueString;
+   HKEY hServerKey;
+   DWORD dwType, ValueLength, Result;
+
+   PR_snprintf(ServerKey,sizeof(ServerKey), "%s\\%s", COMPANY_KEY, PRODUCT_KEY);
+
+   Result = RegOpenKey(HKEY_LOCAL_MACHINE, ServerKey, &hServerKey);
+   if (Result != ERROR_SUCCESS) {
+      return TRUE;
+   }
+   ValueLength = 512;
+   ValueString = (PCHAR)malloc(ValueLength);
+
+   Result = RegQueryValueEx(hServerKey, IS_SERVICE_KEY, NULL,
+      &dwType, ValueString, &ValueLength);
+   if (Result != ERROR_SUCCESS) {
+      return TRUE;
+   }
+   if (strcmp(ValueString, "yes")) {
+      return FALSE;
+   }
+   else {
+      return TRUE;
+   }
 #else
-	return TRUE;
+   return TRUE;
 #endif
 }
 
@@ -412,29 +412,29 @@ IsService()
 NSAPI_PUBLIC BOOLEAN
 IsAdminService()
 {
- 	CHAR AdminKey[512], *ValueString;
-	HKEY hAdminKey;
-	DWORD dwType, ValueLength, Result;
-
-	PR_snprintf(AdminKey,sizeof(AdminKey), "%s\\%s", COMPANY_KEY, ADMIN_REGISTRY_ROOT_KEY);
-
-	Result = RegOpenKey(HKEY_LOCAL_MACHINE, AdminKey, &hAdminKey);
-	if (Result != ERROR_SUCCESS) {
-		return TRUE;
-	}
-	ValueLength = 512;
-	ValueString = (PCHAR)malloc(ValueLength);
-
-	Result = RegQueryValueEx(hAdminKey, IS_SERVICE_KEY, NULL,
-		&dwType, ValueString, &ValueLength);
-	if (Result != ERROR_SUCCESS) {
-		return TRUE;
-	}
-	if (strcmp(ValueString, "yes")) {
-		return FALSE;
-	} else {
-		return TRUE;
-	}
+    CHAR AdminKey[512], *ValueString;
+   HKEY hAdminKey;
+   DWORD dwType, ValueLength, Result;
+
+   PR_snprintf(AdminKey,sizeof(AdminKey), "%s\\%s", COMPANY_KEY, ADMIN_REGISTRY_ROOT_KEY);
+
+   Result = RegOpenKey(HKEY_LOCAL_MACHINE, AdminKey, &hAdminKey);
+   if (Result != ERROR_SUCCESS) {
+      return TRUE;
+   }
+   ValueLength = 512;
+   ValueString = (PCHAR)malloc(ValueLength);
+
+   Result = RegQueryValueEx(hAdminKey, IS_SERVICE_KEY, NULL,
+      &dwType, ValueString, &ValueLength);
+   if (Result != ERROR_SUCCESS) {
+      return TRUE;
+   }
+   if (strcmp(ValueString, "yes")) {
+      return FALSE;
+   } else {
+      return TRUE;
+   }
 }
 #endif
 
@@ -453,7 +453,7 @@ StartServer()
                 NULL,                   // database (NULL == default)
                 SC_MANAGER_ALL_ACCESS   // access required
                 ))) {
-			PR_snprintf(ErrorString, sizeof(ErrorString),
+         PR_snprintf(ErrorString, sizeof(ErrorString),
                 "Error: Could not open the ServiceControlManager:%d "
                 "Please restart the server %s from the Services Program Item "
                 "in the Control Panel", ds_get_server_name(), GetLastError());
@@ -519,7 +519,7 @@ StopServer()
                 "Error: Could not open the ServiceControlManager:%d "
                 "Please restart the server %s from the Services Program Item "
                 "in the Control Panel", ds_get_server_name(), GetLastError());
-			ds_send_error(ErrorString, 0);
+         ds_send_error(ErrorString, 0);
             return(DS_SERVER_UNKNOWN);  
         }
         return(StopNetscapeService());
@@ -534,9 +534,9 @@ StartNetscapeProgram()
     char line[BIG_LINE], cmd[BIG_LINE];
     char *tmp = ds_get_install_root();
 
-	CHAR ErrorString[512];
-	STARTUPINFO siStartInfo;
-	PROCESS_INFORMATION piProcInfo;
+   CHAR ErrorString[512];
+   STARTUPINFO siStartInfo;
+   PROCESS_INFORMATION piProcInfo;
     FILE *CmdFile;
 
     ZeroMemory(line, sizeof(line));
@@ -545,7 +545,7 @@ StartNetscapeProgram()
     
     CmdFile = fopen(line, "r");
     if (!CmdFile) 
-	{
+   {
         PR_snprintf(ErrorString, sizeof(ErrorString), "Error:Tried to start server %s "
             ": Could not open the startup script %s :Error %d. Please "
             "run startsrv.bat from the server's root directory.",
@@ -556,7 +556,7 @@ StartNetscapeProgram()
 
     ZeroMemory(cmd, sizeof(cmd));
     if (!fread(cmd, 1, BIG_LINE, CmdFile)) 
-	{
+   {
         PR_snprintf(ErrorString, sizeof(ErrorString), "Error:Tried to start server %s "
             ": Could not read the startup script %s :Error %d. Please "
             "run startsrv.bat from the server's root directory.",
@@ -565,25 +565,25 @@ StartNetscapeProgram()
         return(DS_SERVER_DOWN);
     }
     
-	ZeroMemory(&siStartInfo, sizeof(STARTUPINFO));
-	siStartInfo.cb = sizeof(STARTUPINFO);
-	siStartInfo.lpReserved = siStartInfo.lpReserved2 = NULL;
-	siStartInfo.cbReserved2 = 0;
-	siStartInfo.lpDesktop = NULL;
-
-	if (!CreateProcess(NULL, cmd, NULL, NULL, FALSE,
-		0, NULL, NULL, &siStartInfo, &piProcInfo)) 
-	{
+   ZeroMemory(&siStartInfo, sizeof(STARTUPINFO));
+   siStartInfo.cb = sizeof(STARTUPINFO);
+   siStartInfo.lpReserved = siStartInfo.lpReserved2 = NULL;
+   siStartInfo.cbReserved2 = 0;
+   siStartInfo.lpDesktop = NULL;
+
+   if (!CreateProcess(NULL, cmd, NULL, NULL, FALSE,
+      0, NULL, NULL, &siStartInfo, &piProcInfo)) 
+   {
         PR_snprintf(ErrorString, sizeof(ErrorString), "Error:Tried to start server %s "
             ": Could not start up the startup script %s :Error %d. Please "
             "run startsrv.bat from the server's root directory.",
             ds_get_server_name(), line, GetLastError());
         ds_send_error(ErrorString, 0);
         return(DS_SERVER_DOWN);
-	} 
+   } 
 
-	CloseHandle(piProcInfo.hProcess);
-	CloseHandle(piProcInfo.hThread);
+   CloseHandle(piProcInfo.hProcess);
+   CloseHandle(piProcInfo.hThread);
     return(DS_SERVER_UP);
 }
 
@@ -596,7 +596,7 @@ StopNetscapeProgram()
 
     hEvent = CreateEvent(NULL, TRUE, FALSE, servid);  
     if(!SetEvent(hEvent)) 
-	{
+   {
         PR_snprintf(ErrorString, sizeof(ErrorString), "Tried to stop existing server %s"
             ": Could not signal it to stop :Error %d",
             servid, GetLastError());
@@ -619,7 +619,7 @@ StopNetscapeService()
     schService = OpenService(schSCManager, serviceName, SERVICE_ALL_ACCESS);
  
     if (schService == NULL) 
-	{
+   {
         PR_snprintf(ErrorString, sizeof(ErrorString), "Tried to open service"
             " %s: Error %d (%s). Please"
             " stop the server from the Services Item in the Control Panel",
@@ -644,7 +644,7 @@ StopNetscapeService()
         return(DS_SERVER_DOWN);
     } 
     else if (Error != ERROR_SERVICE_NOT_ACTIVE) 
-	{
+   {
         PR_snprintf(ErrorString, sizeof(ErrorString), "Tried to stop service"
             " %s: Error %d (%s)."
             " Please stop the server from the Services Item in the"
@@ -668,7 +668,7 @@ StartNetscapeService()
                     serviceName,                // name of service
                     SERVICE_ALL_ACCESS); 
     if (schService == NULL) 
-	{
+   {
         CloseServiceHandle(schService);
         PR_snprintf(ErrorString, sizeof(ErrorString),"Tried to start"
             " the service %s: Error %d. Please"
@@ -679,7 +679,7 @@ StartNetscapeService()
     }
  
     if (!StartService(schService, 0, NULL)) 
-	{
+   {
         CloseServiceHandle(schService);
         PR_snprintf(ErrorString, sizeof(ErrorString), "StartService:Could not start "
             "the Directory service %s: Error %d. Please restart the server "
@@ -703,7 +703,7 @@ WaitForServertoStop()
 
 RETRY:
 
-	newServiceName = PR_smprintf("NS_%s", serviceName);
+   newServiceName = PR_smprintf("NS_%s", serviceName);
 
     hServDoneSemaphore = CreateSemaphore(
         NULL,   // security attributes    

ldap/admin/src/cfg_sspt.c

@@ -52,7 +52,7 @@
 
 /*#define CGI_DEBUG 1*/
 
-#define TEST_CONFIG /* for testing cn=config40 dummy entry instead of real one */
+#undef TEST_CONFIG /* for testing cn=config40 dummy entry instead of real one */
 
 char* const NULLSTR = 0;
 
@@ -1054,6 +1054,7 @@ create_NetscapeRoot(LDAP* ld, const char *DN)
 	return ret;
 }
 
+#ifdef TEST_CONFIG
 static int
 create_configEntry(LDAP* ld)
 {
@@ -1121,6 +1122,7 @@ create_configEntry(LDAP* ld)
 
 	return ret;
 }
+#endif
 
 int
 create_group(LDAP* ld, char* base, char* group)
@@ -1388,6 +1390,7 @@ write_ldap_info(SLAPD_CONFIG* slapd, char* base, char* admnm)
 	return ret;
 }
 
+#ifdef TEST_CONFIG
 int
 config_configEntry(LDAP* connection, QUERY_VARS* query)
 {
@@ -1396,6 +1399,7 @@ config_configEntry(LDAP* connection, QUERY_VARS* query)
 	int ret = add_aci_v (connection, value_config40DN, ACI_self_allow, NULLSTR);
 	return ret;
 }
+#endif
 
 int
 config_suitespot(SLAPD_CONFIG* slapd, QUERY_VARS* query)
@@ -1629,11 +1633,13 @@ config_suitespot(SLAPD_CONFIG* slapd, QUERY_VARS* query)
 		write_ldap_info(slapd, query->suffix, query->ssAdmID);
 	}
 
+#ifdef TEST_CONFIG
 	if (!status && query->testconfig)
 		status = create_configEntry(connection);
 
 	if (!status && query->testconfig)
 		status = config_configEntry(connection, query);
+#endif
 
 	if (connection)
 		ldap_unbind (connection);

ldap/admin/src/create_instance.h

@@ -49,31 +49,46 @@
 extern "C" {            /* Assume C declarations for C++ */
 #endif  /* __cplusplus */
 
+#define BRAND_DS        "fedora-ds"
+#define DS_CONFIG_DIR   "DS_CONFIG_DIR"
+#define DS_CONFIG_FILE  "dse.ldif"
 
 #ifdef XP_UNIX
-#define PRODUCT_NAME "slapd"
-
-#define PRODUCT_BIN "ns-slapd"
-
+#define PRODUCT_NAME    "slapd"
+#define PRODUCT_BIN     "ns-slapd"
 #endif
 
+#define LOCALSTATEDIR   "/var"
+#define SYSCONFDIR      "/etc"
+#define BINDIR          "/bin"
+#define DATADIR         "/share"
+#define DOCDIR          "/usr/doc"
+
 typedef struct {
-    char *sroot;
+    char *sroot; /* _libdir */
+    char *localstatedir;
+    char *sysconfdir;
+    char *bindir;
+    char *datadir;
+    char *docdir;
+
+    char *brand_ds;
+    char *lang;
 
     char *servname;
     char *bindaddr;
     char *servport;
-	char *suitespot3x_uid;
-	char *cfg_sspt;
-	char *cfg_sspt_uid;
-	char *cfg_sspt_uidpw;
+    char *suitespot3x_uid;
+    char *cfg_sspt;
+    char *cfg_sspt_uid;
+    char *cfg_sspt_uidpw;
     char *secserv;
     char *secservport;
     char *ntsynch;
     char *ntsynchssl;
     char *ntsynchport;
     char *rootdn;
-    char *rootpw;	
+    char *rootpw;    
     char *roothashedpw;
     char *replicationdn;
     char *replicationpw;
@@ -84,10 +99,10 @@ typedef struct {
     char *changelogdir;
     char *changelogsuffix;
     char *suffix;
-	char *loglevel;
-	char *netscaperoot;
-	char *samplesuffix;
-	char *testconfig;
+    char *loglevel;
+    char *netscaperoot;
+    char *samplesuffix;
+    char *testconfig;
     char *servid;
 #ifdef XP_UNIX
     char *servuser;
@@ -97,16 +112,26 @@ typedef struct {
     char *maxthreads;
     int  upgradingServer;
 
-	char * start_server;
-
-	char * admin_domain;
-	char * config_ldap_url;
-	char * user_ldap_url;
-	int use_existing_user_ds;
-	int use_existing_config_ds;
-	char * disable_schema_checking;
-	char * install_ldif_file;
-        char *adminport;
+    char * start_server;
+
+    char * admin_domain;
+    char * config_ldap_url;
+    char * user_ldap_url;
+    int use_existing_user_ds;
+    int use_existing_config_ds;
+    char * disable_schema_checking;
+    char * install_ldif_file;
+    char *adminport;
+    char *inst_dir;
+    char *config_dir;
+    char *schema_dir;
+    char *lock_dir;
+    char *log_dir;
+    char *run_dir;
+    char *db_dir;
+    char *bak_dir;
+    char *ldif_dir;
+    char *prefix;
 } server_config_s;
 
 

ldap/admin/src/ds_newinst.c

@@ -145,6 +145,7 @@ int main(int argc, char *argv[], char *envp[])
 
 #if defined( hpux )
     _exit(status);
+#else
+    exit(status);
 #endif
-    return status;
 }

ldap/admin/src/ds_newinst.pl

@@ -213,6 +213,10 @@ if ($table{General}->{UserDirectoryLdapURL}) {
 	$cgiargs{user_ldap_url} = $cgiargs{ldap_url};
 }
 
+if ($table{General}->{prefix}) {
+	$cgiargs{prefix} = $table{General}->{prefix};
+}
+
 # populate the DS with this file - the suffix in this file must
 # be the suffix specified in the suffix argument above
 # the filename should use the full absolute path

ldap/admin/src/makemccvlvindexes

@@ -235,9 +235,9 @@ if($really_do_it eq "1" && $#vlvnames > 0)
     print "\n";
     print "$#vlvnames VLV indices have been declared.  Execute the following commands to build the index files.\n";
     print "\n";
-    print "<instance-dir>\\stop\n";
-    print "slapd db2index -f <instance-dir>\\config\\slapd.conf -V @vlvnames\n";
-    print "<instance-dir>\\start\n";
+    print "<config-dir>\\stop\n";
+    print "slapd db2index -f <config-dir> -V @vlvnames\n";
+    print "<config-dir>\\start\n";
 }
 
 

ldap/cm/Makefile

@@ -310,7 +310,7 @@ releaseDirectory:
 	$(INSTALL) -m 644 $(BUILD_DRIVE)$(BUILD_ROOT)/ldap/schema/*.ldif $(RELDIR)/bin/slapd/install/schema
 	$(INSTALL) -m 644 $(BUILD_DRIVE)$(BUILD_ROOT)/ldap/schema/slapd-collations.conf $(RELDIR)/bin/slapd/install/config
 
-	$(INSTALL) -m 644 $(BUILD_DRIVE)$(BUILD_ROOT)/lib/ldaputil/certmap.conf $(RELDIR)/shared/config
+	$(INSTALL) -m 644 $(BUILD_DRIVE)$(BUILD_ROOT)/lib/ldaputil/certmap.conf $(RELDIR)/bin/slapd/install/config
 
 # the httpd library
 ifneq ($(ARCH), WINNT)

ldap/servers/slapd/auth.c

@@ -272,41 +272,27 @@ void
 client_auth_init ()
 {
     char *instancedir;
-    int len = 0;
-    char *val = NULL;
-    char* filename;
-    char netsite_root[MAXPATHLEN];
     int err;
     if (client_auth_config_file == NULL) {
-	client_auth_config_file = "shared/config/certmap.conf";
-    }
-
-    /* calculate the server_root from instance dir */
-    instancedir = config_get_instancedir();
-    /* make sure path does not end in the path separator character */
-    len = strlen(instancedir);
-    if (instancedir[len-1] == '/' || instancedir[len-1] == '\\') {
-	instancedir[len-1] = '\0';
-    }
-
-    /* get the server root from the path */
-    val = strrchr(instancedir, '/');
-    if (!val) {
-	val = strrchr(instancedir, '\\');
+	char *confdir = config_get_configdir();
+	if (NULL == confdir) {
+	    LDAPDebug (LDAP_DEBUG_ANY,
+		"client_auth_init: failed to get configdir\n",
+		0, 0, 0);
+	    return;
+	}
+	client_auth_config_file = PR_smprintf("%s/certmap.conf", confdir);
+	if (NULL == client_auth_config_file) {
+	    LDAPDebug (LDAP_DEBUG_ANY,
+		"client_auth_init: failed to duplicate \"%s/certmap\"\n",
+		confdir, 0, 0);
+	    return;
+	}
     }
-    if (val) {
-    	val++;
-    	*val = '\0';
-    } 
-
-    PL_strncpyz(netsite_root, instancedir, MAXPATHLEN);
-    slapi_ch_free_string(&instancedir);
-    filename = PR_smprintf("%s%s", netsite_root, client_auth_config_file);
-
-    err = ldaputil_init (filename, "", netsite_root, "slapd", NULL);
+    err = ldaputil_init (client_auth_config_file, "", NULL, "slapd", NULL);
     if (err != LDAPU_SUCCESS) {
 	LDAPDebug (LDAP_DEBUG_TRACE, "ldaputil_init(%s,...) %i\n",
-		filename, err, 0);
+		client_auth_config_file, err, 0);
     } else {
 	LDAPUVTable_t vtable = {
 	    NULL /* ssl_init */,
@@ -329,9 +315,6 @@ client_auth_init ()
 	    slapu_value_free_len};
 	ldapu_VTable_set (&vtable);
     }
-    PR_smprintf_free (filename);
-    /* why do we define these strings if we never use them? */
-    if (ldapu_strings != NULL);
 
     /* Generate a component id for cert-based authentication */
     generate_id();

ldap/servers/slapd/config.c

@@ -160,30 +160,40 @@ slapd_bootstrap_config(const char *configdir)
 	char *buf = 0;
 	char *lastp = 0;
 	char *entrystr = 0;
+	char *instancedir = NULL;
 
+	if (NULL == configdir) {
+		slapi_log_error(SLAPI_LOG_FATAL,
+						"startup", "Passed null config directory\n");
+		return rc; /* Fail */
+	}
 	PR_snprintf(configfile, sizeof(configfile), "%s/%s", configdir,
-			CONFIG_FILENAME);
+				CONFIG_FILENAME);
 	if ( (rc = PR_GetFileInfo( configfile, &prfinfo )) != PR_SUCCESS )
 	{
 		/* the "real" file does not exist; see if there is a tmpfile */
 		char tmpfile[MAXPATHLEN+1];
+		slapi_log_error(SLAPI_LOG_FATAL, "config",
+					"The configuration file %s does not exist\n", configfile);
 		PR_snprintf(tmpfile, sizeof(tmpfile), "%s/%s.tmp", configdir,
-				CONFIG_FILENAME);
+					CONFIG_FILENAME);
 		if ( PR_GetFileInfo( tmpfile, &prfinfo ) == PR_SUCCESS ) {
 			rc = PR_Rename(tmpfile, configfile);
 			if (rc == PR_SUCCESS) {
 				slapi_log_error(SLAPI_LOG_FATAL, "config",
 								"The configuration file %s was restored from backup %s\n",
 								configfile, tmpfile);
-				rc = 1;
 			} else {
 				slapi_log_error(SLAPI_LOG_FATAL, "config",
 								"The configuration file %s was not restored from backup %s, error %d\n",
 								configfile, tmpfile, rc);
-				rc = 0;
+				return rc; /* Fail */
 			}
 		} else {
-			rc = 0; /* fail */
+			slapi_log_error(SLAPI_LOG_FATAL, "config",
+				"The backup configuration file %s does not exist, either.\n",
+				tmpfile);
+			return rc; /* Fail */
 		}
 	}
 	if ( (rc = PR_GetFileInfo( configfile, &prfinfo )) != PR_SUCCESS )
@@ -191,7 +201,7 @@ slapd_bootstrap_config(const char *configdir)
 		PRErrorCode prerr = PR_GetError();
 		slapi_log_error(SLAPI_LOG_FATAL, "config", "The given config file %s could not be accessed, " SLAPI_COMPONENT_NAME_NSPR " error %d (%s)\n",
 						configfile, prerr, slapd_pr_strerror(prerr));
-		rc = 0; /* Fail */
+		return rc;
 	}
 	else if (( prfd = PR_Open( configfile, PR_RDONLY,
 							   SLAPD_DEFAULT_FILE_MODE )) == NULL )
@@ -199,7 +209,7 @@ slapd_bootstrap_config(const char *configdir)
 		PRErrorCode prerr = PR_GetError();
 		slapi_log_error(SLAPI_LOG_FATAL, "config", "The given config file %s could not be opened for reading, " SLAPI_COMPONENT_NAME_NSPR " error %d (%s)\n",
 						configfile, prerr, slapd_pr_strerror(prerr));
-		rc = 0; /* Fail */
+		return rc; /* Fail */
 	}
 	else
 	{
@@ -218,7 +228,7 @@ slapd_bootstrap_config(const char *configdir)
 
 		if(!done)
 		{
-			char errorlog[MAXPATHLEN+1];
+			char workpath[MAXPATHLEN+1];
 			char loglevel[BUFSIZ];
 			char maxdescriptors[BUFSIZ];
 			char val[BUFSIZ];
@@ -227,7 +237,7 @@ slapd_bootstrap_config(const char *configdir)
 			char schemacheck[BUFSIZ];
 			Slapi_DN plug_dn;
 
-			errorlog[0] = loglevel[0] = maxdescriptors[0] = '\0';
+			workpath[0] = loglevel[0] = maxdescriptors[0] = '\0';
 			val[0] = logenabled[0] = schemacheck[0] = '\0';
 			_localuser[0] = '\0';
 
@@ -252,6 +262,28 @@ slapd_bootstrap_config(const char *configdir)
 					continue;
 				}
 
+				/* if instancedir is not set, set it first */
+				{
+					instancedir = config_get_instancedir();
+					if (NULL == instancedir) {
+						workpath[0] = '\0';
+						if (entry_has_attr_and_value(e,
+												CONFIG_INSTANCEDIR_ATTRIBUTE,
+												workpath, sizeof(workpath))) {
+							if (config_set_instancedir(
+											CONFIG_INSTANCEDIR_ATTRIBUTE,
+											workpath, errorbuf, CONFIG_APPLY)
+								!= LDAP_SUCCESS) {
+								LDAPDebug(LDAP_DEBUG_ANY, "%s: %s: %s\n",
+									configfile, CONFIG_INSTANCEDIR_ATTRIBUTE,
+									errorbuf);
+							}
+						}
+					} else {
+						slapi_ch_free((void **)&instancedir);
+					}
+				}
+
 				/* increase file descriptors */
 #if !defined(_WIN32) && !defined(AIX)
 				if (!maxdescriptors[0] &&
@@ -301,12 +333,13 @@ slapd_bootstrap_config(const char *configdir)
 #endif
 				
 				/* set the log file name */
-				if (!errorlog[0] &&
+				workpath[0] = '\0';
+				if (!workpath[0] &&
 					entry_has_attr_and_value(e, CONFIG_ERRORLOG_ATTRIBUTE,
-								errorlog, sizeof(errorlog)))
+								workpath, sizeof(workpath)))
 				{
 					if (config_set_errorlog(CONFIG_ERRORLOG_ATTRIBUTE,
-						errorlog, errorbuf, CONFIG_APPLY) != LDAP_SUCCESS)
+						workpath, errorbuf, CONFIG_APPLY) != LDAP_SUCCESS)
 					{
 						LDAPDebug(LDAP_DEBUG_ANY, "%s: %s: %s. \n", configfile,
 								  CONFIG_ERRORLOG_ATTRIBUTE, errorbuf);
@@ -485,6 +518,18 @@ slapd_bootstrap_config(const char *configdir)
 					slapi_entry_free(e);
 			}
 
+			/* 
+			 * check if the instance dir is set.
+			 */
+			if ( NULL == ( instancedir = config_get_instancedir() )) {
+				slapi_log_error(SLAPI_LOG_FATAL, "startup",
+								"Instance directory is not specifiled in the file %s. It is mandatory.\n",
+								configfile);
+				exit (1);
+			} else {
+				slapi_ch_free((void **)&instancedir);
+			}
+			
 			/* kexcoff: initialize rootpwstoragescheme and pw_storagescheme
 			 *			if not explicilty set in the config file
 			 */

ldap/servers/slapd/dse.c

@@ -38,10 +38,9 @@
 /*
  * dse.c - DSE (DSA-Specific Entry) persistent storage.
  *
- * The DSE store is an LDIF file contained in the file
- * INSTANCEDIR/config/XXX.ldif, where INSTANCEDIR is
- * the directory of the server instance, and XXX is
- * dfined by the caller of dse_new.
+ * The DSE store is an LDIF file contained in the file dse.ldif.
+ * The file is located in the directory specified with '-D' 
+ * when staring the server.
  *
  * In core, the DSEs are stored in an AVL tree, keyed on
  * DN.  Whenever a modification is made to a DSE, the
@@ -354,14 +353,15 @@ struct dse *
 dse_new( char *filename, char *tmpfilename, char *backfilename, char *startokfilename, const char *configdir)
 {
     struct dse *pdse= NULL;
-    const char *config_sub_dir = "config";
-    char *id = 	config_get_instancedir();
     char *realconfigdir = NULL;
 
-    if (configdir!=NULL) {
-		realconfigdir = slapi_ch_strdup(configdir);
-    } else if (id!=NULL) {
-		realconfigdir = slapi_ch_smprintf("%s/%s", id, config_sub_dir);
+    if (configdir!=NULL)
+    {
+        realconfigdir = slapi_ch_strdup(configdir);
+    }
+    else
+    {
+        realconfigdir = config_get_configdir();
     }
     if(realconfigdir!=NULL)
     {
@@ -412,7 +412,6 @@ dse_new( char *filename, char *tmpfilename, char *backfilename, char *startokfil
         }
 		slapi_ch_free( (void **) &realconfigdir );
     }
-    slapi_ch_free( (void **) &id );
     return pdse;
 }
 

ldap/servers/slapd/fedse.c

@@ -38,9 +38,9 @@
 /*
  * fedse.c - Front End DSE (DSA-Specific Entry) persistent storage.
  *
- * The DSE store is an LDIF file contained in the file
- * INSTANCEDIR/config/dse.ldif, where INSTANCEDIR is
- * the directory of the server instance.
+ * The DSE store is an LDIF file contained in the file dse.ldif.
+ * The file is located in the directory specified with '-D' 
+ * when staring the server.
  *
  * In core, the DSEs are stored in an AVL tree, keyed on
  * DN.  Whenever a modification is made to a DSE, the
@@ -1866,48 +1866,54 @@ setup_internal_backends(char *configdir)
 
 int fedse_create_startOK(char *filename,  char *startokfilename, const char *configdir)
 {
-    const char *config_sub_dir = "config";
-    char *id =  config_get_instancedir();
     char *realconfigdir = NULL;
-	char *dse_filename = NULL;
-	char *dse_filestartOK = NULL;
-	int rc = -1;
+    char *dse_filename = NULL;
+    char *dse_filestartOK = NULL;
+    int rc = -1;
 
-    if (configdir!=NULL) {
+    if (configdir!=NULL)
+    {
         realconfigdir = slapi_ch_strdup(configdir);
-    } else if (id!=NULL) {
-        realconfigdir = slapi_ch_smprintf("%s/%s", id, config_sub_dir);
     }
-	slapi_ch_free_string(&id);
+    else
+    {
+        realconfigdir = config_get_configdir();
+    }
     if(realconfigdir!=NULL)
     {
-		/* Set the full path name for the config DSE entry */
-		if (!strstr(filename, realconfigdir))
-		{
-			dse_filename = slapi_ch_smprintf("%s/%s", realconfigdir, filename );
-		}
-		else
-			dse_filename = slapi_ch_strdup(filename);
+        /* Set the full path name for the config DSE entry */
+        if (!strstr(filename, realconfigdir))
+        {
+            dse_filename = slapi_ch_smprintf("%s/%s", realconfigdir, filename);
+        }
+        else
+        {
+            dse_filename = slapi_ch_strdup(filename);
+        }
 
-		if (!strstr(startokfilename, realconfigdir)) {
-			dse_filestartOK = slapi_ch_smprintf("%s/%s", realconfigdir, startokfilename );
-		}
-		else
-			dse_filestartOK = slapi_ch_strdup(startokfilename);
-
-		rc = slapi_copy(dse_filename, dse_filestartOK);
-		if ( rc != 0 )
-		{
-			slapi_log_error( SLAPI_LOG_FATAL, "dse", "Cannot copy"
-					" DSE file \"%s\" to \"%s\" OS error %d (%s)\n",
-					dse_filename, dse_filestartOK,
-					rc, slapd_system_strerror(rc) );
-		}
-		
-		slapi_ch_free_string(&dse_filename);
-		slapi_ch_free_string(&dse_filestartOK);
-		slapi_ch_free_string(&realconfigdir);
-	}
+        if (!strstr(startokfilename, realconfigdir))
+        {
+            dse_filestartOK = slapi_ch_smprintf("%s/%s",
+                                                realconfigdir, startokfilename);
+        }
+        else
+        {
+            dse_filestartOK = slapi_ch_strdup(startokfilename);
+        }
 
-	return rc;
+        rc = slapi_copy(dse_filename, dse_filestartOK);
+        if ( rc != 0 )
+        {
+            slapi_log_error( SLAPI_LOG_FATAL, "dse", "Cannot copy"
+                    " DSE file \"%s\" to \"%s\" OS error %d (%s)\n",
+                    dse_filename, dse_filestartOK,
+                    rc, slapd_system_strerror(rc) );
+        }
+        
+        slapi_ch_free_string(&dse_filename);
+        slapi_ch_free_string(&dse_filestartOK);
+        slapi_ch_free_string(&realconfigdir);
+    }
+
+    return rc;
 }

ldap/servers/slapd/libglobs.c

@@ -513,9 +513,16 @@ static struct config_get_and_set {
 		CONFIG_CONSTANT_STRING, NULL},
 	{CONFIG_HASH_FILTERS_ATTRIBUTE, config_set_hash_filters,
 		NULL, 0, NULL, CONFIG_ON_OFF, (ConfigGetFunc)config_get_hash_filters},
-	{CONFIG_INSTANCEDIR_ATTRIBUTE, NULL /* read only */,
+	{CONFIG_INSTANCEDIR_ATTRIBUTE, config_set_instancedir,
 		NULL, 0,
 		(void**)&global_slapdFrontendConfig.instancedir, CONFIG_STRING, NULL},
+	/* parameterizing schema dir */
+	{CONFIG_SCHEMADIR_ATTRIBUTE, config_set_schemadir,
+		NULL, 0,
+		(void**)&global_slapdFrontendConfig.schemadir, CONFIG_STRING, NULL},
+	/* parameterizing ldif dir */
+	{CONFIG_LDIFDIR_ATTRIBUTE, config_set_ldifdir,
+		NULL, 0, NULL, CONFIG_STRING, NULL},
 	{CONFIG_REWRITE_RFC1274_ATTRIBUTE, config_set_rewrite_rfc1274,
 		NULL, 0,
 		(void**)&global_slapdFrontendConfig.rewrite_rfc1274, CONFIG_ON_OFF, NULL},
@@ -2344,7 +2351,7 @@ config_set_instancedir( const char *attrname, char *value, char *errorbuf, int a
 	/* Set the slapd type also */
 	config_set_slapd_type ();
 
-	/* Set the configdir if not set */
+	/* Set the configdir if not set (it must be set since 7.2) */
 	if (!slapdFrontendConfig->configdir)
 	{
 		char newdir[MAXPATHLEN+1];
@@ -4220,6 +4227,49 @@ config_set_configdir(const char *attrname, char *value, char *errorbuf, int appl
 	return retVal;
 }
 
+char *
+config_get_schemadir()
+{
+	slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig();
+	char *retVal;
+
+	CFG_LOCK_READ(slapdFrontendConfig);
+	retVal = config_copy_strval(slapdFrontendConfig->schemadir);
+	CFG_UNLOCK_READ(slapdFrontendConfig);
+
+	return retVal; 
+}
+
+int
+config_set_schemadir(const char *attrname, char *value, char *errorbuf, int apply)
+{
+	int retVal = LDAP_SUCCESS;
+	slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig();
+  
+	if ( config_value_is_null( attrname, value, errorbuf, 0 )) {
+		return LDAP_OPERATIONS_ERROR;
+	}
+  
+	if (!apply) {
+		return retVal;
+	}
+
+	CFG_LOCK_WRITE(slapdFrontendConfig);
+	slapi_ch_free((void **)&slapdFrontendConfig->schemadir);
+
+	slapdFrontendConfig->schemadir = slapi_ch_strdup(value);
+  
+	CFG_UNLOCK_WRITE(slapdFrontendConfig);
+	return retVal;
+}
+
+int
+config_set_ldifdir(const char *attrname, char *value, char *errorbuf, int apply)
+{
+	/* noop */
+	return LDAP_SUCCESS;
+}
+
 char **
 config_get_errorlog_list()
 {

ldap/servers/slapd/main.c

@@ -255,7 +255,7 @@ chown_dir_files(char *name, struct passwd *pw, PRBool strip_fn)
 }
 
 /* Changes the owner of the files in the logs and
- * config directorys to the user that the server runs as. 
+ * config directory to the user that the server runs as. 
 */
 
 static void
@@ -276,13 +276,26 @@ fix_ownership()
 	}
 
 	/* The instance directory needs to be owned by the local user */
-	slapd_chown_if_not_owner( slapdFrontendConfig->instancedir, pw->pw_uid, -1 );
-	PR_snprintf(dirname,sizeof(dirname),"%s/config",slapdFrontendConfig->instancedir);
-	chown_dir_files(dirname, pw, PR_FALSE); /* config directory */
-	chown_dir_files(slapdFrontendConfig->accesslog, pw, PR_TRUE); /* do access log directory */
-	chown_dir_files(slapdFrontendConfig->auditlog, pw, PR_TRUE);  /* do audit log directory */
-	chown_dir_files(slapdFrontendConfig->errorlog, pw, PR_TRUE);  /* do error log directory */
-
+	if (slapdFrontendConfig->instancedir) {
+		slapd_chown_if_not_owner(slapdFrontendConfig->instancedir,
+								 pw->pw_uid, -1);
+	}
+	/* config directory */
+	if (slapdFrontendConfig->configdir) {
+		chown_dir_files(slapdFrontendConfig->configdir, pw, PR_FALSE);
+	}
+	/* do access log file, if any */
+	if (slapdFrontendConfig->accesslog) {
+		chown_dir_files(slapdFrontendConfig->accesslog, pw, PR_TRUE);
+	}
+	/* do audit log file, if any */
+	if (slapdFrontendConfig->auditlog) {
+		chown_dir_files(slapdFrontendConfig->auditlog, pw, PR_TRUE); 
+	}
+	/* do error log file, if any */
+	if (slapdFrontendConfig->errorlog) {
+		chown_dir_files(slapdFrontendConfig->errorlog, pw, PR_TRUE); 
+	}
 }
 #endif  
 
@@ -365,7 +378,7 @@ name2exemode( char *progname, char *s, int exit_if_unknown )
 	}
 #endif
 	else if ( exit_if_unknown ) {
-		fprintf( stderr, "usage: %s -D instancedir "
+		fprintf( stderr, "usage: %s -D configdir "
 				 "[ldif2db | db2ldif | archive2db "
 				 "| db2archive | db2index | refer | suffix2instance"
 #if defined(UPGRADEDB)
@@ -397,46 +410,46 @@ usage( char *name, char *extraname )
 	
     switch( slapd_exemode ) {
     case SLAPD_EXEMODE_DB2LDIF:
-	usagestr = "usage: %s %s%s-D instancedir [-n backend-instance-name] [-d debuglevel] "
+	usagestr = "usage: %s %s%s-D configdir [-n backend-instance-name] [-d debuglevel] "
 		"[-N] [-a outputfile] [-r] [-C] [{-s includesuffix}*] "
 		"[{-x excludesuffix}*] [-u] [-U] [-m] [-M] [-E]\n"
 		"Note: either \"-n backend_instance_name\" or \"-s includesuffix\" is required.\n";
 	break;
     case SLAPD_EXEMODE_LDIF2DB:
-	usagestr = "usage: %s %s%s-D instancedir [-d debuglevel] "
+	usagestr = "usage: %s %s%s-D configdir [-d debuglevel] "
 		"[-n backend_instance_name] [-O] [-g uniqueid_type] [--namespaceid uniqueID]"
 		"[{-s includesuffix}*] [{-x excludesuffix}*]  [-E] {-i ldif-file}*\n"
 		"Note: either \"-n backend_instance_name\" or \"-s includesuffix\" is required.\n";
 	break;
     case SLAPD_EXEMODE_DB2ARCHIVE:
-	usagestr = "usage: %s %s%s-D instancedir [-d debuglevel] -a archivedir\n";
+	usagestr = "usage: %s %s%s-D configdir [-d debuglevel] -a archivedir\n";
 	break;
     case SLAPD_EXEMODE_ARCHIVE2DB:
-	usagestr = "usage: %s %s%s-D instancedir [-d debuglevel] -a archivedir\n";
+	usagestr = "usage: %s %s%s-D configdir [-d debuglevel] -a archivedir\n";
 	break;
     case SLAPD_EXEMODE_DB2INDEX:
-	usagestr = "usage: %s %s%s-D instancedir -n backend-instance-name "
+	usagestr = "usage: %s %s%s-D configdir -n backend-instance-name "
 		"[-d debuglevel] {-t attributetype}* {-T VLV Search Name}*\n";
 	/* JCM should say 'Address Book' or something instead of VLV */
 	break;
     case SLAPD_EXEMODE_REFERRAL:
-	usagestr = "usage: %s %s%s-D instancedir -r referral-url [-p port]\n";
+	usagestr = "usage: %s %s%s-D configdir -r referral-url [-p port]\n";
 	break;
     case SLAPD_EXEMODE_DBTEST:
-	usagestr = "usage: %s %s%s-D instancedir -n backend-instance-name "
+	usagestr = "usage: %s %s%s-D configdir -n backend-instance-name "
 		"[-d debuglevel] [-S] [-v]\n";
 	break;
     case SLAPD_EXEMODE_SUFFIX2INSTANCE:
-	usagestr = "usage: %s %s%s -D instancedir {-s suffix}*\n";
+	usagestr = "usage: %s %s%s -D configdir {-s suffix}*\n";
 	break;
 #if defined(UPGRADEDB)
     case SLAPD_EXEMODE_UPGRADEDB:
-	usagestr = "usage: %s %s%s-D instancedir [-d debuglevel] [-f] -a archivedir\n";
+	usagestr = "usage: %s %s%s-D configdir [-d debuglevel] [-f] -a archivedir\n";
 	break;
 #endif
 
     default:	/* SLAPD_EXEMODE_SLAPD */
-	usagestr = "usage: %s %s%s-D instancedir [-d debuglevel] "
+	usagestr = "usage: %s %s%s-D configdir [-d debuglevel] "
 		"[-i pidlogfile] [-v] [-V]\n";
     }
 
@@ -683,9 +696,9 @@ main( int argc, char **argv)
 	}
 #endif
 
-    process_command_line(argc,argv,myname,&extraname);
+	process_command_line(argc,argv,myname,&extraname);
 
-	if (!slapdFrontendConfig->instancedir ||
+	if (!slapdFrontendConfig->instancedir &&
 		!slapdFrontendConfig->configdir) {
 		usage( myname, extraname );
 		exit( 1 );
@@ -698,7 +711,7 @@ main( int argc, char **argv)
 	}
 
 #ifndef LDAP_DONT_USE_SMARTHEAP
-        MemRegisterTask();
+	MemRegisterTask();
 #endif
 
 	slapd_init();
@@ -706,39 +719,52 @@ main( int argc, char **argv)
 	vattr_init();
 
 	if (slapd_exemode == SLAPD_EXEMODE_REFERRAL) {
-	    /* make up the config stuff */
-	    referral_set_defaults();
-	    n_port = config_get_port();
-	    s_port = config_get_secureport();
+		slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig();
+		/* make up the config stuff */
+		referral_set_defaults();
+		/*
+		 * Process the config files.
+		 */
+		if (0 == slapd_bootstrap_config(slapdFrontendConfig->configdir)) {
+			slapi_log_error(SLAPI_LOG_FATAL, "startup",
+							"The configuration files in directory %s could not be read or were not found.  Please refer to the error log or output for more information.\n",
+							slapdFrontendConfig->configdir);
+			exit(1);
+		}
+
+		n_port = config_get_port();
+		s_port = config_get_secureport();
    		register_objects();
 
 	} else {
-    	slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig();
-	/* The 2 calls below have been moved to this place to make sure that they
-	 * are called before setup_internal_backends to avoid bug 524439 */
-	/*
-	 * The 2 calls below where being sometimes called AFTER ldapi_register_extended_op
-	 * (such fact was being stated and reproducible for some optimized installations
-	 * at startup (bug 524439)... Such bad call was happening in the context of
-	 * setup_internal_backends -> dse_read_file -> load_plugin_entry ->
-	 * plugin_setup -> replication_multimaster_plugin_init ->
-	 * slapi_register_plugin -> plugin_setup -> multimaster_start_extop_init ->
-	 * slapi_pblock_set -> ldapi_register_extended_op... Unfortunately, the server
-	 * design is such that it is assumed that ldapi_init_extended_ops is always
-	 * called first.
-	 * THE FIX: Move the two calls below before a call to setup_internal_backends
-	 * (down in this same function)
-	 */
-	init_saslmechanisms();
-	ldapi_init_extended_ops();
+		slapdFrontendConfig_t *slapdFrontendConfig = getFrontendConfig();
+		/* The 2 calls below have been moved to this place to make sure that
+		 * they are called before setup_internal_backends to avoid bug 524439 */
+		/*
+		 * The 2 calls below where being sometimes called AFTER 
+		 * ldapi_register_extended_op (such fact was being stated and 
+		 * reproducible for some optimized installations at startup (bug 
+		 * 524439)... Such bad call was happening in the context of
+		 * setup_internal_backends -> dse_read_file -> load_plugin_entry ->
+		 * plugin_setup -> replication_multimaster_plugin_init ->
+		 * slapi_register_plugin -> plugin_setup -> 
+		 * multimaster_start_extop_init -> * slapi_pblock_set ->
+		 * ldapi_register_extended_op... Unfortunately, the server
+		 * design is such that it is assumed that ldapi_init_extended_ops is 
+		 * always called first.
+		 * THE FIX: Move the two calls below before a call to 
+		 * setup_internal_backends (down in this same function)
+		 */
+		init_saslmechanisms();
+		ldapi_init_extended_ops();
 
 		
-	    /*
-	     * Initialize the default backend.  This should be done before we
-	     * process the config. files
-	     */
-	    defbackend_init();
-	    
+		/*
+		 * Initialize the default backend.  This should be done before we
+		 * process the config. files
+		 */
+		defbackend_init();
+		
 		/*
 		 * Register the extensible objects with the factory.
 		 */
@@ -746,12 +772,12 @@ main( int argc, char **argv)
 		/* 
 		 * Register the controls that we support.
 		 */
-    	init_controls();
+		init_controls();
 
-	    /*
-	     * Process the config files.
-	     */
-	    if (0 == slapd_bootstrap_config(slapdFrontendConfig->configdir)) {
+		/*
+		 * Process the config files.
+		 */
+		if (0 == slapd_bootstrap_config(slapdFrontendConfig->configdir)) {
 			slapi_log_error(SLAPI_LOG_FATAL, "startup",
 							"The configuration files in directory %s could not be read or were not found.  Please refer to the error log or output for more information.\n",
 							slapdFrontendConfig->configdir);
@@ -759,7 +785,7 @@ main( int argc, char **argv)
 		}
 
 		/* -sduloutre: must be done before any internal search */
-        /* do it before splitting off to other modes too -robey */
+		/* do it before splitting off to other modes too -robey */
 		/* -richm: must be done before reading config files */
 		if (0 != (return_value = compute_init())) {
 			LDAPDebug(LDAP_DEBUG_ANY, "Initialization Failed 0 %d\n",return_value,0,0);
@@ -774,8 +800,8 @@ main( int argc, char **argv)
 			exit(1);
 		}
 
-	    n_port = config_get_port();
-	    s_port = config_get_secureport();
+		n_port = config_get_port();
+		s_port = config_get_secureport();
 	}
 
 	raise_process_limits();	/* should be done ASAP once config file read */
@@ -792,22 +818,22 @@ main( int argc, char **argv)
 	set_entry_points();
 
 #if defined( XP_WIN32 )
-    if (slapd_exemode == SLAPD_EXEMODE_SLAPD) {
-        /* Register with the NT EventLog */
-        hSlapdEventSource = RegisterEventSource(NULL, pszServerName );
-        if( !hSlapdEventSource  ) {
-            char szMessage[256];
-            PR_snprintf( szMessage, sizeof(szMessage), "Directory Server %s is terminating. Failed "
-                         "to set the EventLog source.", pszServerName);
-            MessageBox(GetDesktopWindow(), szMessage, " ", 
-                       MB_ICONEXCLAMATION | MB_OK);
-            exit( 1 );
-        }
+	if (slapd_exemode == SLAPD_EXEMODE_SLAPD) {
+		/* Register with the NT EventLog */
+		hSlapdEventSource = RegisterEventSource(NULL, pszServerName );
+		if( !hSlapdEventSource  ) {
+			char szMessage[256];
+			PR_snprintf( szMessage, sizeof(szMessage), "Directory Server %s is terminating. Failed "
+						 "to set the EventLog source.", pszServerName);
+			MessageBox(GetDesktopWindow(), szMessage, " ", 
+					   MB_ICONEXCLAMATION | MB_OK);
+			exit( 1 );
+		}
 
-        /* Check to ensure there isn't a copy of this server already running. */
-        if( MultipleInstances() ) 
-            exit( 1 );
-    }
+		/* Check to ensure there isn't a copy of this server already running. */
+		if( MultipleInstances() ) 
+			exit( 1 );
+	}
 #endif
 
 	/*
@@ -826,8 +852,8 @@ main( int argc, char **argv)
 	 * we need to be root in order to open them. 
 	 */
 
-    if ((slapd_exemode == SLAPD_EXEMODE_SLAPD) ||
-        (slapd_exemode == SLAPD_EXEMODE_REFERRAL)) {
+	if ((slapd_exemode == SLAPD_EXEMODE_SLAPD) ||
+		(slapd_exemode == SLAPD_EXEMODE_REFERRAL)) {
 		ports_info.n_port = (unsigned short)n_port;
 		if ( slapd_listenhost2addr( config_get_listenhost(),
 				&ports_info.n_listenaddr ) != 0 ) {
@@ -842,9 +868,9 @@ main( int argc, char **argv)
 
 		return_value = daemon_pre_setuid_init(&ports_info);
 		if (0 != return_value) {
-		    LDAPDebug( LDAP_DEBUG_ANY, "Failed to init daemon\n",
-			       0, 0, 0 );
-		    exit(1);
+			LDAPDebug( LDAP_DEBUG_ANY, "Failed to init daemon\n",
+				   0, 0, 0 );
+			exit(1);
 		}
 	}
 
@@ -853,9 +879,9 @@ main( int argc, char **argv)
 #ifndef _WIN32
 	return_value = main_setuid(slapdFrontendConfig->localuser);
 	if (0 != return_value) {
-	    LDAPDebug( LDAP_DEBUG_ANY, "Failed to change user and group identity to that of %s\n",
+		LDAPDebug( LDAP_DEBUG_ANY, "Failed to change user and group identity to that of %s\n",
 				   slapdFrontendConfig->localuser, 0, 0 );
-	    exit(1);
+		exit(1);
 	}
 #endif
 
@@ -870,7 +896,7 @@ main( int argc, char **argv)
 				&& (0 != s_port) && (s_port <= LDAP_PORT_MAX);
 	/* As of DS 6.1, always do a full initialization so that other
 	 * modules can assume NSS is available
-     */
+	 */
 	if ( slapd_nss_init((slapd_exemode == SLAPD_EXEMODE_SLAPD),
 			(slapd_exemode != SLAPD_EXEMODE_REFERRAL) /* have config? */ )) {
 		 LDAPDebug(LDAP_DEBUG_ANY,
@@ -888,14 +914,14 @@ main( int argc, char **argv)
 		exit( 1 );
 	}
 
-    if ((slapd_exemode == SLAPD_EXEMODE_SLAPD) ||
-        (slapd_exemode == SLAPD_EXEMODE_REFERRAL)) {
-        if ( init_ssl && ( 0 != slapd_ssl_init2(&ports_info.s_socket, 0) ) ) {
-            LDAPDebug(LDAP_DEBUG_ANY,
-                      "ERROR: SSL Initialization phase 2 Failed.\n", 0, 0, 0 );
-            exit( 1 );
-        }
-    }
+	if ((slapd_exemode == SLAPD_EXEMODE_SLAPD) ||
+		(slapd_exemode == SLAPD_EXEMODE_REFERRAL)) {
+		if ( init_ssl && ( 0 != slapd_ssl_init2(&ports_info.s_socket, 0) ) ) {
+			LDAPDebug(LDAP_DEBUG_ANY,
+					  "ERROR: SSL Initialization phase 2 Failed.\n", 0, 0, 0 );
+			exit( 1 );
+		}
+	}
 
 	/*
 	 * if we were called upon to do special database stuff, do it and be
@@ -903,52 +929,52 @@ main( int argc, char **argv)
 	 */
 	switch ( slapd_exemode ) {
 	case SLAPD_EXEMODE_LDIF2DB:
-	    return slapd_exemode_ldif2db();
+		return slapd_exemode_ldif2db();
 
 	case SLAPD_EXEMODE_DB2LDIF:
-	    return slapd_exemode_db2ldif(argc,argv);
+		return slapd_exemode_db2ldif(argc,argv);
 
 	case SLAPD_EXEMODE_DB2INDEX:
-	    return slapd_exemode_db2index();
+		return slapd_exemode_db2index();
 
 	case SLAPD_EXEMODE_ARCHIVE2DB:
-	    return slapd_exemode_archive2db();
+		return slapd_exemode_archive2db();
 
 	case SLAPD_EXEMODE_DB2ARCHIVE:
-	    return slapd_exemode_db2archive();
+		return slapd_exemode_db2archive();
 
 	case SLAPD_EXEMODE_DBTEST:
-	    return slapd_exemode_dbtest();
+		return slapd_exemode_dbtest();
 		
 	case SLAPD_EXEMODE_REFERRAL:
 		/* check that all the necessary info was given, then go on */
-        if (! config_check_referral_mode()) {
-		    LDAPDebug(LDAP_DEBUG_ANY,
-			      "ERROR: No referral URL supplied\n", 0, 0, 0);
+		if (! config_check_referral_mode()) {
+			LDAPDebug(LDAP_DEBUG_ANY,
+				  "ERROR: No referral URL supplied\n", 0, 0, 0);
 			usage( myname, extraname );
-		    exit(1);
+			exit(1);
 		}
 		break;
 
 	case SLAPD_EXEMODE_SUFFIX2INSTANCE:
-	    return slapd_exemode_suffix2instance();
+		return slapd_exemode_suffix2instance();
 
 #if defined(UPGRADEDB)
 	case SLAPD_EXEMODE_UPGRADEDB:
-	    return slapd_exemode_upgradedb();
+		return slapd_exemode_upgradedb();
 #endif
 
 	case SLAPD_EXEMODE_PRINTVERSION:
-	    slapd_print_version(1);
-	    exit(1);
+		slapd_print_version(1);
+		exit(1);
 	}
 
 	/*
 	 * Detach ourselves from the terminal (unless running in debug mode).
 	 * We must detach before we start any threads since detach forks() on
 	 * UNIX.
-     * Have to detach after ssl_init - the user may be prompted for the PIN
-     * on the terminal, so it must be open.
+	 * Have to detach after ssl_init - the user may be prompted for the PIN
+	 * on the terminal, so it must be open.
 	 */
 	detach();
 
@@ -969,8 +995,8 @@ main( int argc, char **argv)
  	 * slapd processes that are currently running
  	 */
 	if ((slapd_exemode != SLAPD_EXEMODE_REFERRAL) &&
-	    ( add_new_slapd_process(slapd_exemode, db2ldif_dump_replica,
-				    skip_db_protect_check) == -1 ))  {
+		( add_new_slapd_process(slapd_exemode, db2ldif_dump_replica,
+					skip_db_protect_check) == -1 ))  {
  		LDAPDebug( LDAP_DEBUG_ANY, 
 				"Shutting down due to possible conflicts with other slapd processes\n",
 				0, 0, 0 );
@@ -988,7 +1014,7 @@ main( int argc, char **argv)
 	  char *versionstring = config_get_versionstring();
 	  char *buildnum = config_get_buildnum();
 	  LDAPDebug( LDAP_DEBUG_ANY, "%s B%s starting up\n",
-		     versionstring, buildnum, 0 );
+			 versionstring, buildnum, 0 );
 	  slapi_ch_free((void **)&buildnum);
 	  slapi_ch_free((void **)&versionstring);
 	}
@@ -1003,8 +1029,8 @@ main( int argc, char **argv)
 				slapdFrontendConfig->configdir);
 
 		eq_init();					/* must be done before plugins started */
-	    snmp_collator_start();
-	    ps_init_psearch_system();   /* must come before plugin_startall() */
+		snmp_collator_start();
+		ps_init_psearch_system();   /* must come before plugin_startall() */
 
 		/* Initailize the mapping tree */
 
@@ -1012,12 +1038,12 @@ main( int argc, char **argv)
 		{
 			LDAPDebug( LDAP_DEBUG_ANY, "Failed to init mapping tree\n",
 				0, 0, 0 );
-        	exit(1);
+			exit(1);
 		}
 
 
 		/* initialize UniqueID generator - must be done once backends are started
-           and event queue is initialized but before plugins are started */
+		   and event queue is initialized but before plugins are started */
 		sdn = slapi_sdn_new_dn_byval ("cn=uniqueid generator,cn=config");
 		rc = uniqueIDGenInit (NULL, sdn, slapd_exemode == SLAPD_EXEMODE_SLAPD);
 		slapi_sdn_free (&sdn);
@@ -1025,7 +1051,7 @@ main( int argc, char **argv)
 		{
 			LDAPDebug( LDAP_DEBUG_ANY,
 				"Fatal Error---Failed to initialize uniqueid generator; error = %d. "
-                "Exiting now.\n", rc, 0, 0 );
+				"Exiting now.\n", rc, 0, 0 );
 			exit( 1 );
 		}
 
@@ -1034,17 +1060,17 @@ main( int argc, char **argv)
 		if ( slapd_security_library_is_initialized() != 0 ) {
 	
 		
-		         start_tls_register_plugin();
+				 start_tls_register_plugin();
 			 LDAPDebug( LDAP_DEBUG_PLUGIN, 
-				    "Start TLS plugin registered.\n",
-				    0, 0, 0 );
+					"Start TLS plugin registered.\n",
+					0, 0, 0 );
 		} 
 #endif
-	    passwd_modify_register_plugin();
-	    LDAPDebug( LDAP_DEBUG_PLUGIN, 
-				    "Password Modify plugin registered.\n", 0, 0, 0 );
+		passwd_modify_register_plugin();
+		LDAPDebug( LDAP_DEBUG_PLUGIN, 
+					"Password Modify plugin registered.\n", 0, 0, 0 );
 
-	    plugin_startall(argc, argv, 1 /* Start Backends */, 1 /* Start Globals */); 
+		plugin_startall(argc, argv, 1 /* Start Backends */, 1 /* Start Globals */); 
 		if (housekeeping_start((time_t)0, NULL) == NULL) {
 			exit (1);
 		}
@@ -1052,50 +1078,50 @@ main( int argc, char **argv)
 		eq_start();					/* must be done after plugins started */
 
 #ifdef HPUX10
-	    /* HPUX linker voodoo */
-	    if (collation_init == NULL) {
+		/* HPUX linker voodoo */
+		if (collation_init == NULL) {
 		exit (1);
-	    }
-	    
+		}
+		
 #endif /* HPUX */
 
-	    normalize_oc();
+		normalize_oc();
 
-	    if (n_port) {
+		if (n_port) {
 #if defined(NET_SSL)
-	    } else if ( config_get_security()) {
+		} else if ( config_get_security()) {
 #endif
-	    } else {
+		} else {
 #ifdef _WIN32	
-    		if( SlapdIsAService() )
-    		{
-    			LDAPServerStatus.dwCurrentState = SERVICE_STOPPED;
-    			LDAPServerStatus.dwCheckPoint = 0;
-    			LDAPServerStatus.dwWaitHint = 0;
-    			LDAPServerStatus.dwWin32ExitCode = 1;
-    			LDAPServerStatus.dwServiceSpecificExitCode = 1;
-
-    			SetServiceStatus(hLDAPServerServiceStatus, &LDAPServerStatus);
-
-    			/* Log this event */
-    			ReportSlapdEvent(EVENTLOG_INFORMATION_TYPE, MSG_SERVER_START_FAILED, 1, 
-    				"Check server port specification");
-    		}
-    		else
-    		{
-    			char szMessage[256];
-    			PR_snprintf( szMessage, sizeof(szMessage), "The Directory Server %s is terminating due to an error. Check server port specification", pszServerName);
-    			MessageBox(GetDesktopWindow(), szMessage,	" ", MB_ICONEXCLAMATION | MB_OK);
-    		}
+			if( SlapdIsAService() )
+			{
+				LDAPServerStatus.dwCurrentState = SERVICE_STOPPED;
+				LDAPServerStatus.dwCheckPoint = 0;
+				LDAPServerStatus.dwWaitHint = 0;
+				LDAPServerStatus.dwWin32ExitCode = 1;
+				LDAPServerStatus.dwServiceSpecificExitCode = 1;
+
+				SetServiceStatus(hLDAPServerServiceStatus, &LDAPServerStatus);
+
+				/* Log this event */
+				ReportSlapdEvent(EVENTLOG_INFORMATION_TYPE, MSG_SERVER_START_FAILED, 1, 
+					"Check server port specification");
+			}
+			else
+			{
+				char szMessage[256];
+				PR_snprintf( szMessage, sizeof(szMessage), "The Directory Server %s is terminating due to an error. Check server port specification", pszServerName);
+				MessageBox(GetDesktopWindow(), szMessage,	" ", MB_ICONEXCLAMATION | MB_OK);
+			}
 #endif
-    		exit(1);
-	    }
+			exit(1);
+		}
 	}
 
-    {
-    	Slapi_PBlock pb;
-    	memset( &pb, '\0', sizeof(pb) );
-    	pb.pb_backend = be;
+	{
+		Slapi_PBlock pb;
+		memset( &pb, '\0', sizeof(pb) );
+		pb.pb_backend = be;
 	}
 
 	if (slapd_exemode != SLAPD_EXEMODE_REFERRAL) {
@@ -1224,7 +1250,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"debug",ArgRequired,'d'},
 		{"backend",ArgRequired,'n'},
 		{"allowMultipleProcesses",ArgNone,'S'},
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{0,0,0}};
 	
 	
@@ -1240,7 +1266,7 @@ process_command_line(int argc, char **argv, char *myname,
 		/*{"whatshouldwecallthis",ArgNone,'C'},*/
 		{"allowMultipleProcesses",ArgNone,'S'},
 		{"noUniqueIds",ArgNone,'u'},
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{"encrypt",ArgOptional,'E'},
 		{"nowrap",ArgNone,'U'},
 		{"minimalEncode",ArgNone,'m'},
@@ -1264,7 +1290,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"allowMultipleProcesses",ArgNone,'S'},
 		{"namespaceid", ArgRequired, 'G'},
 		{"nostate",ArgNone,'Z'},
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{"encrypt",ArgOptional,'E'},
 		{0,0,0}};
 
@@ -1276,7 +1302,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"archive",ArgRequired,'a'},
 		{"backEndInstName",ArgRequired,'n'},
 		{"allowMultipleProcesses",ArgNone,'S'},		
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{0,0,0}};
 
 
@@ -1287,7 +1313,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"pidfile",ArgRequired,'i'},
 		{"archive",ArgRequired,'a'},
 		{"allowMultipleProcesses",ArgNone,'S'},		
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{0,0,0}};
 
 	char *opts_db2index = "vd:a:t:T:SD:n:s:x:"; 
@@ -1299,7 +1325,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"indexAttribute",ArgRequired,'t'},
 		{"vlvIndex",ArgRequired,'T'},
 		{"allowMultipleProcesses",ArgNone,'S'},		
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{"include",ArgRequired,'s'},
 		{"exclude",ArgRequired,'x'},
 		{0,0,0}};
@@ -1311,7 +1337,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"debug",ArgRequired,'d'},
 		{"force",ArgNone,'f'},
 		{"archive",ArgRequired,'a'},
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{0,0,0}};
 #endif
 
@@ -1322,7 +1348,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"port",ArgRequired,'p'},
 		{"referralMode",ArgRequired,'r'},
 		{"allowMultipleProcesses",ArgNone,'S'},		
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{0,0,0}};
 
 	char *opts_suffix2instance = "s:D:";
@@ -1338,7 +1364,7 @@ process_command_line(int argc, char **argv, char *myname,
 		{"debug",ArgRequired,'d'},
 		{"pidfile",ArgRequired,'i'},
 		{"allowMultipleProcesses",ArgNone,'S'},		
-		{"instanceDir",ArgRequired,'D'},
+		{"configDir",ArgRequired,'D'},
 		{"startpidfile",ArgRequired,'w'},
 		{0,0,0}};
 
@@ -1420,7 +1446,7 @@ process_command_line(int argc, char **argv, char *myname,
 
 	while ( (i = getopt_ext( argc, argv, opts,
 							 long_opts, &longopt_index)) != EOF ) {
-		char *instancedir = 0;
+		char *configdir = 0;
 		switch ( i ) {
 #ifdef LDAP_DEBUG
 		case 'd':	/* turn on debugging */
@@ -1446,11 +1472,11 @@ process_command_line(int argc, char **argv, char *myname,
 #endif
 
 		case 'D':	/* config dir */
-			instancedir = rel2abspath( optarg_ext );
+			configdir = rel2abspath( optarg_ext );
 
 #if defined( XP_WIN32 )
 			pszServerName = slapi_ch_malloc( MAX_SERVICE_NAME );
-			if( !SlapdGetServerNameFromCmdline(pszServerName, instancedir, 1) )
+			if( !SlapdGetServerNameFromCmdline(pszServerName, configdir, 1) )
 			{
 				MessageBox(GetDesktopWindow(), "Failed to get the Directory"
 					" Server name from the command-line argument.",
@@ -1458,13 +1484,13 @@ process_command_line(int argc, char **argv, char *myname,
 				exit( 1 );
 			}  
 #endif
-			if ( config_set_instancedir( "instancedir (-D)",
-					instancedir, errorbuf, 1) != LDAP_SUCCESS ) {
+			if ( config_set_configdir( "configdir (-D)",
+					configdir, errorbuf, 1) != LDAP_SUCCESS ) {
 				fprintf( stderr, "%s: aborting now\n", errorbuf );
 			    usage( myname, *extraname );
 			    exit( 1 );
 			}
-			slapi_ch_free((void **)&instancedir);
+			slapi_ch_free((void **)&configdir);
 
 			break;
 

ldap/servers/slapd/proto-slap.h

@@ -301,6 +301,8 @@ int config_set_versionstring(const char *attrname,  char *versionstring, char *e
 int config_set_enquote_sup_oc(const char *attrname,  char *value, char *errorbuf, int apply );
 int config_set_basedn( const char *attrname, char *value, char *errorbuf, int apply );
 int config_set_configdir( const char *attrname, char *value, char *errorbuf, int apply );
+int config_set_schemadir( const char *attrname, char *value, char *errorbuf, int apply );
+int config_set_ldifdir( const char *attrname, char *value, char *errorbuf, int apply );
 int config_set_attrname_exceptions( const char *attrname, char *value, char *errorbuf, int apply );
 int config_set_hash_filters( const char *attrname, char *value, char *errorbuf, int apply );
 int config_set_rewrite_rfc1274( const char *attrname, char *value, char *errorbuf, int apply );
@@ -398,6 +400,7 @@ char *config_get_buildnum(void);
 int config_get_enquote_sup_oc();
 char *config_get_basedn();
 char *config_get_configdir();
+char *config_get_schemadir();
 char **config_get_errorlog_list();
 char **config_get_accesslog_list();
 char **config_get_auditlog_list();

ldap/servers/slapd/schema.c

@@ -4014,7 +4014,11 @@ init_schema_dse(const char *configdir)
 
 	slapi_sdn_init_dn_byref(&schema,"cn=schema");
 
-	schemadir = slapi_ch_smprintf("%s/%s", configdir, SCHEMA_SUBDIR_NAME);
+	schemadir = config_get_schemadir();
+	if (NULL == schemadir) {
+		/* schemadir info is not configured, let's use the default place */
+		schemadir = slapi_ch_smprintf("%s/%s", configdir, SCHEMA_SUBDIR_NAME);
+	}
 
 	filelist = get_priority_filelist(schemadir, ".*ldif$");
 	if (!filelist || !*filelist)

ldap/servers/slapd/slap.h

@@ -1708,6 +1708,8 @@ typedef struct _slapdEntryPoints {
 #define CONFIG_REWRITE_RFC1274_ATTRIBUTE "nsslapd-rewrite-rfc1274"
 
 #define CONFIG_CONFIG_ATTRIBUTE "nsslapd-config"
+#define CONFIG_SCHEMADIR_ATTRIBUTE "nsslapd-schemadir"
+#define CONFIG_LDIFDIR_ATTRIBUTE "nsslapd-ldifdir"
 #define CONFIG_SSLCLIENTAUTH_ATTRIBUTE "nsslapd-SSLclientAuth"
 #define CONFIG_SSL_CHECK_HOSTNAME_ATTRIBUTE "nsslapd-ssl-check-hostname"
 #define CONFIG_HASH_FILTERS_ATTRIBUTE "nsslapd-hash-filters"
@@ -1882,6 +1884,7 @@ typedef struct _slapdFrontendConfig {
 
   char *workingdir;	/* full path of directory before detach */
   char *configdir; /* full path name of directory containing configuration files */
+  char *schemadir; /* full path name of directory containing schema files */
   int attrname_exceptions; /* if true, allow questionable attribute names */
   int rewrite_rfc1274;		/* return attrs for both v2 and v3 names */
   char *schemareplace;		/* see CONFIG_SCHEMAREPLACE_* #defines below */

ldap/servers/slapd/test-plugins/testbind.c

@@ -49,7 +49,7 @@
  as the root DN.
 
  To test this plug-in function, stop the server, edit the dse.ldif file
- (in the <server_root>/slapd-<server_id>/config directory)
+ (in the config directory)
  and add the following lines before restarting the server :
 
  dn: cn=Test Bind,cn=plugins,cn=config

ldap/servers/slapd/tools/pwenc.c

@@ -82,7 +82,7 @@ static void
 usage( name )
 char	*name;
 {
-    fprintf( stderr, "usage: %s -D instance-dir [-H] [-s scheme | -c comparepwd ] password...\n", name );
+    fprintf( stderr, "usage: %s -D config-dir [-H] [-s scheme | -c comparepwd ] password...\n", name );
     exit( 1 );
 }
 
@@ -133,7 +133,7 @@ main( argc, argv )
 	slapdFrontendConfig_t *slapdFrontendConfig =  NULL;
 
 	char *opts = "Hs:c:D:";
-	char *instancedir = NULL;
+	char *configdir = NULL;
     name = argv[ 0 ];
     pwsp = cmppwsp = NULL;
 
@@ -157,13 +157,13 @@ main( argc, argv )
 			/* kexcoff: quite the same as slapd_bootstrap_config */
 			FrontendConfig_init();
 
-			instancedir = rel2abspath( optarg );
-			if ( config_set_instancedir( "configdir (-D)", instancedir,
+			configdir = rel2abspath( optarg );
+			if ( config_set_configdir( "configdir (-D)", configdir,
 						errorbuf, 1) != LDAP_SUCCESS ) {
 				fprintf( stderr, "%s\n", errorbuf );
 				return( 1 );
 			}
-			slapi_ch_free((void **)&instancedir);
+			slapi_ch_free((void **)&configdir);
 
 
 			slapdFrontendConfig = getFrontendConfig();