Ver Fonte

610281 - fix coverity Defect Type: Control flow issues

https://bugzilla.redhat.com/show_bug.cgi?id=610281

11821 DEADCODE Triaged Unassigned Bug Minor Fix Required
allinstance_set_busy() ds/ldap/servers/slapd/back-ldbm/misc.c

11822 DEADCODE Triaged Unassigned Bug Minor Fix Required
allinstance_set_not_busy() ds/ldap/servers/slapd/back-ldbm/misc.c

Comment:
objset_next_obj releases the previous object internally.
Thus, there is no leak.  Just remove the 2 lines:
    if (inst_obj)
        object_release(inst_obj);
Noriko Hosoi há 15 anos atrás
pai
commit
270fa7377e
1 ficheiros alterados com 0 adições e 4 exclusões
  1. 0 4
      ldap/servers/slapd/back-ldbm/misc.c

+ 0 - 4
ldap/servers/slapd/back-ldbm/misc.c

@@ -231,8 +231,6 @@ allinstance_set_not_busy(struct ldbminfo *li)
         inst = (ldbm_instance *)object_get_data(inst_obj);
         instance_set_not_busy(inst);
     }
-    if (inst_obj)
-        object_release(inst_obj);
 }
 
 void
@@ -250,8 +248,6 @@ allinstance_set_busy(struct ldbminfo *li)
                       inst->inst_name);
         }
     }
-    if (inst_obj)
-        object_release(inst_obj);
 }
 
 int