Browse Source

Coverity fix -- 13164: Logically dead code

Bug description: commit 1cbd6d84dd0871af4955ebf93693e8b4331ab07e
for Ticket 47325 - Crash at shutdown on a replica agreement
introduced '13164: Logically dead code'.

Fix description: Since bind_timeout never be NULL, no need to
do NULL check.  Eliminated the dead code.

https://fedorahosted.org/389/ticket/47325
Noriko Hosoi 12 years ago
parent
commit
324eb761df
1 changed files with 1 additions and 2 deletions
  1. 1 2
      ldap/servers/slapd/ldaputil.c

+ 1 - 2
ldap/servers/slapd/ldaputil.c

@@ -1156,8 +1156,7 @@ slapi_ldap_bind(
 		slapi_log_error(SLAPI_LOG_FATAL, "slapi_ldap_bind",
 				"Error: timeout after [%ld.%ld] seconds reading "
 				"bind response for [%s] authentication mechanism [%s]\n",
-				bind_timeout ? bind_timeout->tv_sec : 0,
-				bind_timeout ? bind_timeout->tv_usec : 0,
+				bind_timeout->tv_sec, bind_timeout->tv_usec,
 				bindid ? bindid : "(anon)",
 				mech ? mech : "SIMPLE");
 		goto done;