浏览代码

Bug(s) fixed: 157377
Bug Description: RL16: Server core dumped while configuring replication agreements
Reviewed by: David (Thanks!)
Fix Description: The code for handling bad agreements was wrong. It was not returning the correct error code. The result of this is that the client did not receive an appropriate error code/message from the server. The reason for the core dump was that, even though the agreement was not created, the DSE entry was still there, causing the server to become very confused. Returning the correct error code causes the server to refuse to create the bad DSE entry.
Platforms tested: RHEL3
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none

Rich Megginson 20 年之前
父节点
当前提交
37bff7c59f
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      ldap/servers/plugins/replication/repl5_agmtlist.c

+ 1 - 1
ldap/servers/plugins/replication/repl5_agmtlist.c

@@ -147,7 +147,7 @@ add_new_agreement(Slapi_Entry *e)
     Object *repl_obj = NULL;
     Object *ro = NULL;
 
-    if (ra == NULL) return 0;
+    if (ra == NULL) return 1; /* tell search result handler callback this entry was not sent */
 
     ro = object_new((void *)ra, agmt_delete);
     objset_add_obj(agmt_set, ro);