Bug 691422 - search_internal_callback_pb - fix coverity control flow issues

https://bugzilla.redhat.com/show_bug.cgi?id=691422
Resolves: bug 691422
Bug Description: search_internal_callback_pb - fix coverity control flow issues
Reviewed by: nhosoi (Thanks!)
Branch: master
Fix Description: just get rid of the ifstr ?: - it is ok to pass a NULL to slapi_ch_strdup anyway.
Platforms tested: RHEL6 x86_64
Flag Day: no
Doc impact: no

ldap/servers/slapd/plugin_internal_op.c

@@ -719,7 +719,7 @@ static int search_internal_callback_pb (Slapi_PBlock *pb, void *callback_data,
     op->o_search_entry_handler    = internal_srch_entry_callback;
     op->o_search_referral_handler = internal_ref_entry_callback;
 	
-    filter = slapi_str2filter(ifstr ? (fstr = slapi_ch_strdup(ifstr)) : NULL);
+    filter = slapi_str2filter((fstr = slapi_ch_strdup(ifstr)));
     if(scope == LDAP_SCOPE_BASE) {
         filter->f_flags |= (SLAPI_FILTER_LDAPSUBENTRY |
                             SLAPI_FILTER_TOMBSTONE | SLAPI_FILTER_RUV);