Browse Source

Bug 691574 - (cov#10573) check return value in GER code

We should check the return value of proxyauth_get_dn() in the
get effective rights code.
Nathan Kinder 14 years ago
parent
commit
53da4c8190
1 changed files with 1 additions and 2 deletions
  1. 1 2
      ldap/servers/plugins/acl/acleffectiverights.c

+ 1 - 2
ldap/servers/plugins/acl/acleffectiverights.c

@@ -124,8 +124,7 @@ _ger_g_permission_granted (
 	/*
 	 * The requestor may be either the bind dn or a proxy dn
 	 */
-	proxyauth_get_dn ( pb, &proxydn, &errtext );
-	if ( proxydn != NULL )
+	if ((proxyauth_get_dn( pb, &proxydn, &errtext ) == LDAP_SUCCESS) && ( proxydn != NULL )) {
 	{
 		requestor_sdn = slapi_sdn_new_dn_passin ( proxydn );
 	}