浏览代码

Bug 622903 - fix coverity Defect Type: Code maintainability issues

https://bugzilla.redhat.com/show_bug.cgi?id=622903

Comment:
The str assignment on line 1240 can be removed because the value
is not needed or will be overwritten.
Noriko Hosoi 15 年之前
父节点
当前提交
5543a6e820
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      ldap/servers/plugins/acl/aclutil.c

+ 1 - 1
ldap/servers/plugins/acl/aclutil.c

@@ -1237,7 +1237,7 @@ acl_replace_str(char * s, char *substr, char* replace_with_str) {
 		char *working_s, *suffix, *prefix, *patched;
 		int replace_with_len, substr_len, prefix_len, suffix_len;
 
-		if ( (str = strstr(s, substr)) == NULL) {
+		if (strstr(s, substr) == NULL) {
 			return(slapi_ch_strdup(s));
 		} else {