Browse Source

Bug 750625 - Fix Coverity (11114, 11115) Uninitialized value use

https://bugzilla.redhat.com/show_bug.cgi?id=750625

slapd/back-ldbm/ancestorid.c (ldbm_ancestorid_index_update)

Bug Description: Uninitialized "sdn" and "nextsdn" when calling
"slapi_sdn_done".
Variable "sdn" and "nextsdn" should have been initialized before
any chances to goto "out".

Fix Description: initialize "sdn" and "nextsdn" before the first
"goto out".
Noriko Hosoi 14 years ago
parent
commit
558cc6e401
1 changed files with 4 additions and 3 deletions
  1. 4 3
      ldap/servers/slapd/back-ldbm/ancestorid.c

+ 4 - 3
ldap/servers/slapd/back-ldbm/ancestorid.c

@@ -725,6 +725,9 @@ static int ldbm_ancestorid_index_update(
     int err = 0, ret = 0;
     DB_TXN *db_txn = txn != NULL ? txn->back_txn_txn : NULL;
 
+    slapi_sdn_init(&sdn);
+    slapi_sdn_init(&nextsdn);
+
     /* Open the ancestorid index */
     ainfo_get(be, LDBM_ANCESTORID_STR, &ai);
     ret = dblayer_get_index_file(be, ai, &db, DBOPEN_CREATE);
@@ -733,8 +736,6 @@ static int ldbm_ancestorid_index_update(
         goto out;
     }
 
-    slapi_sdn_init(&sdn);
-    slapi_sdn_init(&nextsdn);
     slapi_sdn_copy(low, &sdn);
 
     if (include_low == 0) {
@@ -819,7 +820,7 @@ static int ldbm_ancestorid_index_update(
 
     } while (ret == 0);
 
- out:
+out:
     slapi_sdn_done(&sdn);
     slapi_sdn_done(&nextsdn);