Selaa lähdekoodia

Bug 630097 - (cov#15509) NULL dereference in idsktune

If strdup() fails, the cmd variable will be NULL.  We dereference
it without checking it strdup() was successful.  We should check
if cmd is NULL before dereferencing it.
Nathan Kinder 15 vuotta sitten
vanhempi
sitoutus
55f94d2a6a
1 muutettua tiedostoa jossa 5 lisäystä ja 0 poistoa
  1. 5 0
      ldap/systools/idsktune.c

+ 5 - 0
ldap/systools/idsktune.c

@@ -1108,6 +1108,11 @@ linux_check_release(void)
   char osl[128];
   char *cmd = strdup("/bin/uname -r");
 
+  if (cmd == NULL) {
+    printf("ERROR: Unable to allocate memory\n");
+    goto done;
+  }
+
   if (flag_html) printf("<P>\n");
   if (flag_debug) printf("DEBUG  : %s\n",cmd);
   fp = popen(cmd,"r");