浏览代码

Bug 630092 - (cov#12105) Resource leak in pwdscheme config code

We don't free new_scheme if the password encode function is not
set.  We need to free new_scheme in this error case.
Nathan Kinder 15 年之前
父节点
当前提交
6b3b9009af
共有 1 个文件被更改,包括 1 次插入1 次删除
  1. 1 1
      ldap/servers/slapd/libglobs.c

+ 1 - 1
ldap/servers/slapd/libglobs.c

@@ -1600,7 +1600,6 @@ config_set_pw_storagescheme( const char *attrname, char *value, char *errorbuf,
 		}
 	retVal = LDAP_OPERATIONS_ERROR;
 	slapi_ch_free_string(&scheme_list);
-	free_pw_scheme(new_scheme);
 	return retVal;
   }
   else if ( new_scheme->pws_enc == NULL )
@@ -1616,6 +1615,7 @@ config_set_pw_storagescheme( const char *attrname, char *value, char *errorbuf,
 	}
 	retVal = LDAP_UNWILLING_TO_PERFORM;
 	slapi_ch_free_string(&scheme_list);
+	free_pw_scheme(new_scheme);
 	return retVal;
   }