浏览代码

Coverity defects

13089: Dereference after null check
       ldbm_back_delete (back-ldbm/ldbm_delete.c)
	   Goto error_return if either of addr or sdnp is NULL.
(cherry picked from commit b5422579f5e42cf04c0d4df834f5b428b16590f0)
Noriko Hosoi 13 年之前
父节点
当前提交
8e5087a397
共有 1 个文件被更改,包括 3 次插入1 次删除
  1. 3 1
      ldap/servers/slapd/back-ldbm/ldbm_delete.c

+ 3 - 1
ldap/servers/slapd/back-ldbm/ldbm_delete.c

@@ -125,9 +125,11 @@ ldbm_back_delete( Slapi_PBlock *pb )
 		slapi_log_error (SLAPI_LOG_TRACE, "ldbm_back_delete", "enter conn=%" NSPRIu64 " op=%d\n", pb->pb_conn->c_connid, operation->o_opid);
 		slapi_log_error (SLAPI_LOG_TRACE, "ldbm_back_delete", "enter conn=%" NSPRIu64 " op=%d\n", pb->pb_conn->c_connid, operation->o_opid);
 	}
 	}
 
 
-	if ((NULL == addr) && (NULL == sdnp))
+	if ((NULL == addr) || (NULL == sdnp))
 	{
 	{
 		/* retval is -1 */
 		/* retval is -1 */
+		slapi_log_error(SLAPI_LOG_FATAL, "ldbm_back_delete",
+		            "Either of DELETE_TARGET_SDN or TARGET_ADDRESS is NULL.\n");
 		goto error_return;
 		goto error_return;
 	}
 	}
 	dn = slapi_sdn_get_dn(sdnp);
 	dn = slapi_sdn_get_dn(sdnp);