فهرست منبع

Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939

https://bugzilla.redhat.com/show_bug.cgi?id=613056
Resolves: bug 613056
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939
Fix description: Catch possible NULL pointer in windows_acquire_replica().
Endi S. Dewata 15 سال پیش
والد
کامیت
a81146c980
1فایلهای تغییر یافته به همراه9 افزوده شده و 2 حذف شده
  1. 9 2
      ldap/servers/plugins/replication/windows_protocol_util.c

+ 9 - 2
ldap/servers/plugins/replication/windows_protocol_util.c

@@ -601,6 +601,13 @@ windows_acquire_replica(Private_Repl_Protocol *prp, RUV **ruv, int check_ruv)
 
 	LDAPDebug( LDAP_DEBUG_TRACE, "=> windows_acquire_replica\n", 0, 0, 0 );
 
+	if (NULL == ruv)
+	{
+        	slapi_log_error(SLAPI_LOG_FATAL, windows_repl_plugin_name, "NULL ruv\n");
+        	return_value = ACQUIRE_FATAL_ERROR;
+		goto done;
+	}
+
 	PR_ASSERT(prp);
 
     if (prp->replica_acquired)  /* we already acquire replica */
@@ -613,7 +620,7 @@ windows_acquire_replica(Private_Repl_Protocol *prp, RUV **ruv, int check_ruv)
         return ACQUIRE_SUCCESS;
     }
 
-	if (NULL != ruv)
+	if (NULL != *ruv)
 	{
 		ruv_destroy ( ruv );
 	}
@@ -716,7 +723,7 @@ windows_acquire_replica(Private_Repl_Protocol *prp, RUV **ruv, int check_ruv)
         /* replica successfully acquired */
         prp->replica_acquired = PR_TRUE;
     }
-
+done:
 	LDAPDebug( LDAP_DEBUG_TRACE, "<= windows_acquire_replica\n", 0, 0, 0 );
 
 	return return_value;