Просмотр исходного кода

Ticket 49534 - Fix coverity regression

Description:  In automembers plugin a free was in the wrong spot
              which later led to a double free for the "rule".

https://pagure.io/389-ds-base/issue/49534

Reviewed by: mreynolds (one line commit rule)
Mark Reynolds 7 лет назад
Родитель
Сommit
b3768e602f
1 измененных файлов с 1 добавлено и 1 удалено
  1. 1 1
      ldap/servers/plugins/automember/automember.c

+ 1 - 1
ldap/servers/plugins/automember/automember.c

@@ -1117,11 +1117,11 @@ automember_parse_regex_entry(struct configEntry *config, Slapi_Entry *e)
                             break;
                             break;
                         }
                         }
                     }
                     }
+                    automember_free_regex_rule(rule);
                 } else {
                 } else {
                     /* Add to head of list */
                     /* Add to head of list */
                     PR_INSERT_LINK(&(rule->list), (PRCList *)config->exclusive_rules);
                     PR_INSERT_LINK(&(rule->list), (PRCList *)config->exclusive_rules);
                 }
                 }
-                automember_free_regex_rule(rule);
             } else {
             } else {
                 slapi_log_err(SLAPI_LOG_ERR, AUTOMEMBER_PLUGIN_SUBSYSTEM,
                 slapi_log_err(SLAPI_LOG_ERR, AUTOMEMBER_PLUGIN_SUBSYSTEM,
                               "automember_parse_regex_entry - Skipping invalid exclusive "
                               "automember_parse_regex_entry - Skipping invalid exclusive "