Browse Source

Ticket #48048 - Fix coverity issues - 2015/2/24

Coverity defect 13051 - Other violation
Description: _pool->pl_buffer_default_pages (used for BDB DB_MULTIPLE_KEY
read) was assigned twice.
modified: clcache_set_config in cl5_clcache.c
Noriko Hosoi 10 years ago
parent
commit
bbf65209fa
1 changed files with 1 additions and 2 deletions
  1. 1 2
      ldap/servers/plugins/replication/cl5_clcache.c

+ 1 - 2
ldap/servers/plugins/replication/cl5_clcache.c

@@ -217,8 +217,7 @@ clcache_set_config ()
 	 * for DB_MULTIPLE_KEY operation.
 	 * for DB_MULTIPLE_KEY operation.
 	 */
 	 */
 	_pool->pl_buffer_default_pages = CL5_DEFAULT_CONFIG_CACHEMEMSIZE / DEFAULT_CLC_BUFFER_PAGE_SIZE + 1;
 	_pool->pl_buffer_default_pages = CL5_DEFAULT_CONFIG_CACHEMEMSIZE / DEFAULT_CLC_BUFFER_PAGE_SIZE + 1;
-	_pool->pl_buffer_default_pages = DEFAULT_CLC_BUFFER_PAGE_COUNT;
-	if ( _pool->pl_buffer_default_pages <= 0 ) {
+	if ( _pool->pl_buffer_default_pages <= 0 ) { /* this never be true... */
 		_pool->pl_buffer_default_pages = DEFAULT_CLC_BUFFER_PAGE_COUNT;
 		_pool->pl_buffer_default_pages = DEFAULT_CLC_BUFFER_PAGE_COUNT;
 	}
 	}