Bug 576074 - search filters with parentheses fail

https://bugzilla.redhat.com/show_bug.cgi?id=576074
Resolves: bug 576074
Bug Description: search filters with parentheses fail
Reviewed by: nhosoi (Thanks!)
Branch: HEAD
Fix Description: PCRE requires '(' and ')' to be escaped to match a literal
parenthesis.  Otherwise, it thinks the parenthesis is used for grouping.
Platforms tested: RHEL5 x86_64
Flag Day: no
Doc impact: no

ldap/servers/plugins/syntaxes/string.c

@@ -262,7 +262,7 @@ string_filter_sub( Slapi_PBlock *pb, char *initial, char **any, char *final,
 	if ( initial != NULL ) {
 		value_normalize( initial, syntax, 1 /* trim leading blanks */ );
 		*p++ = '^';
-		filter_strcpy_special( p, initial );
+		filter_strcpy_special_ext( p, initial, FILTER_STRCPY_ESCAPE_PARENS );
 		p = strchr( p, '\0' );
 	}
 	if ( any != NULL ) {
@@ -271,7 +271,7 @@ string_filter_sub( Slapi_PBlock *pb, char *initial, char **any, char *final,
 			/* ".*" + value */
 			*p++ = '.';
 			*p++ = '*';
-			filter_strcpy_special( p, any[i] );
+			filter_strcpy_special_ext( p, any[i], FILTER_STRCPY_ESCAPE_PARENS );
 			p = strchr( p, '\0' );
 		}
 	}
@@ -280,7 +280,7 @@ string_filter_sub( Slapi_PBlock *pb, char *initial, char **any, char *final,
 		/* ".*" + value */
 		*p++ = '.';
 		*p++ = '*';
-		filter_strcpy_special( p, final );
+		filter_strcpy_special_ext( p, final, FILTER_STRCPY_ESCAPE_PARENS );
 		strcat( p, "$" );
 	}
 

ldap/servers/slapd/filterentry.c

@@ -647,7 +647,7 @@ test_filter_list(
 }
 
 void
-filter_strcpy_special( char *d, char *s )
+filter_strcpy_special_ext( char *d, char *s, int flags )
 {
 	for ( ; *s; s++ ) {
 		switch ( *s ) {
@@ -660,14 +660,27 @@ filter_strcpy_special( char *d, char *s )
 		case '^':
 		case '$':
 			*d++ = '\\';
-			/* FALL */
+			break;
+		case '(':
+		case ')':
+			if (flags & FILTER_STRCPY_ESCAPE_PARENS) {
+				*d++ = '\\';
+			}
+			break;
 		default:
-			*d++ = *s;
+			break;
 		}
+		*d++ = *s;
 	}
 	*d = '\0';
 }
 
+void
+filter_strcpy_special( char *d, char *s )
+{
+	return filter_strcpy_special_ext(d, s, 0);
+}
+
 int test_substring_filter(
     Slapi_PBlock		*pb,
     Slapi_Entry		*e,

ldap/servers/slapd/proto-slap.h

@@ -595,6 +595,8 @@ void set_hash_filters(int i);
  * filterentry.c
  */
 void filter_strcpy_special( char *d, char *s );
+#define FILTER_STRCPY_ESCAPE_PARENS 0x01
+void filter_strcpy_special_ext( char *d, char *s, int flags );
 
 
 /*