1
0
Эх сурвалжийг харах

610281 - fix coverity Defect Type: Control flow issues

https://bugzilla.redhat.com/show_bug.cgi?id=610281

11813 DEADCODE Triaged Unassigned Bug Minor Fix Required
send_dirsync_search() ds/ldap/servers/plugins/replication/windows_connection.c

Comment:
op_string points to a static string:
731 op_string = "search";
We don't need to check op_string in slapi_log_error.
Noriko Hosoi 15 жил өмнө
parent
commit
c38c2a8609

+ 1 - 1
ldap/servers/plugins/replication/windows_connection.c

@@ -758,7 +758,7 @@ send_dirsync_search(Repl_Connection *conn)
             slapi_log_error(SLAPI_LOG_FATAL, repl_plugin_name,
 					"%s: Failed to get %s operation: LDAP error %d (%s)\n",
 					agmt_get_long_name(conn->agmt),
-					op_string ? op_string : "NULL", rc, ldap_err2string(rc));
+					op_string, rc, ldap_err2string(rc));
 			conn->last_ldap_error = rc;
 			if (IS_DISCONNECT_ERROR(rc))
 			{