Ticket 47740 - Fix coverity issues: null deferences - Part 6

12474 - Null pointer dereference - ldap/servers/slapd/tools/migratecred.c
12473 - Null pointer dereference - ldap/srevers/slapd/snmp/main.c
12468 - Null pointer dereference - ldap/servers/plugins/memberof/memberof.c

https://fedorahosted.org/389/ticket/47740

Reviewed by: rmeggins(Thanks!)

ldap/servers/plugins/memberof/memberof.c

@@ -1184,7 +1184,7 @@ int memberof_postop_add(Slapi_PBlock *pb)
 
 			memberof_lock();
 
-			for (i = 0; configCopy.groupattrs[i]; i++)
+			for (i = 0; configCopy.groupattrs && configCopy.groupattrs[i]; i++)
 			{
 				if(0 == slapi_entry_attr_find(e, configCopy.groupattrs[i], &attr))
 				{

ldap/servers/slapd/tools/migratecred.c

@@ -137,7 +137,7 @@ main( int argc, char **argv)
 					/* cred has the prefix, remove it before decoding */
 					prefixCred = strdup(optarg);
 					
-					if ((*prefixCred == PWD_HASH_PREFIX_START) &&
+					if (prefixCred && (*prefixCred == PWD_HASH_PREFIX_START) &&
 						((end = strchr(prefixCred, PWD_HASH_PREFIX_END)) != NULL) &&
 						((namelen = end - prefixCred - 1 ) <= (3*PWD_MAX_NAME_LEN)) )
 					{

ldap/servers/snmp/main.c

@@ -452,8 +452,8 @@ load_config(char *conf_path)
                             got_port = 1;
                         } else if (strcmp(attr, "nsslapd-rundir") == 0) {
                             /* 8 =  "/" + ".stats" + \0 */
-                            serv_p->stats_file = malloc(vlen + strlen(instancename) + 8);
-                            if (serv_p->stats_file != NULL) {
+                            serv_p->stats_file = malloc(vlen + (instancename ? strlen(instancename) : 0) + 8);
+                            if (serv_p->stats_file && instancename) {
                                 snprintf(serv_p->stats_file, vlen + strlen(instancename) + 8,
                                          "%s/%s.stats", val, instancename);
                                 serv_p->stats_file[(vlen + strlen(instancename) + 7)] = (char)0;