浏览代码

Ticket #48048 - Fix coverity issues - 2015/2/24

Coverity defect 13053 - Explicit null dereferenced (FORWARD_NULL)
Description: Added NULL check for sdn.
modified: chaining_back_compare in cb_compare.c
Noriko Hosoi 10 年之前
父节点
当前提交
deaac70c61
共有 1 个文件被更改,包括 5 次插入2 次删除
  1. 5 2
      ldap/servers/plugins/chainingdb/cb_compare.c

+ 5 - 2
ldap/servers/plugins/chainingdb/cb_compare.c

@@ -85,10 +85,13 @@ chaining_back_compare ( Slapi_PBlock *pb )
 		return -1;
 		return -1;
 	}
 	}
 
 
-	slapi_pblock_get( pb, SLAPI_COMPARE_TARGET_SDN, &sdn );
 	slapi_pblock_get( pb, SLAPI_COMPARE_TYPE, &type );
 	slapi_pblock_get( pb, SLAPI_COMPARE_TYPE, &type );
 	slapi_pblock_get( pb, SLAPI_COMPARE_VALUE, &bval );
 	slapi_pblock_get( pb, SLAPI_COMPARE_VALUE, &bval );
-
+	slapi_pblock_get( pb, SLAPI_COMPARE_TARGET_SDN, &sdn );
+	if (NULL == sdn) {
+		cb_send_ldap_result(pb, LDAP_INVALID_DN_SYNTAX, NULL, "Null target DN", 0, NULL );
+		return -1;
+	}
 	dn = slapi_sdn_get_dn(sdn);
 	dn = slapi_sdn_get_dn(sdn);
 
 
 	/* 
 	/*