Kaynağa Gözat

Ticket 48151 - fix coverity issues

13156 - Deref after NULL check
13157 - Uninitialized var
13158 - Uninitialized var

https://fedorahosted.org/389/ticket/48151

Reviewed by: nhosoi(Thanks!)
Mark Reynolds 10 yıl önce
ebeveyn
işleme
f0e700b5a0

+ 3 - 3
ldap/servers/plugins/replication/repl5_replica_config.c

@@ -1496,7 +1496,7 @@ replica_cleanall_ruv_task(Slapi_PBlock *pb, Slapi_Entry *e, Slapi_Entry *eAfter,
     Slapi_Task *task = NULL;
     const Slapi_DN *task_dn;
     Slapi_DN *dn = NULL;
-    ReplicaId rid;
+    ReplicaId rid = -1;
     Object *r;
     const char *force_cleaning;
     const char *base_dn;
@@ -2671,7 +2671,7 @@ delete_cleaned_rid_config(cleanruv_data *clean_data)
     int rc = -1, ret, rid;
 
     if(clean_data == NULL){
-        cleanruv_log(NULL, clean_data->rid, CLEANALLRUV_ID, "delete_cleaned_rid_config: cleanruv data is NULL, "
+        cleanruv_log(NULL, -1, CLEANALLRUV_ID, "delete_cleaned_rid_config: cleanruv data is NULL, "
                 "failed to clean the config.");
         return;
     }
@@ -2811,7 +2811,7 @@ replica_cleanall_ruv_abort(Slapi_PBlock *pb, Slapi_Entry *e, Slapi_Entry *eAfter
     Slapi_Task *task = NULL;
     Slapi_DN *sdn = NULL;
     Replica *replica;
-    ReplicaId rid;;
+    ReplicaId rid = -1;
     Object *r;
     const char *certify_all;
     const char *base_dn;