浏览代码

Apply changes after review

Max Katz 2 年之前
父节点
当前提交
e1c7e8b5ec

+ 2 - 3
src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs

@@ -122,10 +122,9 @@ namespace Avalonia.Build.Tasks
             if (avares.Resources.Count(CheckXamlName) == 0)
             if (avares.Resources.Count(CheckXamlName) == 0)
                 // Nothing to do
                 // Nothing to do
                 return null;
                 return null;
-
-            if (asm.MainModule.TryGetTypeReference("System.Reflection.AssemblyMetadataAttribute", out var asmMetadata))
+            if (typeSystem.FindType("System.Reflection.AssemblyMetadataAttribute") is {} asmMetadata)
             {
             {
-                var ctor = asm.MainModule.ImportReference(asmMetadata.Resolve()
+                var ctor = asm.MainModule.ImportReference(typeSystem.GetTypeReference(asmMetadata).Resolve()
                     .GetConstructors().First(c => c.Parameters.Count == 2).Resolve());
                     .GetConstructors().First(c => c.Parameters.Count == 2).Resolve());
                 var strType = asm.MainModule.ImportReference(typeof(string));
                 var strType = asm.MainModule.ImportReference(typeof(string));
                 var arg1 = new CustomAttributeArgument(strType, "AvaloniaUseCompiledBindingsByDefault");
                 var arg1 = new CustomAttributeArgument(strType, "AvaloniaUseCompiledBindingsByDefault");

+ 1 - 1
src/Avalonia.DesignerSupport/DesignWindowLoader.cs

@@ -43,7 +43,7 @@ namespace Avalonia.DesignerSupport
                     LocalAssembly = localAsm,
                     LocalAssembly = localAsm,
                     BaseUri = baseUri,
                     BaseUri = baseUri,
                     DesignMode = true,
                     DesignMode = true,
-                    UseCompiledBindingsByDefault = bool.TryParse(useCompiledBindings, out var tempBool) && tempBool
+                    UseCompiledBindingsByDefault = bool.TryParse(useCompiledBindings, out var parsedValue ) && parsedValue 
                 });
                 });
                 var style = loaded as IStyle;
                 var style = loaded as IStyle;
                 var resources = loaded as ResourceDictionary;
                 var resources = loaded as ResourceDictionary;