ApiDiffValidation.cs 7.2 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176
  1. using System;
  2. using System.Collections.Generic;
  3. using System.IO;
  4. using System.IO.Compression;
  5. using System.Linq;
  6. using System.Net;
  7. using System.Net.Http;
  8. using System.Text.RegularExpressions;
  9. using System.Threading.Tasks;
  10. using Nuke.Common.Tooling;
  11. using static Serilog.Log;
  12. public static class ApiDiffValidation
  13. {
  14. private static readonly HttpClient s_httpClient = new();
  15. private static readonly (string oldTfm, string newTfm)[] s_tfmRedirects = new[]
  16. {
  17. // We use StartsWith below comparing these tfm, as we ignore platform versions (like, net6.0-ios16.1)
  18. ("net6.0-android", "net7.0-android"),
  19. ("net6.0-ios", "net7.0-ios")
  20. };
  21. public static async Task ValidatePackage(
  22. Tool apiCompatTool, string packagePath, string baselineVersion,
  23. string suppressionFilesFolder, bool updateSuppressionFile)
  24. {
  25. if (baselineVersion is null)
  26. {
  27. throw new InvalidOperationException(
  28. "Build \"api-baseline\" parameter must be set when running Nuke CreatePackages");
  29. }
  30. if (!Directory.Exists(suppressionFilesFolder))
  31. {
  32. Directory.CreateDirectory(suppressionFilesFolder!);
  33. }
  34. await using var baselineStream = await DownloadBaselinePackage(packagePath, baselineVersion);
  35. if (baselineStream == null)
  36. return;
  37. using (var target = new ZipArchive(File.Open(packagePath, FileMode.Open, FileAccess.Read), ZipArchiveMode.Read))
  38. using (var baseline = new ZipArchive(baselineStream, ZipArchiveMode.Read))
  39. using (Helpers.UseTempDir(out var tempFolder))
  40. {
  41. var targetDlls = GetDlls(target);
  42. var baselineDlls = GetDlls(baseline);
  43. var left = new List<string>();
  44. var right = new List<string>();
  45. var packageId = GetPackageId(packagePath);
  46. var suppressionFile = Path.Combine(suppressionFilesFolder, packageId + ".nupkg.xml");
  47. // Don't use Path.Combine with these left and right tool parameters.
  48. // Microsoft.DotNet.ApiCompat.Tool is stupid and treats '/' and '\' as different assemblies in suppression files.
  49. // So, always use Unix '/'
  50. foreach (var baselineDll in baselineDlls)
  51. {
  52. var baselineDllPath = $"baseline/{baselineDll.target}/{baselineDll.entry.Name}";
  53. var baselineDllRealPath = Path.Combine(tempFolder, baselineDllPath);
  54. Directory.CreateDirectory(Path.GetDirectoryName(baselineDllRealPath)!);
  55. await using (var baselineDllFile = File.Create(baselineDllRealPath))
  56. {
  57. await baselineDll.entry.Open().CopyToAsync(baselineDllFile);
  58. }
  59. var targetTfm = baselineDll.target;
  60. if (s_tfmRedirects.FirstOrDefault(t => baselineDll.target.StartsWith(t.oldTfm)).newTfm is {} newTfm)
  61. {
  62. targetTfm = newTfm;
  63. }
  64. var targetDll = targetDlls.FirstOrDefault(e =>
  65. e.target.StartsWith(targetTfm) && e.entry.Name == baselineDll.entry.Name);
  66. if (targetDll.entry is null)
  67. {
  68. throw new InvalidOperationException($"Some assemblies are missing in the new package {packageId}: {baselineDll.entry.Name} for {baselineDll.target}");
  69. }
  70. var targetDllPath = $"target/{targetDll.target}/{targetDll.entry.Name}";
  71. var targetDllRealPath = Path.Combine(tempFolder, targetDllPath);
  72. Directory.CreateDirectory(Path.GetDirectoryName(targetDllRealPath)!);
  73. await using (var targetDllFile = File.Create(targetDllRealPath))
  74. {
  75. await targetDll.entry.Open().CopyToAsync(targetDllFile);
  76. }
  77. left.Add(baselineDllPath);
  78. right.Add(targetDllPath);
  79. }
  80. if (left.Any())
  81. {
  82. var args = $""" -l={string.Join(',', left)} -r="{string.Join(',', right)}" """;
  83. if (File.Exists(suppressionFile))
  84. {
  85. args += $""" --suppression-file="{suppressionFile}" """;
  86. }
  87. if (updateSuppressionFile)
  88. {
  89. args += $""" --suppression-output-file="{suppressionFile}" --generate-suppression-file=true """;
  90. }
  91. var result = apiCompatTool(args, tempFolder)
  92. .Where(t => t.Type == OutputType.Err).ToArray();
  93. if (result.Any())
  94. {
  95. throw new AggregateException(
  96. $"ApiDiffValidation task has failed for \"{Path.GetFileName(packagePath)}\" package",
  97. result.Select(r => new Exception(r.Text)));
  98. }
  99. }
  100. }
  101. }
  102. private static IReadOnlyCollection<(string target, ZipArchiveEntry entry)> GetDlls(ZipArchive archive)
  103. {
  104. return archive.Entries
  105. .Where(e => Path.GetExtension(e.FullName) == ".dll"
  106. // Exclude analyzers and build task, as we don't care about breaking changes there
  107. && !e.FullName.Contains("analyzers/") && !e.FullName.Contains("analyzers\\")
  108. && !e.Name.Contains("Avalonia.Build.Tasks"))
  109. .Select(e => (
  110. entry: e,
  111. isRef: e.FullName.Contains("ref/") || e.FullName.Contains("ref\\"),
  112. target: Path.GetDirectoryName(e.FullName)!.Split(new [] { '/', '\\' }).Last())
  113. )
  114. .GroupBy(e => (e.target, e.entry.Name))
  115. .Select(g => g.MaxBy(e => e.isRef))
  116. .Select(e => (e.target, e.entry))
  117. .ToArray();
  118. }
  119. static async Task<Stream> DownloadBaselinePackage(string packagePath, string baselineVersion)
  120. {
  121. /*
  122. Gets package name from versions like:
  123. Avalonia.0.10.0-preview1
  124. Avalonia.11.0.999-cibuild0037534-beta
  125. Avalonia.11.0.0
  126. */
  127. var packageId = GetPackageId(packagePath);
  128. Information("Downloading {0} {1} baseline package", packageId, baselineVersion);
  129. try
  130. {
  131. using var response = await s_httpClient.SendAsync(new HttpRequestMessage(HttpMethod.Get,
  132. $"https://www.nuget.org/api/v2/package/{packageId}/{baselineVersion}"), HttpCompletionOption.ResponseHeadersRead);
  133. response.EnsureSuccessStatusCode();
  134. await using var stream = await response.Content.ReadAsStreamAsync();
  135. var memoryStream = new MemoryStream();
  136. await stream.CopyToAsync(memoryStream);
  137. memoryStream.Seek(0, SeekOrigin.Begin);
  138. return memoryStream;
  139. }
  140. catch (HttpRequestException e) when (e.StatusCode == HttpStatusCode.NotFound)
  141. {
  142. return null;
  143. }
  144. catch (Exception ex)
  145. {
  146. throw new InvalidOperationException($"Downloading baseline package for {packageId} {baselineVersion} failed.\r" + ex.Message, ex);
  147. }
  148. }
  149. static string GetPackageId(string packagePath)
  150. {
  151. return Regex.Replace(
  152. Path.GetFileNameWithoutExtension(packagePath),
  153. """(\.\d+\.\d+\.\d+(?:-.+)?)$""", "");
  154. }
  155. }