Bladeren bron

variable_watch: Prevent making extra entries in the watch map

When removing a watch on a variable, using the operator [] on the
internal map will create an empty watch if the variable doesn't have any
existing watches. Rather than creating this empty structure in the map,
return if there isn't a watch on the variable already.
Ben Boeckel 12 jaren geleden
bovenliggende
commit
00ce12a334
1 gewijzigde bestanden met toevoegingen van 4 en 0 verwijderingen
  1. 4 0
      Source/cmVariableWatch.cxx

+ 4 - 0
Source/cmVariableWatch.cxx

@@ -80,6 +80,10 @@ void cmVariableWatch::RemoveWatch(const std::string& variable,
                                   WatchMethod method,
                                   void* client_data /*=0*/)
 {
+  if ( !this->WatchMap.count(variable) )
+    {
+    return;
+    }
   cmVariableWatch::VectorOfPairs* vp = &this->WatchMap[variable];
   cmVariableWatch::VectorOfPairs::iterator it;
   for ( it = vp->begin(); it != vp->end(); ++it )