Browse Source

CPack/DragNDrop: Release CoreFoundation objects after they are used

Otherwise we will be leaking memory.
AZero13 7 months ago
parent
commit
07d9e9b5fe
1 changed files with 2 additions and 0 deletions
  1. 2 0
      Source/CPack/cmCPackDragNDropGenerator.cxx

+ 2 - 0
Source/CPack/cmCPackDragNDropGenerator.cxx

@@ -597,6 +597,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir,
         CFStringRef iso_language =
           CFLocaleCreateCanonicalLanguageIdentifierFromString(
             nullptr, language_cfstring);
+        CFRelease(language_cfstring);
         if (!iso_language) {
           cmCPackLogger(cmCPackLog::LOG_ERROR,
                         language << " is not a recognized language"
@@ -606,6 +607,7 @@ int cmCPackDragNDropGenerator::CreateDMG(std::string const& src_dir,
         CFStringGetCString(iso_language, iso_language_cstr,
                            sizeof(iso_language_cstr) - 1,
                            kCFStringEncodingMacRoman);
+        CFRelease(iso_language);
         LangCode lang = 0;
         RegionCode region = 0;
 #if HAVE_CoreServices