Преглед изворни кода

cmMakefile: Use find_if instead of manual loop

...in the `cmMakefile::ValidateCustomCommand()` as it was a warning
issued by `clang-tidy`.
Alex Turbov пре 1 година
родитељ
комит
0a0a826b86
1 измењених фајлова са 10 додато и 8 уклоњено
  1. 10 8
      Source/cmMakefile.cxx

+ 10 - 8
Source/cmMakefile.cxx

@@ -1131,15 +1131,17 @@ bool cmMakefile::ValidateCustomCommand(
   const cmCustomCommandLines& commandLines) const
 {
   // TODO: More strict?
-  for (cmCustomCommandLine const& cl : commandLines) {
-    if (!cl.empty() && !cl[0].empty() && cl[0][0] == '"') {
-      this->IssueMessage(
-        MessageType::FATAL_ERROR,
-        cmStrCat("COMMAND may not contain literal quotes:\n  ", cl[0], '\n'));
-      return false;
-    }
+  const auto it =
+    std::find_if(commandLines.begin(), commandLines.end(),
+                 [](const cmCustomCommandLine& cl) {
+                   return !cl.empty() && !cl[0].empty() && cl[0][0] == '"';
+                 });
+  if (it != commandLines.end()) {
+    this->IssueMessage(
+      MessageType::FATAL_ERROR,
+      cmStrCat("COMMAND may not contain literal quotes:\n  ", (*it)[0], '\n'));
+    return false;
   }
-
   return true;
 }