فهرست منبع

cmTarget: Move a variable initialization closer to where it is used.

This is more readable and easier to reason about.
Stephen Kelly 11 سال پیش
والد
کامیت
10d65d5019
1فایلهای تغییر یافته به همراه1 افزوده شده و 3 حذف شده
  1. 1 3
      Source/cmTarget.cxx

+ 1 - 3
Source/cmTarget.cxx

@@ -5592,9 +5592,6 @@ void cmTarget::ComputeLinkImplementation(const char* config,
                                          LinkImplementation& impl,
                                          LinkImplementation& impl,
                                          cmTarget const* head) const
                                          cmTarget const* head) const
 {
 {
-  // Compute which library configuration to link.
-  cmTarget::LinkLibraryType linkType = this->ComputeLinkType(config);
-
   // Collect libraries directly linked in this configuration.
   // Collect libraries directly linked in this configuration.
   std::vector<std::string> llibs;
   std::vector<std::string> llibs;
   this->GetDirectLinkLibraries(config, llibs, head);
   this->GetDirectLinkLibraries(config, llibs, head);
@@ -5687,6 +5684,7 @@ void cmTarget::ComputeLinkImplementation(const char* config,
     impl.Libraries.push_back(item);
     impl.Libraries.push_back(item);
     }
     }
 
 
+  cmTarget::LinkLibraryType linkType = this->ComputeLinkType(config);
   LinkLibraryVectorType const& oldllibs = this->GetOriginalLinkLibraries();
   LinkLibraryVectorType const& oldllibs = this->GetOriginalLinkLibraries();
   for(cmTarget::LinkLibraryVectorType::const_iterator li = oldllibs.begin();
   for(cmTarget::LinkLibraryVectorType::const_iterator li = oldllibs.begin();
       li != oldllibs.end(); ++li)
       li != oldllibs.end(); ++li)