Browse Source

cmGlobalGenerator: Call AddExtraIDETargets as a hook of Compute().

Relieve the Xcode generator of having to reimplement Compute().
Stephen Kelly 10 years ago
parent
commit
4407eee013

+ 2 - 0
Source/cmGlobalGenerator.cxx

@@ -1282,6 +1282,8 @@ bool cmGlobalGenerator::Compute()
       }
     }
 
+  this->AddExtraIDETargets();
+
   return true;
 }
 

+ 1 - 0
Source/cmGlobalGenerator.h

@@ -84,6 +84,7 @@ public:
   virtual void Configure();
 
   virtual bool Compute();
+  virtual void AddExtraIDETargets() {}
 
   enum TargetTypes {
     AllTargets,

+ 0 - 11
Source/cmGlobalXCodeGenerator.cxx

@@ -376,17 +376,6 @@ cmGlobalXCodeGenerator::CreateLocalGenerator(cmMakefile* mf)
   return new cmLocalXCodeGenerator(this, mf);
 }
 
-//----------------------------------------------------------------------------
-bool cmGlobalXCodeGenerator::Compute()
-{
-  if (!cmGlobalGenerator::Compute())
-    {
-      return false;
-    }
-  this->AddExtraIDETargets();
-  return true;
-}
-
 void cmGlobalXCodeGenerator::AddExtraIDETargets()
 {
   std::map<std::string, std::vector<cmLocalGenerator*> >::iterator it;

+ 1 - 2
Source/cmGlobalXCodeGenerator.h

@@ -87,8 +87,7 @@ public:
   virtual bool SetGeneratorToolset(std::string const& ts, cmMakefile* mf);
   void AppendFlag(std::string& flags, std::string const& flag);
 protected:
-  virtual bool Compute();
-  void AddExtraIDETargets();
+  virtual void AddExtraIDETargets();
   virtual void Generate();
 private:
   cmXCodeObject* CreateOrGetPBXGroup(cmTarget& cmtarget,