浏览代码

Fix file() command descriptor leak on error

Credit goes to "cppcheck".

Signed-off-by: Thomas Jarosch <[email protected]>
Thomas Jarosch 14 年之前
父节点
当前提交
4868921bc2
共有 1 个文件被更改,包括 2 次插入0 次删除
  1. 2 0
      Source/cmFileCommand.cxx

+ 2 - 0
Source/cmFileCommand.cxx

@@ -2982,6 +2982,7 @@ cmFileCommand::HandleUploadCommand(std::vector<std::string> const& args)
     std::string errStr = "UPLOAD cannot stat file '";
     std::string errStr = "UPLOAD cannot stat file '";
     errStr += filename + "'.";
     errStr += filename + "'.";
     this->SetError(errStr.c_str());
     this->SetError(errStr.c_str());
+    fclose(fin);
     return false;
     return false;
     }
     }
 
 
@@ -2991,6 +2992,7 @@ cmFileCommand::HandleUploadCommand(std::vector<std::string> const& args)
   if(!curl)
   if(!curl)
     {
     {
     this->SetError("UPLOAD error initializing curl.");
     this->SetError("UPLOAD error initializing curl.");
+    fclose(fin);
     return false;
     return false;
     }
     }