Преглед изворни кода

Utilities/Sphinx: Don't ignore flake8 E402

Refactor commit 1f39a3cd1a (Utilities/Sphinx: Restore explicit check for
Sphinx 2.x or later) to avoid needing to suppress flake8 E402. While
ignoring it with respect to the docutils/sphinx imports and the sphinx
version check was correct, the need to disable it for the whole file was
suboptimal.
Matthew Woehlke пре 2 година
родитељ
комит
4bd1beded4
2 измењених фајлова са 18 додато и 21 уклоњено
  1. 0 3
      Utilities/Sphinx/.flake8
  2. 18 18
      Utilities/Sphinx/cmake.py

+ 0 - 3
Utilities/Sphinx/.flake8

@@ -1,3 +0,0 @@
-[flake8]
-per-file-ignores =
-     cmake.py: E402

+ 18 - 18
Utilities/Sphinx/cmake.py

@@ -11,24 +11,24 @@ from typing import Any, List, Tuple, Type, cast
 
 import sphinx
 
-# Require at least Sphinx 2.x.
-# flake8 issues E402 for imports after this, but the purpose of this
-# check is to fail more clearly if the imports below will fail.
-assert sphinx.version_info >= (2,)
-
-from docutils.utils.code_analyzer import Lexer, LexerError
-from docutils.parsers.rst import Directive, directives
-from docutils.transforms import Transform
-from docutils.nodes import Element, Node, TextElement, system_message
-from docutils import io, nodes
-
-from sphinx.directives import ObjectDescription, nl_escape_re
-from sphinx.domains import Domain, ObjType
-from sphinx.roles import XRefRole
-from sphinx.util.docutils import ReferenceRole
-from sphinx.util.nodes import make_refnode
-from sphinx.util import logging, ws_re
-from sphinx import addnodes
+# The following imports may fail if we don't have Sphinx 2.x or later.
+if sphinx.version_info >= (2,):
+    from docutils.utils.code_analyzer import Lexer, LexerError
+    from docutils.parsers.rst import Directive, directives
+    from docutils.transforms import Transform
+    from docutils.nodes import Element, Node, TextElement, system_message
+    from docutils import io, nodes
+
+    from sphinx.directives import ObjectDescription, nl_escape_re
+    from sphinx.domains import Domain, ObjType
+    from sphinx.roles import XRefRole
+    from sphinx.util.docutils import ReferenceRole
+    from sphinx.util.nodes import make_refnode
+    from sphinx.util import logging, ws_re
+    from sphinx import addnodes
+else:
+    # Sphinx 2.x is required.
+    assert sphinx.version_info >= (2,)
 
 # END imports