Pārlūkot izejas kodu

VS: Drop StdOutEncoding with VS 16.6 pending investigation

The `StdOutEncoding` added to `.vcxproj` files since commit bc877a7e94
(Add support to indicate UTF-8 custom command pipe output encoding,
2020-04-08) breaks custom commands with symbolic outputs on VS 16.6.0.
Disable it pending further investigation and possibly a fix in VS.

Issue: #20769
Brad King 5 gadi atpakaļ
vecāks
revīzija
5058fb5401
1 mainītis faili ar 5 papildinājumiem un 2 dzēšanām
  1. 5 2
      Source/cmVisualStudio10TargetGenerator.cxx

+ 5 - 2
Source/cmVisualStudio10TargetGenerator.cxx

@@ -4951,7 +4951,10 @@ std::string cmVisualStudio10TargetGenerator::GetCMakeFilePath(
   return path;
 }
 
-void cmVisualStudio10TargetGenerator::WriteStdOutEncodingUtf8(Elem& e1)
+void cmVisualStudio10TargetGenerator::WriteStdOutEncodingUtf8(Elem& /* e1 */)
 {
-  e1.Element("StdOutEncoding", "UTF-8");
+  // FIXME: As of VS 16.6.0, this breaks custom commands with symbolic outputs.
+  // See https://gitlab.kitware.com/cmake/cmake/-/issues/20769 for details.
+  // Disable it for now.
+  // e1.Element("StdOutEncoding", "UTF-8");
 }