Просмотр исходного кода

MSYS/MinGW Makefiles: Simplify selection of windres as Resource Compiler

Since commit 957c2aac7f (RC: Simplify selection of resource compiler
based on C/C++ toolchain, 2015-05-07, v3.3.0-rc1~101^2~3), `windres` is
selected automatically when using compilers that target the GNU ABI.
Drop the generator-specific preference to make behavior more consistent
with the Ninja generator.

Issue: #23542
Brad King 3 лет назад
Родитель
Сommit
55ba10dcfd

+ 0 - 15
Source/cmGlobalMSYSMakefileGenerator.cxx

@@ -42,22 +42,7 @@ std::string cmGlobalMSYSMakefileGenerator::FindMinGW(
 void cmGlobalMSYSMakefileGenerator::EnableLanguage(
   std::vector<std::string> const& l, cmMakefile* mf, bool optional)
 {
-  this->FindMakeProgram(mf);
-  const std::string& makeProgram =
-    mf->GetRequiredDefinition("CMAKE_MAKE_PROGRAM");
-  std::vector<std::string> locations;
-  std::string makeloc = cmSystemTools::GetProgramPath(makeProgram);
-  locations.push_back(this->FindMinGW(makeloc));
-  locations.push_back(makeloc);
-  locations.push_back("/mingw/bin");
-  locations.push_back("c:/mingw/bin");
-  std::string trc = cmSystemTools::FindProgram("windres", locations);
-  std::string rc = "windres.exe";
-  if (!trc.empty()) {
-    rc = trc;
-  }
   mf->AddDefinition("MSYS", "1");
-  mf->AddDefinition("CMAKE_GENERATOR_RC", rc);
   this->cmGlobalUnixMakefileGenerator3::EnableLanguage(l, mf, optional);
 
   if (!mf->IsSet("CMAKE_AR") && !this->CMakeInstance->GetIsInTryCompile() &&

+ 0 - 19
Source/cmGlobalMinGWMakefileGenerator.cxx

@@ -19,25 +19,6 @@ cmGlobalMinGWMakefileGenerator::cmGlobalMinGWMakefileGenerator(cmake* cm)
   cm->GetState()->SetMinGWMake(true);
 }
 
-void cmGlobalMinGWMakefileGenerator::EnableLanguage(
-  std::vector<std::string> const& l, cmMakefile* mf, bool optional)
-{
-  this->FindMakeProgram(mf);
-  const std::string& makeProgram =
-    mf->GetRequiredDefinition("CMAKE_MAKE_PROGRAM");
-  std::vector<std::string> locations;
-  locations.push_back(cmSystemTools::GetProgramPath(makeProgram));
-  locations.push_back("/mingw/bin");
-  locations.push_back("c:/mingw/bin");
-  std::string trc = cmSystemTools::FindProgram("windres", locations);
-  std::string rc = "windres.exe";
-  if (!trc.empty()) {
-    rc = trc;
-  }
-  mf->AddDefinition("CMAKE_GENERATOR_RC", rc);
-  this->cmGlobalUnixMakefileGenerator3::EnableLanguage(l, mf, optional);
-}
-
 void cmGlobalMinGWMakefileGenerator::GetDocumentation(
   cmDocumentationEntry& entry)
 {

+ 0 - 7
Source/cmGlobalMinGWMakefileGenerator.h

@@ -36,11 +36,4 @@ public:
 
   /** Get the documentation entry for this generator.  */
   static void GetDocumentation(cmDocumentationEntry& entry);
-
-  /**
-   * Try to determine system information such as shared library
-   * extension, pthreads, byte order etc.
-   */
-  virtual void EnableLanguage(std::vector<std::string> const& languages,
-                              cmMakefile*, bool optional);
 };