Browse Source

VS: Fix Intel plugin version detection fallback

Do not read a value that was not parsed.
Brad King 1 year ago
parent
commit
5c77facd78
1 changed files with 2 additions and 2 deletions
  1. 2 2
      Source/cmGlobalVisualStudio7Generator.cxx

+ 2 - 2
Source/cmGlobalVisualStudio7Generator.cxx

@@ -94,8 +94,8 @@ const std::string& cmGlobalVisualStudio7Generator::GetIntelProjectVersion()
     cmSystemTools::ReadRegistryValue(vskey, intelVersion,
     cmSystemTools::ReadRegistryValue(vskey, intelVersion,
                                      cmSystemTools::KeyWOW64_32);
                                      cmSystemTools::KeyWOW64_32);
     unsigned int intelVersionNumber = ~0u;
     unsigned int intelVersionNumber = ~0u;
-    sscanf(intelVersion.c_str(), "%u", &intelVersionNumber);
-    if (intelVersionNumber >= 11) {
+    if (sscanf(intelVersion.c_str(), "%u", &intelVersionNumber) != 1 ||
+        intelVersionNumber >= 11) {
       // Default to latest known project file version.
       // Default to latest known project file version.
       intelVersion = "11.0";
       intelVersion = "11.0";
     } else if (intelVersionNumber == 10) {
     } else if (intelVersionNumber == 10) {