Преглед на файлове

cmGlobalVisualStudio8Generator: Fix the misaligned argument, stdPipesUTF8

The call to AddCustomCommandToTarget for "Checking File Globs" had misaligned
arguments and previously passed `stdPipesUTF8` as `escapeOldStyle`.

For now, set `escapeOldStyle` as `true`. Also `stdPipesUTF8` is `true` here.
NAKAMURA Takumi преди 3 години
родител
ревизия
68b4e3b255
променени са 1 файла, в които са добавени 11 реда и са изтрити 5 реда
  1. 11 5
      Source/cmGlobalVisualStudio8Generator.cxx

+ 11 - 5
Source/cmGlobalVisualStudio8Generator.cxx

@@ -203,11 +203,17 @@ bool cmGlobalVisualStudio8Generator::AddCheckTarget()
       std::vector<std::string> byproducts;
       byproducts.push_back(cm->GetGlobVerifyStamp());
 
-      lg.AddCustomCommandToTarget(CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts,
-                                  no_depends, verifyCommandLines,
-                                  cmCustomCommandType::PRE_BUILD,
-                                  "Checking File Globs", no_working_directory,
-                                  cmPolicies::NEW, stdPipesUTF8);
+      lg.AddCustomCommandToTarget(
+        CMAKE_CHECK_BUILD_SYSTEM_TARGET, byproducts, no_depends,
+        verifyCommandLines, cmCustomCommandType::PRE_BUILD,
+        "Checking File Globs", no_working_directory, cmPolicies::NEW,
+        /*escapeOldStyle=*/true,
+        /*uses_terminal=*/false,
+        /*depfile=*/"",
+        /*job_pool=*/"",
+        /*command_expand_lists=*/false,
+        /*objLibCommands=*/cmObjectLibraryCommands::Reject,
+        /*stdPipesUTF8=*/stdPipesUTF8);
 
       // Ensure ZERO_CHECK always runs in Visual Studio using MSBuild,
       // otherwise the prebuild command will not be run.