Browse Source

FASTBuild: fix globbing for large projects

FASTBuild will replace `%1%` with
all the glob matches, which might
exceed command line limit on Windows.
Moreover, we don't need to pass all the
matches to the VerifyGlobs.cmake script.

Fixes: #27305
Eduard Voronkin 1 week ago
parent
commit
6fd6bfab6f
1 changed files with 2 additions and 2 deletions
  1. 2 2
      Source/cmGlobalFastbuildGenerator.cxx

+ 2 - 2
Source/cmGlobalFastbuildGenerator.cxx

@@ -1543,8 +1543,8 @@ void cmGlobalFastbuildGenerator::AddGlobCheckExec()
     FastbuildExecNode globCheck;
     globCheck.Name = FASTBUILD_GLOB_CHECK_TARGET;
     globCheck.ExecExecutable = cmSystemTools::GetCMakeCommand();
-    globCheck.ExecArguments = "-P " FASTBUILD_1_INPUT_PLACEHOLDER;
-    globCheck.ExecInput = { this->ConvertToFastbuildPath(globScript) };
+    globCheck.ExecArguments =
+      cmStrCat("-P ", this->ConvertToFastbuildPath(globScript));
     globCheck.ExecAlways = false;
     globCheck.ExecUseStdOutAsOutput = false;
     auto const cache = this->GetCMakeInstance()->GetGlobCacheEntries();