Browse Source

Merge topic 'fix-policy-scopes'

50fd0a33 Tests: Simplify and document policy scopes in RunCMake.CMP* tests
b1bbee3e Record more policies on targets when created
Brad King 11 years ago
parent
commit
7b0efcded3

+ 1 - 1
Source/cmComputeTargetDepends.cxx

@@ -349,7 +349,7 @@ void cmComputeTargetDepends::AddTargetDepend(int depender_index,
     cmMakefile *makefile = depender->GetMakefile();
     cmMakefile *makefile = depender->GetMakefile();
     cmake::MessageType messageType = cmake::AUTHOR_WARNING;
     cmake::MessageType messageType = cmake::AUTHOR_WARNING;
     bool issueMessage = false;
     bool issueMessage = false;
-    switch(makefile->GetPolicyStatus(cmPolicies::CMP0046))
+    switch(depender->GetPolicyStatusCMP0046())
       {
       {
       case cmPolicies::WARN:
       case cmPolicies::WARN:
         issueMessage = true;
         issueMessage = true;

+ 2 - 2
Source/cmTarget.cxx

@@ -1631,7 +1631,7 @@ static void processIncludeDirectories(cmTarget const* tgt,
         cmake::MessageType messageType = cmake::FATAL_ERROR;
         cmake::MessageType messageType = cmake::FATAL_ERROR;
         if (fromEvaluatedImported)
         if (fromEvaluatedImported)
           {
           {
-          switch(mf->GetPolicyStatus(cmPolicies::CMP0027))
+          switch(tgt->GetPolicyStatusCMP0027())
             {
             {
             case cmPolicies::WARN:
             case cmPolicies::WARN:
               e << (mf->GetPolicies()
               e << (mf->GetPolicies()
@@ -5840,7 +5840,7 @@ void cmTarget::ComputeLinkImplementation(const std::string& config,
         bool noMessage = false;
         bool noMessage = false;
         cmake::MessageType messageType = cmake::FATAL_ERROR;
         cmake::MessageType messageType = cmake::FATAL_ERROR;
         cmOStringStream e;
         cmOStringStream e;
-        switch(this->Makefile->GetPolicyStatus(cmPolicies::CMP0038))
+        switch(this->GetPolicyStatusCMP0038())
           {
           {
           case cmPolicies::WARN:
           case cmPolicies::WARN:
             {
             {

+ 4 - 1
Source/cmTarget.h

@@ -26,8 +26,11 @@
   F(CMP0020) \
   F(CMP0020) \
   F(CMP0021) \
   F(CMP0021) \
   F(CMP0022) \
   F(CMP0022) \
+  F(CMP0027) \
+  F(CMP0038) \
   F(CMP0041) \
   F(CMP0041) \
-  F(CMP0042)
+  F(CMP0042) \
+  F(CMP0046)
 
 
 class cmake;
 class cmake;
 class cmMakefile;
 class cmMakefile;

+ 1 - 1
Tests/RunCMake/CMP0027/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} NONE)
 project(${RunCMake_TEST} NONE)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0028/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE) # policy used at end of dir

+ 1 - 1
Tests/RunCMake/CMP0037/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0038/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.12)
 cmake_minimum_required(VERSION 2.8.12)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0039/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.12)
 cmake_minimum_required(VERSION 2.8.12)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0040/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.12)
 cmake_minimum_required(VERSION 2.8.12)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0041/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0042/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0043/CMakeLists.txt

@@ -1,6 +1,6 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE) # policy used at end of dir
 
 
 if(CMAKE_BUILD_TYPE)
 if(CMAKE_BUILD_TYPE)
   # Dummy variable use
   # Dummy variable use

+ 1 - 1
Tests/RunCMake/CMP0045/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.4)
 cmake_minimum_required(VERSION 2.8.4)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0046/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.12)
 cmake_minimum_required(VERSION 2.8.12)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0049/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.12)
 cmake_minimum_required(VERSION 2.8.12)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 1 - 1
Tests/RunCMake/CMP0050/CMakeLists.txt

@@ -1,3 +1,3 @@
 cmake_minimum_required(VERSION 2.8.12)
 cmake_minimum_required(VERSION 2.8.12)
 project(${RunCMake_TEST} CXX)
 project(${RunCMake_TEST} CXX)
-include(${RunCMake_TEST}.cmake NO_POLICY_SCOPE)
+include(${RunCMake_TEST}.cmake)

+ 3 - 0
Tests/RunCMake/TargetPolicies/PolicyList-stderr.txt

@@ -11,8 +11,11 @@
    \* CMP0020
    \* CMP0020
    \* CMP0021
    \* CMP0021
    \* CMP0022
    \* CMP0022
+   \* CMP0027
+   \* CMP0038
    \* CMP0041
    \* CMP0041
    \* CMP0042
    \* CMP0042
+   \* CMP0046
 
 
 Call Stack \(most recent call first\):
 Call Stack \(most recent call first\):
   CMakeLists.txt:3 \(include\)
   CMakeLists.txt:3 \(include\)