Просмотр исходного кода

cmGeneratedFileStreamBase: Optimize string construction in Close

Use cmStrCat to concatenate two parts of a file name.

This also avoids a bugprone-exception-escape diagnostic from
clang-tidy-8 on macOS.
Brad King 6 лет назад
Родитель
Сommit
7c5ec91301
1 измененных файлов с 2 добавлено и 1 удалено
  1. 2 1
      Source/cmGeneratedFileStream.cxx

+ 2 - 1
Source/cmGeneratedFileStream.cxx

@@ -4,6 +4,7 @@
 
 #include <stdio.h>
 
+#include "cmStringAlgorithms.h"
 #include "cmSystemTools.h"
 
 #if !defined(CMAKE_BOOTSTRAP)
@@ -149,7 +150,7 @@ bool cmGeneratedFileStreamBase::Close()
     // The destination is to be replaced.  Rename the temporary to the
     // destination atomically.
     if (this->Compress) {
-      std::string gzname = this->TempName + ".temp.gz";
+      std::string gzname = cmStrCat(this->TempName, ".temp.gz");
       if (this->CompressFile(this->TempName, gzname)) {
         this->RenameFile(gzname, resname);
       }