Procházet zdrojové kódy

CPackIFW: Fix cppcheck warnings

The cppcheck warnings about uninitialised variables are likely harmless,
since they are initialised in ParseResource() anyway. Fix the warnings
anyway to reduce linting noise. The warning about a single argument
non-explicit constructor is worth fixing in general.
Craig Scott před 4 roky
rodič
revize
7ed7db88a4
1 změnil soubory, kde provedl 4 přidání a 3 odebrání
  1. 4 3
      Source/CPack/IFW/cmCPackIFWInstaller.cxx

+ 4 - 3
Source/CPack/IFW/cmCPackIFWInstaller.cxx

@@ -275,9 +275,8 @@ void cmCPackIFWInstaller::ConfigureFromOptions()
 class cmCPackIFWResourcesParser : public cmXMLParser
 {
 public:
-  cmCPackIFWResourcesParser(cmCPackIFWInstaller* i)
+  explicit cmCPackIFWResourcesParser(cmCPackIFWInstaller* i)
     : installer(i)
-    , file(false)
   {
     this->path = i->Directory + "/resources";
   }
@@ -296,7 +295,9 @@ public:
   }
 
   cmCPackIFWInstaller* installer;
-  bool file, hasFiles, hasErrors;
+  bool file = false;
+  bool hasFiles = false;
+  bool hasErrors = false;
   std::string path, basePath;
 
 protected: