cmake: Display error if generate step fails

Source/cmake.cxx

@@ -1733,6 +1733,11 @@ int cmake::Run(const std::vector<std::string>& args, bool noconfigure)
     return ret;
   }
   ret = this->Generate();
+  if (ret) {
+    cmSystemTools::Message("CMake Generate step failed.  "
+                           "Build files cannot be regenerated correctly.");
+    return ret;
+  }
   std::string message = "Build files have been written to: ";
   message += this->GetHomeOutputDirectory();
   this->UpdateProgress(message, -1);

Tests/RunCMake/CMP0069/CMP0069-NEW-cmake-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at CMP0069-NEW-cmake\.cmake:[0-9]+ \(add_executable\):
   CMake doesn't support IPO for current compiler
 Call Stack \(most recent call first\):
-  CMakeLists\.txt:[0-9]+ \(include\)$
+  CMakeLists\.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/CMP0069/CMP0069-NEW-compiler-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at CMP0069-NEW-compiler\.cmake:[0-9]+ \(add_executable\):
   Compiler doesn't support IPO
 Call Stack \(most recent call first\):
-  CMakeLists\.txt:[0-9]+ \(include\)$
+  CMakeLists\.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/CMP0069/CMP0069-NEW-generator-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at CMP0069-NEW-generator\.cmake:[0-9]+ \(add_executable\):
   CMake doesn't support IPO for current generator
 Call Stack \(most recent call first\):
-  CMakeLists\.txt:[0-9]+ \(include\)$
+  CMakeLists\.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/GeneratorExpression/BadAND-stderr.txt

@@ -50,4 +50,6 @@ CMake Error at BadAND.cmake:1 \(add_custom_target\):
 
   Parameters to \$<AND> must resolve to either '0' or '1'.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:3 \(include\)$
+  CMakeLists.txt:3 \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/GeneratorExpression/BadCONFIG-stderr.txt

@@ -32,4 +32,6 @@ CMake Error at BadCONFIG.cmake:1 \(add_custom_target\):
 
   Expression syntax not recognized.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:3 \(include\)$
+  CMakeLists.txt:3 \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/GeneratorExpression/BadNOT-stderr.txt

@@ -49,4 +49,6 @@ CMake Error at BadNOT.cmake:1 \(add_custom_target\):
 
   \$<NOT> parameter must resolve to exactly one '0' or '1' value.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:3 \(include\)$
+  CMakeLists.txt:3 \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/GeneratorExpression/BadOR-stderr.txt

@@ -50,4 +50,6 @@ CMake Error at BadOR.cmake:1 \(add_custom_target\):
 
   Parameters to \$<OR> must resolve to either '0' or '1'.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:3 \(include\)$
+  CMakeLists.txt:3 \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/GeneratorExpression/BadStrEqual-stderr.txt

@@ -35,4 +35,6 @@ CMake Error at BadStrEqual.cmake:1 \(add_custom_target\):
   \$<STREQUAL> expression requires 2 comma separated parameters, but got 3
   instead.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:3 \(include\)$
+  CMakeLists.txt:3 \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/GeneratorExpression/BadTargetName-stderr.txt

@@ -5,4 +5,6 @@ CMake Error at BadTargetName.cmake:1 \(add_custom_target\):
 
   \$<TARGET_NAME> expression requires literal input.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:3 \(include\)$
+  CMakeLists.txt:3 \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/MSVCRuntimeLibrary/CMP0091-NEW-stderr.txt

@@ -1,2 +1,4 @@
 ^CMake Error in CMakeLists.txt:
-  MSVC_RUNTIME_LIBRARY value 'BogusValue' not known for this C compiler.$
+  MSVC_RUNTIME_LIBRARY value 'BogusValue' not known for this C compiler.
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/ObjectLibrary/OwnSources-stderr.txt

@@ -2,4 +2,6 @@
   The SOURCES of "A" use a generator expression that depends on the SOURCES
   themselves.
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/TargetPropertyGeneratorExpressions/BadInvalidName-stderr.txt

@@ -47,4 +47,6 @@
     \$<TARGET_PROPERTY:>
 
   \$<TARGET_PROPERTY:...> expression requires a non-empty property name.
-*)+$
+*)+
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/TargetPropertyGeneratorExpressions/BadNonTarget-stderr.txt

@@ -5,4 +5,6 @@ CMake Error at BadNonTarget.cmake:7 \(include_directories\):
 
   Target "NonExistent" not found.
 Call Stack \(most recent call first\):
-  CMakeLists\.txt:[0-9]+ \(include\)$
+  CMakeLists\.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/TargetPropertyGeneratorExpressions/BadSelfReference-stderr.txt

@@ -34,4 +34,6 @@
     \$<TARGET_PROPERTY:BadSelfReference6,COMPILE_DEFINITIONS>
 
   Self reference on target "BadSelfReference6".
-*)+$
+*)+
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/XcodeProject/PerConfigPerSourceDefinitions-stderr.txt

@@ -5,4 +5,6 @@
 
   specified for source:
 
-    .*/Tests/RunCMake/XcodeProject/main.c$
+    .*/Tests/RunCMake/XcodeProject/main.c
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/XcodeProject/PerConfigPerSourceFlags-stderr.txt

@@ -5,4 +5,6 @@
 
   specified for source:
 
-    .*/Tests/RunCMake/XcodeProject/main.c$
+    .*/Tests/RunCMake/XcodeProject/main.c
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/XcodeProject/PerConfigPerSourceIncludeDirs-stderr.txt

@@ -5,4 +5,6 @@
 
   specified for source:
 
-    .*/Tests/RunCMake/XcodeProject/main.c$
+    .*/Tests/RunCMake/XcodeProject/main.c
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/XcodeProject/PerConfigPerSourceOptions-stderr.txt

@@ -5,4 +5,6 @@
 
   specified for source:
 
-    .*/Tests/RunCMake/XcodeProject/main.c$
+    .*/Tests/RunCMake/XcodeProject/main.c
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_executable/NoSources-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at NoSources.cmake:[0-9]+ \(add_executable\):
   No SOURCES given to target: TestExeWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_executable/NoSourcesButLinkObjects-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at NoSourcesButLinkObjects.cmake:[0-9]+ \(add_executable\):
   No SOURCES given to target: TestExeWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/MODULEwithNoSources-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at MODULEwithNoSources.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestModuleLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/MODULEwithNoSourcesButLinkObjects-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at MODULEwithNoSourcesButLinkObjects.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestModuleLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/OBJECTwithNoSources-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at OBJECTwithNoSources.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestObjectLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/OBJECTwithNoSourcesButLinkObjects-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at OBJECTwithNoSourcesButLinkObjects.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestObjectLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/SHAREDwithNoSources-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at SHAREDwithNoSources.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestSharedLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/SHAREDwithNoSourcesButLinkObjects-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at SHAREDwithNoSourcesButLinkObjects.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestSharedLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/STATICwithNoSources-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at STATICwithNoSources.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestStaticLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$

Tests/RunCMake/add_library/STATICwithNoSourcesButLinkObjects-stderr.txt

@@ -1,4 +1,6 @@
 ^CMake Error at STATICwithNoSourcesButLinkObjects.cmake:[0-9]+ \(add_library\):
   No SOURCES given to target: TestStaticLibWithoutSources
 Call Stack \(most recent call first\):
-  CMakeLists.txt:[0-9]+ \(include\)$
+  CMakeLists.txt:[0-9]+ \(include\)
++
+CMake Generate step failed\.  Build files cannot be regenerated correctly\.$