瀏覽代碼

Trust umask for file permissions

Open output files with mode 0666 so that permissions are not more strict
than umask permits.  See issue #10126.
Brad King 16 年之前
父節點
當前提交
8d0161c8ff
共有 3 個文件被更改,包括 6 次插入11 次删除
  1. 2 4
      Source/cmFileCommand.cxx
  2. 2 4
      Source/cmWriteFileCommand.cxx
  3. 2 3
      Source/kwsys/ProcessUNIX.c

+ 2 - 4
Source/cmFileCommand.cxx

@@ -189,9 +189,7 @@ bool cmFileCommand::HandleWriteCommand(std::vector<std::string> const& args,
 #elif defined( __BORLANDC__ )
     S_IRUSR | S_IWUSR
 #else
-    S_IRUSR | S_IWUSR |
-    S_IRGRP |
-    S_IROTH
+    0666
 #endif
     ;
 
@@ -202,7 +200,7 @@ bool cmFileCommand::HandleWriteCommand(std::vector<std::string> const& args,
 #if defined( _MSC_VER ) || defined( __MINGW32__ )
       S_IREAD | S_IWRITE
 #else
-      S_IRUSR | S_IWUSR
+      0666
 #endif
     );
     }

+ 2 - 4
Source/cmWriteFileCommand.cxx

@@ -60,9 +60,7 @@ bool cmWriteFileCommand
 #elif defined( __BORLANDC__ )
     S_IRUSR | S_IWUSR
 #else
-    S_IRUSR | S_IWUSR |
-    S_IRGRP |
-    S_IROTH
+    0666
 #endif
     ;
 
@@ -73,7 +71,7 @@ bool cmWriteFileCommand
 #if defined( _MSC_VER ) || defined( __MINGW32__ )
       S_IREAD | S_IWRITE
 #else
-      S_IRUSR | S_IWUSR
+      0666
 #endif
     );
     }

+ 2 - 3
Source/kwsys/ProcessUNIX.c

@@ -1875,9 +1875,8 @@ static int kwsysProcessSetupOutputPipeFile(int* p, const char* name)
   /* Close the existing descriptor.  */
   kwsysProcessCleanupDescriptor(p);
 
-  /* Open a file for the pipe to write (permissions 644).  */
-  if((fout = open(name, O_WRONLY | O_CREAT | O_TRUNC,
-                  S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH)) < 0)
+  /* Open a file for the pipe to write.  */
+  if((fout = open(name, O_WRONLY | O_CREAT | O_TRUNC, 0666)) < 0)
     {
     return 0;
     }